[INFO] updating cached repository adudney/BL2_Converter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adudney/BL2_Converter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adudney/BL2_Converter" "work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Converter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adudney/BL2_Converter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Converter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Converter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afe8510b920b1bfd66d1020c70bb8b52a7b37de3 [INFO] sha for GitHub repo adudney/BL2_Converter: afe8510b920b1bfd66d1020c70bb8b52a7b37de3 [INFO] validating manifest of adudney/BL2_Converter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adudney/BL2_Converter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adudney/BL2_Converter [INFO] finished frobbing adudney/BL2_Converter [INFO] frobbed toml for adudney/BL2_Converter written to work/ex/clippy-test-run/sources/stable/gh/adudney/BL2_Converter/Cargo.toml [INFO] started frobbing adudney/BL2_Converter [INFO] finished frobbing adudney/BL2_Converter [INFO] frobbed toml for adudney/BL2_Converter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Converter/Cargo.toml [INFO] crate adudney/BL2_Converter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adudney/BL2_Converter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adudney/BL2_Converter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36424aad1303d5143a16fa58ef10d385c39d8744b1f6db012e910159ff591360 [INFO] running `"docker" "start" "-a" "36424aad1303d5143a16fa58ef10d385c39d8744b1f6db012e910159ff591360"` [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Checking converter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(output, "")` [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | writeln!(output, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(output, "")` [INFO] [stderr] --> src/main.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | writeln!(output, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:81 [INFO] [stderr] | [INFO] [stderr] 33 | files.push((Path::new(filename).to_path_buf(), File::open(filename).expect(&format!("Can't find file: {}", filename)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't find file: {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:39:80 [INFO] [stderr] | [INFO] [stderr] 39 | files.push((dir_entry.path(), File::open(dir_entry.path()).expect(&format!("Can't find file: {}", dir_entry.path().file_name().unwrap().to_str().unwrap())))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't find file: {}", dir_entry.path().file_name().unwrap().to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:56:122 [INFO] [stderr] | [INFO] [stderr] 56 | let prefix = file.0.file_name().expect("File name not found").to_str().expect("File name not unicode").splitn(2, ".").next().expect("File has no name").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:67:44 [INFO] [stderr] | [INFO] [stderr] 67 | let mut parts = line.splitn(2, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let command = parts.next().expect(&format!("Syntax error: {}", line)).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:69:37 [INFO] [stderr] | [INFO] [stderr] 69 | let data = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:52 [INFO] [stderr] | [INFO] [stderr] 72 | let mut parts = data.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:78 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:147 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:216 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | let mut parts = data.splitn(4, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:81 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:150 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:219 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:288 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | let mut parts = data.splitn(2, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | let command = parts.next().expect(&format!("Syntax error: {}", line)).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | let package = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:94:56 [INFO] [stderr] | [INFO] [stderr] 94 | let package = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / match ¤t_type { [INFO] [stderr] 125 | | &HotfixType::Level(ref x) => { [INFO] [stderr] 126 | | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 127 | | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | match current_type { [INFO] [stderr] 125 | HotfixType::Level(ref x) => { [INFO] [stderr] 126 | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 127 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] 128 | level_index += 1; [INFO] [stderr] 129 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:71 [INFO] [stderr] | [INFO] [stderr] 127 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:132:71 [INFO] [stderr] | [INFO] [stderr] 132 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / match ¤t_type { [INFO] [stderr] 144 | | &HotfixType::Level(ref x) => { [INFO] [stderr] 145 | | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 146 | | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | match current_type { [INFO] [stderr] 144 | HotfixType::Level(ref x) => { [INFO] [stderr] 145 | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 146 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] 147 | level_index += 1; [INFO] [stderr] 148 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:146:73 [INFO] [stderr] | [INFO] [stderr] 146 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:151:73 [INFO] [stderr] | [INFO] [stderr] 151 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `keys` [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..keys.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for (i, ) in keys.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `values` [INFO] [stderr] --> src/main.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | for i in 0..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 177 | for (i, ) in values.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:33:81 [INFO] [stderr] | [INFO] [stderr] 33 | files.push((Path::new(filename).to_path_buf(), File::open(filename).expect(&format!("Can't find file: {}", filename)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't find file: {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:39:80 [INFO] [stderr] | [INFO] [stderr] 39 | files.push((dir_entry.path(), File::open(dir_entry.path()).expect(&format!("Can't find file: {}", dir_entry.path().file_name().unwrap().to_str().unwrap())))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't find file: {}", dir_entry.path().file_name().unwrap().to_str().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:56:122 [INFO] [stderr] | [INFO] [stderr] 56 | let prefix = file.0.file_name().expect("File name not found").to_str().expect("File name not unicode").splitn(2, ".").next().expect("File has no name").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:67:44 [INFO] [stderr] | [INFO] [stderr] 67 | let mut parts = line.splitn(2, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let command = parts.next().expect(&format!("Syntax error: {}", line)).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:69:37 [INFO] [stderr] | [INFO] [stderr] 69 | let data = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:52 [INFO] [stderr] | [INFO] [stderr] 72 | let mut parts = data.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:78 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:147 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:216 [INFO] [stderr] | [INFO] [stderr] 73 | lines.push((prefix.clone(), ParsedLine::Set(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | let mut parts = data.splitn(4, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:81 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:150 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:219 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:77:288 [INFO] [stderr] | [INFO] [stderr] 77 | lines.push((prefix.clone(), ParsedLine::SetCmp(parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string(), parts.next().expect(&format!("Syntax error: {}", line)).to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | let mut parts = data.splitn(2, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | let command = parts.next().expect(&format!("Syntax error: {}", line)).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:86:56 [INFO] [stderr] | [INFO] [stderr] 86 | let package = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:94:56 [INFO] [stderr] | [INFO] [stderr] 94 | let package = parts.next().expect(&format!("Syntax error: {}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Syntax error: {}", line))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / match ¤t_type { [INFO] [stderr] 125 | | &HotfixType::Level(ref x) => { [INFO] [stderr] 126 | | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 127 | | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | match current_type { [INFO] [stderr] 125 | HotfixType::Level(ref x) => { [INFO] [stderr] 126 | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 127 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] 128 | level_index += 1; [INFO] [stderr] 129 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:71 [INFO] [stderr] | [INFO] [stderr] 127 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:132:71 [INFO] [stderr] | [INFO] [stderr] 132 | values.push(format!("{},{},{},,{}", x.clone().unwrap_or("".to_string()), obj, path, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / match ¤t_type { [INFO] [stderr] 144 | | &HotfixType::Level(ref x) => { [INFO] [stderr] 145 | | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 146 | | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 143 | match current_type { [INFO] [stderr] 144 | HotfixType::Level(ref x) => { [INFO] [stderr] 145 | keys.push(format!("SparkLevelPatchEntry-{}{}", prefix, level_index)); [INFO] [stderr] 146 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] 147 | level_index += 1; [INFO] [stderr] 148 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:146:73 [INFO] [stderr] | [INFO] [stderr] 146 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:151:73 [INFO] [stderr] | [INFO] [stderr] 151 | values.push(format!("{},{},{},{},{}", x.clone().unwrap_or("".to_string()), obj, path, cmp_value, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `keys` [INFO] [stderr] --> src/main.rs:168:14 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..keys.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for (i, ) in keys.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `values` [INFO] [stderr] --> src/main.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | for i in 0..values.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 177 | for (i, ) in values.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.91s [INFO] running `"docker" "inspect" "36424aad1303d5143a16fa58ef10d385c39d8744b1f6db012e910159ff591360"` [INFO] running `"docker" "rm" "-f" "36424aad1303d5143a16fa58ef10d385c39d8744b1f6db012e910159ff591360"` [INFO] [stdout] 36424aad1303d5143a16fa58ef10d385c39d8744b1f6db012e910159ff591360