[INFO] updating cached repository adrianclay/rust_roman_numerals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adrianclay/rust_roman_numerals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adrianclay/rust_roman_numerals" "work/ex/clippy-test-run/sources/stable/gh/adrianclay/rust_roman_numerals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adrianclay/rust_roman_numerals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adrianclay/rust_roman_numerals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adrianclay/rust_roman_numerals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adrianclay/rust_roman_numerals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd997dc42a4a381687db471baf9634441e4853dd [INFO] sha for GitHub repo adrianclay/rust_roman_numerals: bd997dc42a4a381687db471baf9634441e4853dd [INFO] validating manifest of adrianclay/rust_roman_numerals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adrianclay/rust_roman_numerals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adrianclay/rust_roman_numerals [INFO] finished frobbing adrianclay/rust_roman_numerals [INFO] frobbed toml for adrianclay/rust_roman_numerals written to work/ex/clippy-test-run/sources/stable/gh/adrianclay/rust_roman_numerals/Cargo.toml [INFO] started frobbing adrianclay/rust_roman_numerals [INFO] finished frobbing adrianclay/rust_roman_numerals [INFO] frobbed toml for adrianclay/rust_roman_numerals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adrianclay/rust_roman_numerals/Cargo.toml [INFO] crate adrianclay/rust_roman_numerals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adrianclay/rust_roman_numerals against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adrianclay/rust_roman_numerals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25333dfb0580e5841841ea5380909850eb002e69b904f1cf0a97d2d41ec6273a [INFO] running `"docker" "start" "-a" "25333dfb0580e5841841ea5380909850eb002e69b904f1cf0a97d2d41ec6273a"` [INFO] [stderr] Checking roman_numerals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return roman_numerals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `roman_numerals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return roman_numerals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `roman_numerals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | println!("As roman numerals: {}", roman_numerals(x as u32)); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:54 [INFO] [stderr] | [INFO] [stderr] 6 | println!("As roman numerals: {}", roman_numerals(x as u32)); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "25333dfb0580e5841841ea5380909850eb002e69b904f1cf0a97d2d41ec6273a"` [INFO] running `"docker" "rm" "-f" "25333dfb0580e5841841ea5380909850eb002e69b904f1cf0a97d2d41ec6273a"` [INFO] [stdout] 25333dfb0580e5841841ea5380909850eb002e69b904f1cf0a97d2d41ec6273a