[INFO] updating cached repository adicatana/hello_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adicatana/hello_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adicatana/hello_rust" "work/ex/clippy-test-run/sources/stable/gh/adicatana/hello_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adicatana/hello_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adicatana/hello_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adicatana/hello_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adicatana/hello_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dcc5bfe6df09e1d5297eb0ca44fa4553e22db9af [INFO] sha for GitHub repo adicatana/hello_rust: dcc5bfe6df09e1d5297eb0ca44fa4553e22db9af [INFO] validating manifest of adicatana/hello_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adicatana/hello_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adicatana/hello_rust [INFO] finished frobbing adicatana/hello_rust [INFO] frobbed toml for adicatana/hello_rust written to work/ex/clippy-test-run/sources/stable/gh/adicatana/hello_rust/Cargo.toml [INFO] started frobbing adicatana/hello_rust [INFO] finished frobbing adicatana/hello_rust [INFO] frobbed toml for adicatana/hello_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adicatana/hello_rust/Cargo.toml [INFO] crate adicatana/hello_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adicatana/hello_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adicatana/hello_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba5696e05318a713e0fbdebb17d7966ce9d539bcd2056dbfc2bf8f990abaede2 [INFO] running `"docker" "start" "-a" "ba5696e05318a713e0fbdebb17d7966ce9d539bcd2056dbfc2bf8f990abaede2"` [INFO] [stderr] Checking hello_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/two_sum.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 22 | | if let Some(&i) = freq.get(&curr) { [INFO] [stderr] 23 | | freq.insert(curr, i + 1); [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | freq.insert(curr, 1); [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | } else if let Some(&i) = freq.get(&curr) { [INFO] [stderr] 22 | freq.insert(curr, i + 1); [INFO] [stderr] 23 | } else { [INFO] [stderr] 24 | freq.insert(curr, 1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/two_sum.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 22 | | if let Some(&i) = freq.get(&curr) { [INFO] [stderr] 23 | | freq.insert(curr, i + 1); [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | freq.insert(curr, 1); [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | } else if let Some(&i) = freq.get(&curr) { [INFO] [stderr] 22 | freq.insert(curr, i + 1); [INFO] [stderr] 23 | } else { [INFO] [stderr] 24 | freq.insert(curr, 1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fibonacci.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | fn first_word(s: &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/two_sum.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn two_sum(nums: &Vec, target: i32) -> Vec<(i32, i32)> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `nums`. [INFO] [stderr] --> src/two_sum.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | for i in 0..nums.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 10 | for in &nums { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove` doesn't need a mutable reference [INFO] [stderr] --> src/two_sum.rs:18:33 [INFO] [stderr] | [INFO] [stderr] 18 | freq.remove(&mut (target - curr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fibonacci.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | fn first_word(s: &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/two_sum.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn two_sum(nums: &Vec, target: i32) -> Vec<(i32, i32)> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `nums`. [INFO] [stderr] --> src/two_sum.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | for i in 0..nums.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 10 | for in &nums { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove` doesn't need a mutable reference [INFO] [stderr] --> src/two_sum.rs:18:33 [INFO] [stderr] | [INFO] [stderr] 18 | freq.remove(&mut (target - curr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FILE_IN` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const FILE_IN: &str = "text.in"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `custom_read` [INFO] [stderr] --> src/main.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | fn custom_read() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Point` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | struct Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | fn x(&self) -> &T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FILE_IN` [INFO] [stderr] --> src/main.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const FILE_IN: &str = "text.in"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `custom_read` [INFO] [stderr] --> src/main.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | fn custom_read() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Point` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | struct Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `x` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | fn x(&self) -> &T { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "ba5696e05318a713e0fbdebb17d7966ce9d539bcd2056dbfc2bf8f990abaede2"` [INFO] running `"docker" "rm" "-f" "ba5696e05318a713e0fbdebb17d7966ce9d539bcd2056dbfc2bf8f990abaede2"` [INFO] [stdout] ba5696e05318a713e0fbdebb17d7966ce9d539bcd2056dbfc2bf8f990abaede2