[INFO] updating cached repository adamisntdead/markov-chains [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/adamisntdead/markov-chains [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/adamisntdead/markov-chains" "work/ex/clippy-test-run/sources/stable/gh/adamisntdead/markov-chains"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adamisntdead/markov-chains'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/adamisntdead/markov-chains" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamisntdead/markov-chains"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamisntdead/markov-chains'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e55d1a6bc66a5f2da26b312da63dea9b4d67138d [INFO] sha for GitHub repo adamisntdead/markov-chains: e55d1a6bc66a5f2da26b312da63dea9b4d67138d [INFO] validating manifest of adamisntdead/markov-chains on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adamisntdead/markov-chains on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adamisntdead/markov-chains [INFO] finished frobbing adamisntdead/markov-chains [INFO] frobbed toml for adamisntdead/markov-chains written to work/ex/clippy-test-run/sources/stable/gh/adamisntdead/markov-chains/Cargo.toml [INFO] started frobbing adamisntdead/markov-chains [INFO] finished frobbing adamisntdead/markov-chains [INFO] frobbed toml for adamisntdead/markov-chains written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamisntdead/markov-chains/Cargo.toml [INFO] crate adamisntdead/markov-chains has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adamisntdead/markov-chains against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamisntdead/markov-chains:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cad8602978d77bd327b4e0681c1837928c742e1cea6a72b42d84d22a62f6147 [INFO] running `"docker" "start" "-a" "7cad8602978d77bd327b4e0681c1837928c742e1cea6a72b42d84d22a62f6147"` [INFO] [stderr] Checking markov-chains v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|x| String::from(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / if !cache.contains_key(&key) { [INFO] [stderr] 28 | | cache.insert(key, vec![item]); [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | cache.get_mut(&key).unwrap().push(item); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: consider using: `cache.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn generate_text(cache: HashMap>, num_words: i32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 37 | pub fn generate_text(cache: HashMap, S>, num_words: i32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:43 [INFO] [stderr] | [INFO] [stderr] 50 | let words: Vec<&str> = seed_key.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:9:14 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|x| String::from(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / if !cache.contains_key(&key) { [INFO] [stderr] 28 | | cache.insert(key, vec![item]); [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | cache.get_mut(&key).unwrap().push(item); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: consider using: `cache.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn generate_text(cache: HashMap>, num_words: i32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 37 | pub fn generate_text(cache: HashMap, S>, num_words: i32) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:43 [INFO] [stderr] | [INFO] [stderr] 50 | let words: Vec<&str> = seed_key.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "7cad8602978d77bd327b4e0681c1837928c742e1cea6a72b42d84d22a62f6147"` [INFO] running `"docker" "rm" "-f" "7cad8602978d77bd327b4e0681c1837928c742e1cea6a72b42d84d22a62f6147"` [INFO] [stdout] 7cad8602978d77bd327b4e0681c1837928c742e1cea6a72b42d84d22a62f6147