[INFO] updating cached repository adamAndMath/RandomLoot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/adamAndMath/RandomLoot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/adamAndMath/RandomLoot" "work/ex/clippy-test-run/sources/stable/gh/adamAndMath/RandomLoot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/adamAndMath/RandomLoot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/adamAndMath/RandomLoot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamAndMath/RandomLoot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamAndMath/RandomLoot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bc3035b7417d911c305d160c13cf4f6c149644b9
[INFO] sha for GitHub repo adamAndMath/RandomLoot: bc3035b7417d911c305d160c13cf4f6c149644b9
[INFO] validating manifest of adamAndMath/RandomLoot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of adamAndMath/RandomLoot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing adamAndMath/RandomLoot
[INFO] finished frobbing adamAndMath/RandomLoot
[INFO] frobbed toml for adamAndMath/RandomLoot written to work/ex/clippy-test-run/sources/stable/gh/adamAndMath/RandomLoot/Cargo.toml
[INFO] started frobbing adamAndMath/RandomLoot
[INFO] finished frobbing adamAndMath/RandomLoot
[INFO] frobbed toml for adamAndMath/RandomLoot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamAndMath/RandomLoot/Cargo.toml
[INFO] crate adamAndMath/RandomLoot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting adamAndMath/RandomLoot against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/adamAndMath/RandomLoot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2461e1542bc8da978097dfea956c135a483982617daea05ab0ed1e80c159c55c
[INFO] running `"docker" "start" "-a" "2461e1542bc8da978097dfea956c135a483982617daea05ab0ed1e80c159c55c"`
[INFO] [stderr]     Checking random_loot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:36
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:50
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:36
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/group/group.rs:25:50
[INFO] [stderr]    |
[INFO] [stderr] 25 |         Ok(Group { format: format, items: items, generator: generator })
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `generator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/group/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod group;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/group/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod group;
[INFO] [stderr]   | ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Parser`
[INFO] [stderr]  --> src/format/var.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     Parser,
[INFO] [stderr]   |     ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Parser`
[INFO] [stderr]  --> src/format/var.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     Parser,
[INFO] [stderr]   |     ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `item::Item`
[INFO] [stderr]   --> src/item/mod.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> Item {
[INFO] [stderr] 23 | |         Item(HashMap::new())
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/item/mod.rs:30:42
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn get(&self, k: &str) -> Option<&Box<Prop>> {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: try: `&Prop`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/var.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let mut iter = s.splitn(2, ":").map(|s|s.trim());
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:44:37
[INFO] [stderr]    |
[INFO] [stderr] 44 |             } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |             } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:45:52
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 let labels = s[1..s.len()-1].split(",").map(|s|s.trim()).collect::<Vec<_>>();
[INFO] [stderr]    |                                                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/format/ty.rs:112:32
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub fn to_string(&self, p: &Box<Prop>) -> String {
[INFO] [stderr]     |                                ^^^^^^^^^^ help: try: `&Prop`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:58:33
[INFO] [stderr]    |
[INFO] [stderr] 58 |         } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:58:53
[INFO] [stderr]    |
[INFO] [stderr] 58 |         } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                                     ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |             if s.contains(",") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 s.split(",").map(|s| {
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:62:45
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     let mut v = s.splitn(2, "=");
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/format/unit.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let unit = self.0.iter().filter(|(u,_)|s.ends_with(u)).next();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|(u,_)|s.ends_with(u)).next()` with `find(|(u,_)|s.ends_with(u))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/mod.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 |         s.split(";").map(Var::from_str).collect::<Result<_, _>>().map(Format)
[INFO] [stderr]    |                 ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/generator.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     pub fn generate<'a>(&'a self) -> Iter<'a, E> {
[INFO] [stderr] 117 | |         Iter { generator: self, rng: rand::thread_rng() }
[INFO] [stderr] 118 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/group/group.rs:40:45
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let quantifier: Quantifier<usize> = self.generator.generate().take(amount).map(|i| *i).collect();
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.generator.generate().take(amount).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/group/err.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match self {
[INFO] [stderr] 39 | |             &GroupErr::EmptyFile => write!(f, "File is empty"),
[INFO] [stderr] 40 | |             &GroupErr::NoItems => write!(f, "No items"),
[INFO] [stderr] 41 | |             &GroupErr::File(_) => write!(f, "Failed to open file"),
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |             }
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match *self {
[INFO] [stderr] 39 |             GroupErr::EmptyFile => write!(f, "File is empty"),
[INFO] [stderr] 40 |             GroupErr::NoItems => write!(f, "No items"),
[INFO] [stderr] 41 |             GroupErr::File(_) => write!(f, "Failed to open file"),
[INFO] [stderr] 42 |             GroupErr::FormatParse(_) => write!(f, "Failed to parse format"),
[INFO] [stderr] 43 |             GroupErr::ItemParse(ref v) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/group/err.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &GroupErr::EmptyFile => "File is empty",
[INFO] [stderr] 60 | |             &GroupErr::NoItems => "No items",
[INFO] [stderr] 61 | |             &GroupErr::File(_) => "Failed to open file",
[INFO] [stderr] 62 | |             &GroupErr::FormatParse(_) => "Failed to parse format",
[INFO] [stderr] 63 | |             &GroupErr::ItemParse(_) => "Failed to parse items",
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             GroupErr::EmptyFile => "File is empty",
[INFO] [stderr] 60 |             GroupErr::NoItems => "No items",
[INFO] [stderr] 61 |             GroupErr::File(_) => "Failed to open file",
[INFO] [stderr] 62 |             GroupErr::FormatParse(_) => "Failed to parse format",
[INFO] [stderr] 63 |             GroupErr::ItemParse(_) => "Failed to parse items",
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `item::Item`
[INFO] [stderr]   --> src/item/mod.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn new() -> Item {
[INFO] [stderr] 23 | |         Item(HashMap::new())
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]   --> src/item/mod.rs:30:42
[INFO] [stderr]    |
[INFO] [stderr] 30 |     pub fn get(&self, k: &str) -> Option<&Box<Prop>> {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: try: `&Prop`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/var.rs:32:36
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let mut iter = s.splitn(2, ":").map(|s|s.trim());
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:44:37
[INFO] [stderr]    |
[INFO] [stderr] 44 |             } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:44:57
[INFO] [stderr]    |
[INFO] [stderr] 44 |             } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                                         ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/ty.rs:45:52
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 let labels = s[1..s.len()-1].split(",").map(|s|s.trim()).collect::<Vec<_>>();
[INFO] [stderr]    |                                                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/format/ty.rs:112:32
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub fn to_string(&self, p: &Box<Prop>) -> String {
[INFO] [stderr]     |                                ^^^^^^^^^^ help: try: `&Prop`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:58:33
[INFO] [stderr]    |
[INFO] [stderr] 58 |         } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                 ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:58:53
[INFO] [stderr]    |
[INFO] [stderr] 58 |         } else if s.starts_with("[") && s.ends_with("]") {
[INFO] [stderr]    |                                                     ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |             if s.contains(",") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 s.split(",").map(|s| {
[INFO] [stderr]    |                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/unit.rs:62:45
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     let mut v = s.splitn(2, "=");
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/format/unit.rs:106:20
[INFO] [stderr]     |
[INFO] [stderr] 106 |         let unit = self.0.iter().filter(|(u,_)|s.ends_with(u)).next();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|(u,_)|s.ends_with(u)).next()` with `find(|(u,_)|s.ends_with(u))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/format/mod.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 |         s.split(";").map(Var::from_str).collect::<Result<_, _>>().map(Format)
[INFO] [stderr]    |                 ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/generator.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 | /     pub fn generate<'a>(&'a self) -> Iter<'a, E> {
[INFO] [stderr] 117 | |         Iter { generator: self, rng: rand::thread_rng() }
[INFO] [stderr] 118 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/group/group.rs:40:45
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let quantifier: Quantifier<usize> = self.generator.generate().take(amount).map(|i| *i).collect();
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.generator.generate().take(amount).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/group/err.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match self {
[INFO] [stderr] 39 | |             &GroupErr::EmptyFile => write!(f, "File is empty"),
[INFO] [stderr] 40 | |             &GroupErr::NoItems => write!(f, "No items"),
[INFO] [stderr] 41 | |             &GroupErr::File(_) => write!(f, "Failed to open file"),
[INFO] [stderr] ...  |
[INFO] [stderr] 51 | |             }
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match *self {
[INFO] [stderr] 39 |             GroupErr::EmptyFile => write!(f, "File is empty"),
[INFO] [stderr] 40 |             GroupErr::NoItems => write!(f, "No items"),
[INFO] [stderr] 41 |             GroupErr::File(_) => write!(f, "Failed to open file"),
[INFO] [stderr] 42 |             GroupErr::FormatParse(_) => write!(f, "Failed to parse format"),
[INFO] [stderr] 43 |             GroupErr::ItemParse(ref v) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/group/err.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 | /         match self {
[INFO] [stderr] 59 | |             &GroupErr::EmptyFile => "File is empty",
[INFO] [stderr] 60 | |             &GroupErr::NoItems => "No items",
[INFO] [stderr] 61 | |             &GroupErr::File(_) => "Failed to open file",
[INFO] [stderr] 62 | |             &GroupErr::FormatParse(_) => "Failed to parse format",
[INFO] [stderr] 63 | |             &GroupErr::ItemParse(_) => "Failed to parse items",
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         match *self {
[INFO] [stderr] 59 |             GroupErr::EmptyFile => "File is empty",
[INFO] [stderr] 60 |             GroupErr::NoItems => "No items",
[INFO] [stderr] 61 |             GroupErr::File(_) => "Failed to open file",
[INFO] [stderr] 62 |             GroupErr::FormatParse(_) => "Failed to parse format",
[INFO] [stderr] 63 |             GroupErr::ItemParse(_) => "Failed to parse items",
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.44s
[INFO] running `"docker" "inspect" "2461e1542bc8da978097dfea956c135a483982617daea05ab0ed1e80c159c55c"`
[INFO] running `"docker" "rm" "-f" "2461e1542bc8da978097dfea956c135a483982617daea05ab0ed1e80c159c55c"`
[INFO] [stdout] 2461e1542bc8da978097dfea956c135a483982617daea05ab0ed1e80c159c55c