[INFO] updating cached repository achalddave/rust-tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/achalddave/rust-tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/achalddave/rust-tree" "work/ex/clippy-test-run/sources/stable/gh/achalddave/rust-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/achalddave/rust-tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/achalddave/rust-tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achalddave/rust-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achalddave/rust-tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8b24c7b4b93fbb77f83d93f078eb154e1156c90 [INFO] sha for GitHub repo achalddave/rust-tree: a8b24c7b4b93fbb77f83d93f078eb154e1156c90 [INFO] validating manifest of achalddave/rust-tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of achalddave/rust-tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing achalddave/rust-tree [INFO] finished frobbing achalddave/rust-tree [INFO] frobbed toml for achalddave/rust-tree written to work/ex/clippy-test-run/sources/stable/gh/achalddave/rust-tree/Cargo.toml [INFO] started frobbing achalddave/rust-tree [INFO] finished frobbing achalddave/rust-tree [INFO] frobbed toml for achalddave/rust-tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achalddave/rust-tree/Cargo.toml [INFO] crate achalddave/rust-tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting achalddave/rust-tree against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achalddave/rust-tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6cb2966d7867aa4db2d206710a24d12ccaa3800ca35ad365a8f4c0c413c07cfd [INFO] running `"docker" "start" "-a" "6cb2966d7867aa4db2d206710a24d12ccaa3800ca35ad365a8f4c0c413c07cfd"` [INFO] [stderr] Checking tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return print_dir_recursive(path, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `print_dir_recursive(path, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let mut path = "."; [INFO] [stderr] 15 | | if args.len() > 1 { [INFO] [stderr] 16 | | path = &args[1]; [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let path = if args.len() > 1 { &args[1] } else { "." };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return print_dir_recursive(path, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `print_dir_recursive(path, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let mut path = "."; [INFO] [stderr] 15 | | if args.len() > 1 { [INFO] [stderr] 16 | | path = &args[1]; [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let path = if args.len() > 1 { &args[1] } else { "." };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "6cb2966d7867aa4db2d206710a24d12ccaa3800ca35ad365a8f4c0c413c07cfd"` [INFO] running `"docker" "rm" "-f" "6cb2966d7867aa4db2d206710a24d12ccaa3800ca35ad365a8f4c0c413c07cfd"` [INFO] [stdout] 6cb2966d7867aa4db2d206710a24d12ccaa3800ca35ad365a8f4c0c413c07cfd