[INFO] updating cached repository acgaudette/i3-highlight-focused [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/acgaudette/i3-highlight-focused [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/acgaudette/i3-highlight-focused" "work/ex/clippy-test-run/sources/stable/gh/acgaudette/i3-highlight-focused"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/acgaudette/i3-highlight-focused'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/acgaudette/i3-highlight-focused" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acgaudette/i3-highlight-focused"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acgaudette/i3-highlight-focused'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78bb0b30bed8b9274085d24d29b7a3f5bbdb51b5 [INFO] sha for GitHub repo acgaudette/i3-highlight-focused: 78bb0b30bed8b9274085d24d29b7a3f5bbdb51b5 [INFO] validating manifest of acgaudette/i3-highlight-focused on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of acgaudette/i3-highlight-focused on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing acgaudette/i3-highlight-focused [INFO] finished frobbing acgaudette/i3-highlight-focused [INFO] frobbed toml for acgaudette/i3-highlight-focused written to work/ex/clippy-test-run/sources/stable/gh/acgaudette/i3-highlight-focused/Cargo.toml [INFO] started frobbing acgaudette/i3-highlight-focused [INFO] finished frobbing acgaudette/i3-highlight-focused [INFO] frobbed toml for acgaudette/i3-highlight-focused written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acgaudette/i3-highlight-focused/Cargo.toml [INFO] crate acgaudette/i3-highlight-focused has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting acgaudette/i3-highlight-focused against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acgaudette/i3-highlight-focused:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85edf38bd33f3a441ea5168ffaab7b3213779ea9b1867f4169c663d295522248 [INFO] running `"docker" "start" "-a" "85edf38bd33f3a441ea5168ffaab7b3213779ea9b1867f4169c663d295522248"` [INFO] [stderr] Checking debug-builders v0.1.0 [INFO] [stderr] Checking byteorder v0.3.13 [INFO] [stderr] Checking serde v0.6.15 [INFO] [stderr] Checking unix_socket v0.4.6 [INFO] [stderr] Checking serde_json v0.6.1 [INFO] [stderr] Checking i3ipc v0.5.0 [INFO] [stderr] Checking i3-highlight-focused v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `i3ipc::reply::NodeLayout` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use i3ipc::reply::NodeLayout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `i3ipc::reply::NodeLayout` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use i3ipc::reply::NodeLayout; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | let mut i3 = I3Connection::connect().ok().expect("Failed to connect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | let mut listener = I3EventListener::connect().ok().expect("Failed to bind"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | listener.subscribe(&subs).ok().expect("Failed to subscribe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match e.change { [INFO] [stderr] 29 | | // On new window focus [INFO] [stderr] 30 | | inner::WindowChange::Focus => { [INFO] [stderr] 31 | | // Ignore quake console [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => { } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let inner::WindowChange::Focus = e.change { [INFO] [stderr] 29 | // Ignore quake console [INFO] [stderr] 30 | if e.container.name.unwrap() == "quaketerm" { continue; } [INFO] [stderr] 31 | [INFO] [stderr] 32 | // Ignore stacked windows [INFO] [stderr] 33 | if e.container.deco_rect.2 != 0 { continue; } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let mut i3 = I3Connection::connect().ok() [INFO] [stderr] | __________________^ [INFO] [stderr] 82 | | .expect("Failed to connect (aux thread)"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | let mut i3 = I3Connection::connect().ok().expect("Failed to connect"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | let mut listener = I3EventListener::connect().ok().expect("Failed to bind"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | listener.subscribe(&subs).ok().expect("Failed to subscribe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match e.change { [INFO] [stderr] 29 | | // On new window focus [INFO] [stderr] 30 | | inner::WindowChange::Focus => { [INFO] [stderr] 31 | | // Ignore quake console [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => { } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let inner::WindowChange::Focus = e.change { [INFO] [stderr] 29 | // Ignore quake console [INFO] [stderr] 30 | if e.container.name.unwrap() == "quaketerm" { continue; } [INFO] [stderr] 31 | [INFO] [stderr] 32 | // Ignore stacked windows [INFO] [stderr] 33 | if e.container.deco_rect.2 != 0 { continue; } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | let mut i3 = I3Connection::connect().ok() [INFO] [stderr] | __________________^ [INFO] [stderr] 82 | | .expect("Failed to connect (aux thread)"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.05s [INFO] running `"docker" "inspect" "85edf38bd33f3a441ea5168ffaab7b3213779ea9b1867f4169c663d295522248"` [INFO] running `"docker" "rm" "-f" "85edf38bd33f3a441ea5168ffaab7b3213779ea9b1867f4169c663d295522248"` [INFO] [stdout] 85edf38bd33f3a441ea5168ffaab7b3213779ea9b1867f4169c663d295522248