[INFO] updating cached repository ace-lab/reveal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ace-lab/reveal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ace-lab/reveal" "work/ex/clippy-test-run/sources/stable/gh/ace-lab/reveal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ace-lab/reveal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ace-lab/reveal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ace-lab/reveal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ace-lab/reveal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59d37601189660472dad8a9da6dfe55112bc604a [INFO] sha for GitHub repo ace-lab/reveal: 59d37601189660472dad8a9da6dfe55112bc604a [INFO] validating manifest of ace-lab/reveal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ace-lab/reveal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ace-lab/reveal [INFO] finished frobbing ace-lab/reveal [INFO] frobbed toml for ace-lab/reveal written to work/ex/clippy-test-run/sources/stable/gh/ace-lab/reveal/Cargo.toml [INFO] started frobbing ace-lab/reveal [INFO] finished frobbing ace-lab/reveal [INFO] frobbed toml for ace-lab/reveal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ace-lab/reveal/Cargo.toml [INFO] crate ace-lab/reveal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ace-lab/reveal against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ace-lab/reveal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1469d2d36718845474f2af51fefc1c7bcaeb8f77f3ccb79f9ff27946e9766a95 [INFO] running `"docker" "start" "-a" "1469d2d36718845474f2af51fefc1c7bcaeb8f77f3ccb79f9ff27946e9766a95"` [INFO] [stderr] Checking reveal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if args[1] == "initialize" { [INFO] [stderr] 43 | | // prompt student for data [INFO] [stderr] 44 | | print!("Name: "); [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 42 | | if args[1] == "initialize" { [INFO] [stderr] 43 | | // prompt student for data [INFO] [stderr] 44 | | print!("Name: "); [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if args[1] == "initialize" { [INFO] [stderr] 42 | // prompt student for data [INFO] [stderr] 43 | print!("Name: "); [INFO] [stderr] 44 | let _ = io::stdout().flush(); [INFO] [stderr] 45 | let mut name = String::new(); [INFO] [stderr] 46 | io::stdin().read_line(&mut name) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | } else if args[1] == "initialize" { [INFO] [stderr] 42 | // prompt student for data [INFO] [stderr] 43 | print!("Name: "); [INFO] [stderr] 44 | let _ = io::stdout().flush(); [INFO] [stderr] 45 | let mut name = String::new(); [INFO] [stderr] 46 | io::stdin().read_line(&mut name) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "1469d2d36718845474f2af51fefc1c7bcaeb8f77f3ccb79f9ff27946e9766a95"` [INFO] running `"docker" "rm" "-f" "1469d2d36718845474f2af51fefc1c7bcaeb8f77f3ccb79f9ff27946e9766a95"` [INFO] [stdout] 1469d2d36718845474f2af51fefc1c7bcaeb8f77f3ccb79f9ff27946e9766a95