[INFO] updating cached repository accidentalrebel/csv-to-json
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/accidentalrebel/csv-to-json
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/accidentalrebel/csv-to-json" "work/ex/clippy-test-run/sources/stable/gh/accidentalrebel/csv-to-json"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/accidentalrebel/csv-to-json'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/accidentalrebel/csv-to-json" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/accidentalrebel/csv-to-json"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/accidentalrebel/csv-to-json'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7c636f413fbf51b5c334a6c31fbdf2814d028f21
[INFO] sha for GitHub repo accidentalrebel/csv-to-json: 7c636f413fbf51b5c334a6c31fbdf2814d028f21
[INFO] validating manifest of accidentalrebel/csv-to-json on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of accidentalrebel/csv-to-json on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing accidentalrebel/csv-to-json
[INFO] finished frobbing accidentalrebel/csv-to-json
[INFO] frobbed toml for accidentalrebel/csv-to-json written to work/ex/clippy-test-run/sources/stable/gh/accidentalrebel/csv-to-json/Cargo.toml
[INFO] started frobbing accidentalrebel/csv-to-json
[INFO] finished frobbing accidentalrebel/csv-to-json
[INFO] frobbed toml for accidentalrebel/csv-to-json written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/accidentalrebel/csv-to-json/Cargo.toml
[INFO] crate accidentalrebel/csv-to-json has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting accidentalrebel/csv-to-json against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/accidentalrebel/csv-to-json:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 112fa2ef12c344b09093ffc08dc34db35ce5d2b71e570637841a64df34b718a8
[INFO] running `"docker" "start" "-a" "112fa2ef12c344b09093ffc08dc34db35ce5d2b71e570637841a64df34b718a8"`
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking csv v0.15.0
[INFO] [stderr]     Checking csv_to_json v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:120:20
[INFO] [stderr]     |
[INFO] [stderr] 120 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 121 | |                 if value.is_empty() && args.is_nulled {
[INFO] [stderr] 122 | |                     json[key][header] = json::Null;
[INFO] [stderr] 123 | |                 } else {
[INFO] [stderr] 124 | |                     json[key][header] = value.into();
[INFO] [stderr] 125 | |                 }
[INFO] [stderr] 126 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 120 |             } else if value.is_empty() && args.is_nulled {
[INFO] [stderr] 121 |     json[key][header] = json::Null;
[INFO] [stderr] 122 | } else {
[INFO] [stderr] 123 |     json[key][header] = value.into();
[INFO] [stderr] 124 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:120:20
[INFO] [stderr]     |
[INFO] [stderr] 120 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 121 | |                 if value.is_empty() && args.is_nulled {
[INFO] [stderr] 122 | |                     json[key][header] = json::Null;
[INFO] [stderr] 123 | |                 } else {
[INFO] [stderr] 124 | |                     json[key][header] = value.into();
[INFO] [stderr] 125 | |                 }
[INFO] [stderr] 126 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 120 |             } else if value.is_empty() && args.is_nulled {
[INFO] [stderr] 121 |     json[key][header] = json::Null;
[INFO] [stderr] 122 | } else {
[INFO] [stderr] 123 |     json[key][header] = value.into();
[INFO] [stderr] 124 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 | /     let mut json: JsonValue;
[INFO] [stderr] 164 | |     if !args.is_keyed {
[INFO] [stderr] 165 | |         json = array![];
[INFO] [stderr] 166 | |     } else {
[INFO] [stderr] 167 | |         json = object!{};
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> json = if !args.is_keyed { $ crate :: JsonValue :: new_array (  ) } else { $ crate :: JsonValue :: new_object (  ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:176:30
[INFO] [stderr]     |
[INFO] [stderr] 176 |     while let Some(record) = records_iter.next() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `for record in records_iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:163:5
[INFO] [stderr]     |
[INFO] [stderr] 163 | /     let mut json: JsonValue;
[INFO] [stderr] 164 | |     if !args.is_keyed {
[INFO] [stderr] 165 | |         json = array![];
[INFO] [stderr] 166 | |     } else {
[INFO] [stderr] 167 | |         json = object!{};
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> json = if !args.is_keyed { $ crate :: JsonValue :: new_array (  ) } else { $ crate :: JsonValue :: new_object (  ) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:176:30
[INFO] [stderr]     |
[INFO] [stderr] 176 |     while let Some(record) = records_iter.next() {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: try: `for record in records_iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.02s
[INFO] running `"docker" "inspect" "112fa2ef12c344b09093ffc08dc34db35ce5d2b71e570637841a64df34b718a8"`
[INFO] running `"docker" "rm" "-f" "112fa2ef12c344b09093ffc08dc34db35ce5d2b71e570637841a64df34b718a8"`
[INFO] [stdout] 112fa2ef12c344b09093ffc08dc34db35ce5d2b71e570637841a64df34b718a8