[INFO] updating cached repository abhijat/xray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abhijat/xray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abhijat/xray" "work/ex/clippy-test-run/sources/stable/gh/abhijat/xray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abhijat/xray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abhijat/xray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/xray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/xray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6558b62214553e039c4c909e18d06761f6ba2cae [INFO] sha for GitHub repo abhijat/xray: 6558b62214553e039c4c909e18d06761f6ba2cae [INFO] validating manifest of abhijat/xray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abhijat/xray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abhijat/xray [INFO] finished frobbing abhijat/xray [INFO] frobbed toml for abhijat/xray written to work/ex/clippy-test-run/sources/stable/gh/abhijat/xray/Cargo.toml [INFO] started frobbing abhijat/xray [INFO] finished frobbing abhijat/xray [INFO] frobbed toml for abhijat/xray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/xray/Cargo.toml [INFO] crate abhijat/xray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abhijat/xray against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/xray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 905c9967df943e11c7bf32a6d1bfd2dbac1d811d364c227119eb53dc3cd27424 [INFO] running `"docker" "start" "-a" "905c9967df943e11c7bf32a6d1bfd2dbac1d811d364c227119eb53dc3cd27424"` [INFO] [stderr] Checking xray v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match cmdfile.read_to_string(&mut s) { [INFO] [stderr] 29 | | Err(e) => { [INFO] [stderr] 30 | | println!("Failed to read file {}: error: {}", name, e); [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | _ => () [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Err(e) = cmdfile.read_to_string(&mut s) { [INFO] [stderr] 29 | println!("Failed to read file {}: error: {}", name, e); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or("unstringable".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unstringable".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match p { [INFO] [stderr] 71 | | Some(p) => println!("{}", p), [INFO] [stderr] 72 | | _ => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(p) = p { println!("{}", p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / match read_proc() { [INFO] [stderr] 83 | | Err(e) => println!("Failed to read proc with error {}", e), [INFO] [stderr] 84 | | _ => () [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = read_proc() { println!("Failed to read proc with error {}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match cmdfile.read_to_string(&mut s) { [INFO] [stderr] 29 | | Err(e) => { [INFO] [stderr] 30 | | println!("Failed to read file {}: error: {}", name, e); [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | _ => () [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | if let Err(e) = cmdfile.read_to_string(&mut s) { [INFO] [stderr] 29 | println!("Failed to read file {}: error: {}", name, e); [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or("unstringable".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "unstringable".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match p { [INFO] [stderr] 71 | | Some(p) => println!("{}", p), [INFO] [stderr] 72 | | _ => () [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(p) = p { println!("{}", p) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / match read_proc() { [INFO] [stderr] 83 | | Err(e) => println!("Failed to read proc with error {}", e), [INFO] [stderr] 84 | | _ => () [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = read_proc() { println!("Failed to read proc with error {}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "905c9967df943e11c7bf32a6d1bfd2dbac1d811d364c227119eb53dc3cd27424"` [INFO] running `"docker" "rm" "-f" "905c9967df943e11c7bf32a6d1bfd2dbac1d811d364c227119eb53dc3cd27424"` [INFO] [stdout] 905c9967df943e11c7bf32a6d1bfd2dbac1d811d364c227119eb53dc3cd27424