[INFO] updating cached repository aaparella/rustic_e2c [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaparella/rustic_e2c [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaparella/rustic_e2c" "work/ex/clippy-test-run/sources/stable/gh/aaparella/rustic_e2c"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaparella/rustic_e2c'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaparella/rustic_e2c" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaparella/rustic_e2c"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaparella/rustic_e2c'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef00a918a195e0527183a0284edbce74129625f1 [INFO] sha for GitHub repo aaparella/rustic_e2c: ef00a918a195e0527183a0284edbce74129625f1 [INFO] validating manifest of aaparella/rustic_e2c on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaparella/rustic_e2c on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaparella/rustic_e2c [INFO] finished frobbing aaparella/rustic_e2c [INFO] frobbed toml for aaparella/rustic_e2c written to work/ex/clippy-test-run/sources/stable/gh/aaparella/rustic_e2c/Cargo.toml [INFO] started frobbing aaparella/rustic_e2c [INFO] finished frobbing aaparella/rustic_e2c [INFO] frobbed toml for aaparella/rustic_e2c written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaparella/rustic_e2c/Cargo.toml [INFO] crate aaparella/rustic_e2c has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaparella/rustic_e2c against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaparella/rustic_e2c:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9994c8a3601f296e7769dbaadc784951f792268fcee2aaa4f64b8a88b84a2b3d [INFO] running `"docker" "start" "-a" "9994c8a3601f296e7769dbaadc784951f792268fcee2aaa4f64b8a88b84a2b3d"` [INFO] [stderr] Checking parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/symbol_table.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let _ = write!(f, "{}\n", self.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/symbol_table.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/symbol_table.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/symbol_table.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let _ = write!(f, "{}\n", self.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/symbol_table.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/symbol_table.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser/scanner.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(filename: &String) -> Scanner { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.put_back { [INFO] [stderr] 42 | | true => { [INFO] [stderr] 43 | | self.put_back = false; [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 41 | if self.put_back { [INFO] [stderr] 42 | self.put_back = false; [INFO] [stderr] 43 | } else { [INFO] [stderr] 44 | self.curr_ch = self.next_char(); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match self.curr_ch.unwrap() == next { [INFO] [stderr] 130 | | true => if_two, [INFO] [stderr] 131 | | false => { [INFO] [stderr] 132 | | self.put_back = true; [INFO] [stderr] 133 | | if_one [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 129 | if self.curr_ch.unwrap() == next { if_two } else { [INFO] [stderr] 130 | self.put_back = true; [INFO] [stderr] 131 | if_one [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match self.curr_ch.unwrap() == next { [INFO] [stderr] 142 | | true => typ, [INFO] [stderr] 143 | | false => { [INFO] [stderr] 144 | | panic!("[ERROR] On line {}, expected {} found {}", [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 141 | if self.curr_ch.unwrap() == next { typ } else { [INFO] [stderr] 142 | panic!("[ERROR] On line {}, expected {} found {}", [INFO] [stderr] 143 | self.line, [INFO] [stderr] 144 | next, [INFO] [stderr] 145 | self.curr_ch.unwrap()) [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser/scanner.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / loop { [INFO] [stderr] 160 | | let ch = match self.curr_ch { [INFO] [stderr] 161 | | Some(ch) => ch, [INFO] [stderr] 162 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 168 | | self.curr_ch = self.next_char(); [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(ch) = self.curr_ch { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / match func(ch) { [INFO] [stderr] 165 | | true => id.push(ch), [INFO] [stderr] 166 | | false => break, [INFO] [stderr] 167 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if func(ch) { id.push(ch) } else { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser/scanner.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | id.iter().map(|c| *c).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `id.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parser/scanner.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(filename: &String) -> Scanner { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.put_back { [INFO] [stderr] 42 | | true => { [INFO] [stderr] 43 | | self.put_back = false; [INFO] [stderr] 44 | | } [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 41 | if self.put_back { [INFO] [stderr] 42 | self.put_back = false; [INFO] [stderr] 43 | } else { [INFO] [stderr] 44 | self.curr_ch = self.next_char(); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/symbol_table.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match self.uses.get(key).unwrap() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 31 | | &1 => write!(f, "{} ", key), [INFO] [stderr] 32 | | _ => write!(f, "{}({}) ", key, self.uses.get(key).unwrap()), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match *self.uses.get(key).unwrap() { [INFO] [stderr] 31 | 1 => write!(f, "{} ", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match self.uses.get(key).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.uses[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | _ => write!(f, "{}({}) ", key, self.uses.get(key).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.uses[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/symbol_table.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match self.assignments.get(key).unwrap() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 38 | | &1 => write!(f, "{} ", key), [INFO] [stderr] 39 | | _ => write!(f, "{}({})", key, self.assignments.get(key).unwrap()), [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match *self.assignments.get(key).unwrap() { [INFO] [stderr] 38 | 1 => write!(f, "{} ", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match self.assignments.get(key).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.assignments[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:39:47 [INFO] [stderr] | [INFO] [stderr] 39 | _ => write!(f, "{}({})", key, self.assignments.get(key).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.assignments[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match self.curr_ch.unwrap() == next { [INFO] [stderr] 130 | | true => if_two, [INFO] [stderr] 131 | | false => { [INFO] [stderr] 132 | | self.put_back = true; [INFO] [stderr] 133 | | if_one [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 129 | if self.curr_ch.unwrap() == next { if_two } else { [INFO] [stderr] 130 | self.put_back = true; [INFO] [stderr] 131 | if_one [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match self.curr_ch.unwrap() == next { [INFO] [stderr] 142 | | true => typ, [INFO] [stderr] 143 | | false => { [INFO] [stderr] 144 | | panic!("[ERROR] On line {}, expected {} found {}", [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 141 | if self.curr_ch.unwrap() == next { typ } else { [INFO] [stderr] 142 | panic!("[ERROR] On line {}, expected {} found {}", [INFO] [stderr] 143 | self.line, [INFO] [stderr] 144 | next, [INFO] [stderr] 145 | self.curr_ch.unwrap()) [INFO] [stderr] 146 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser/scanner.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / loop { [INFO] [stderr] 160 | | let ch = match self.curr_ch { [INFO] [stderr] 161 | | Some(ch) => ch, [INFO] [stderr] 162 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 168 | | self.curr_ch = self.next_char(); [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(ch) = self.curr_ch { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/scanner.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / match func(ch) { [INFO] [stderr] 165 | | true => id.push(ch), [INFO] [stderr] 166 | | false => break, [INFO] [stderr] 167 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if func(ch) { id.push(ch) } else { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser/scanner.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | id.iter().map(|c| *c).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `id.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parser/mod.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | fn error(&self, foo: &str) -> ! { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/mod.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match self.sym_tab.declared_in_block(&self.token) { [INFO] [stderr] 72 | | true => println!("[WARNING] Redeclared variable {:?}", self.token), [INFO] [stderr] 73 | | false => { [INFO] [stderr] 74 | | match self.token.typ { [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if self.sym_tab.declared_in_block(&self.token) { println!("[WARNING] Redeclared variable {:?}", self.token) } else { [INFO] [stderr] 72 | match self.token.typ { [INFO] [stderr] 73 | TokenType::ID(ref id) => println!("int x_{}=-12345;", id), [INFO] [stderr] 74 | _ => unreachable!(), [INFO] [stderr] 75 | }; [INFO] [stderr] 76 | self.sym_tab.add_var(&self.token); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/symbol_table.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match self.uses.get(key).unwrap() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 31 | | &1 => write!(f, "{} ", key), [INFO] [stderr] 32 | | _ => write!(f, "{}({}) ", key, self.uses.get(key).unwrap()), [INFO] [stderr] 33 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match *self.uses.get(key).unwrap() { [INFO] [stderr] 31 | 1 => write!(f, "{} ", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let _ = match self.uses.get(key).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.uses[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | _ => write!(f, "{}({}) ", key, self.uses.get(key).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.uses[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/symbol_table.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match self.assignments.get(key).unwrap() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 38 | | &1 => write!(f, "{} ", key), [INFO] [stderr] 39 | | _ => write!(f, "{}({})", key, self.assignments.get(key).unwrap()), [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match *self.assignments.get(key).unwrap() { [INFO] [stderr] 38 | 1 => write!(f, "{} ", key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:37:27 [INFO] [stderr] | [INFO] [stderr] 37 | let _ = match self.assignments.get(key).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.assignments[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/symbol_table.rs:39:47 [INFO] [stderr] | [INFO] [stderr] 39 | _ => write!(f, "{}({})", key, self.assignments.get(key).unwrap()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.assignments[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/mod.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | / match self.token.typ == typ { [INFO] [stderr] 393 | | true => self.scan(), [INFO] [stderr] 394 | | false => self.error("Something"), [INFO] [stderr] 395 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.token.typ == typ { self.scan() } else { self.error("Something") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/parser/mod.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | fn error(&self, foo: &str) -> ! { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/mod.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match self.sym_tab.declared_in_block(&self.token) { [INFO] [stderr] 72 | | true => println!("[WARNING] Redeclared variable {:?}", self.token), [INFO] [stderr] 73 | | false => { [INFO] [stderr] 74 | | match self.token.typ { [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 71 | if self.sym_tab.declared_in_block(&self.token) { println!("[WARNING] Redeclared variable {:?}", self.token) } else { [INFO] [stderr] 72 | match self.token.typ { [INFO] [stderr] 73 | TokenType::ID(ref id) => println!("int x_{}=-12345;", id), [INFO] [stderr] 74 | _ => unreachable!(), [INFO] [stderr] 75 | }; [INFO] [stderr] 76 | self.sym_tab.add_var(&self.token); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/mod.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | / match self.token.typ == typ { [INFO] [stderr] 393 | | true => self.scan(), [INFO] [stderr] 394 | | false => self.error("Something"), [INFO] [stderr] 395 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.token.typ == typ { self.scan() } else { self.error("Something") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "9994c8a3601f296e7769dbaadc784951f792268fcee2aaa4f64b8a88b84a2b3d"` [INFO] running `"docker" "rm" "-f" "9994c8a3601f296e7769dbaadc784951f792268fcee2aaa4f64b8a88b84a2b3d"` [INFO] [stdout] 9994c8a3601f296e7769dbaadc784951f792268fcee2aaa4f64b8a88b84a2b3d