[INFO] updating cached repository aakamenov/monkey-lang [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aakamenov/monkey-lang [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aakamenov/monkey-lang" "work/ex/clippy-test-run/sources/stable/gh/aakamenov/monkey-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aakamenov/monkey-lang'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aakamenov/monkey-lang" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aakamenov/monkey-lang"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aakamenov/monkey-lang'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba24efb0dbc622ef0c90d463022ddc3c755051b4 [INFO] sha for GitHub repo aakamenov/monkey-lang: ba24efb0dbc622ef0c90d463022ddc3c755051b4 [INFO] validating manifest of aakamenov/monkey-lang on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aakamenov/monkey-lang on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aakamenov/monkey-lang [INFO] finished frobbing aakamenov/monkey-lang [INFO] frobbed toml for aakamenov/monkey-lang written to work/ex/clippy-test-run/sources/stable/gh/aakamenov/monkey-lang/Cargo.toml [INFO] started frobbing aakamenov/monkey-lang [INFO] finished frobbing aakamenov/monkey-lang [INFO] frobbed toml for aakamenov/monkey-lang written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aakamenov/monkey-lang/Cargo.toml [INFO] crate aakamenov/monkey-lang has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aakamenov/monkey-lang against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aakamenov/monkey-lang:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76260e59301bb7e9d0e3fb79be16978b95c90aa27a1baf804bdf570cae5db546 [INFO] running `"docker" "start" "-a" "76260e59301bb7e9d0e3fb79be16978b95c90aa27a1baf804bdf570cae5db546"` [INFO] [stderr] Checking monkey-lang v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return Lexer { [INFO] [stderr] 55 | | input: input.chars().peekable() [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Lexer { [INFO] [stderr] 55 | input: input.chars().peekable() [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return match next { [INFO] [stderr] 65 | | Some('=') => { [INFO] [stderr] 66 | | match self.input.peek() { [INFO] [stderr] 67 | | Some(&'=') => { [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => Token { token: TokenType::EOF } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match next { [INFO] [stderr] 65 | Some('=') => { [INFO] [stderr] 66 | match self.input.peek() { [INFO] [stderr] 67 | Some(&'=') => { [INFO] [stderr] 68 | self.input.next(); [INFO] [stderr] 69 | return Token{ token: TokenType::EQ }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return ident; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return ch.is_alphabetic() || ch == &'_'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch.is_alphabetic() || ch == &'_'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return Token { token }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { token }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / return match ident { [INFO] [stderr] 185 | | "let" => Token { token: TokenType::Let }, [INFO] [stderr] 186 | | "fn" => Token { token: TokenType::Function }, [INFO] [stderr] 187 | | "true" => Token { token: TokenType::True }, [INFO] [stderr] ... | [INFO] [stderr] 192 | | _ => Token { token: TokenType::Ident(ident.to_string()) } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 184 | match ident { [INFO] [stderr] 185 | "let" => Token { token: TokenType::Let }, [INFO] [stderr] 186 | "fn" => Token { token: TokenType::Function }, [INFO] [stderr] 187 | "true" => Token { token: TokenType::True }, [INFO] [stderr] 188 | "false" => Token { token: TokenType::False }, [INFO] [stderr] 189 | "if" => Token { token: TokenType::If }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / return Lexer { [INFO] [stderr] 55 | | input: input.chars().peekable() [INFO] [stderr] 56 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Lexer { [INFO] [stderr] 55 | input: input.chars().peekable() [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return match next { [INFO] [stderr] 65 | | Some('=') => { [INFO] [stderr] 66 | | match self.input.peek() { [INFO] [stderr] 67 | | Some(&'=') => { [INFO] [stderr] ... | [INFO] [stderr] 108 | | None => Token { token: TokenType::EOF } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | match next { [INFO] [stderr] 65 | Some('=') => { [INFO] [stderr] 66 | match self.input.peek() { [INFO] [stderr] 67 | Some(&'=') => { [INFO] [stderr] 68 | self.input.next(); [INFO] [stderr] 69 | return Token{ token: TokenType::EQ }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return ident; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return ch.is_alphabetic() || ch == &'_'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch.is_alphabetic() || ch == &'_'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return Token { token }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token { token }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / return match ident { [INFO] [stderr] 185 | | "let" => Token { token: TokenType::Let }, [INFO] [stderr] 186 | | "fn" => Token { token: TokenType::Function }, [INFO] [stderr] 187 | | "true" => Token { token: TokenType::True }, [INFO] [stderr] ... | [INFO] [stderr] 192 | | _ => Token { token: TokenType::Ident(ident.to_string()) } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 184 | match ident { [INFO] [stderr] 185 | "let" => Token { token: TokenType::Let }, [INFO] [stderr] 186 | "fn" => Token { token: TokenType::Function }, [INFO] [stderr] 187 | "true" => Token { token: TokenType::True }, [INFO] [stderr] 188 | "false" => Token { token: TokenType::False }, [INFO] [stderr] 189 | "if" => Token { token: TokenType::If }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | fn read_identifier(&mut self, first: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:134:38 [INFO] [stderr] | [INFO] [stderr] 134 | fn read_number(&mut self, first: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:139:24 [INFO] [stderr] | [INFO] [stderr] 139 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:173:22 [INFO] [stderr] | [INFO] [stderr] 173 | fn is_letter(ch: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | fn read_identifier(&mut self, first: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:134:38 [INFO] [stderr] | [INFO] [stderr] 134 | fn read_number(&mut self, first: &char) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:139:24 [INFO] [stderr] | [INFO] [stderr] 139 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | let next = self.input.peek().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.input.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lexer.rs:173:22 [INFO] [stderr] | [INFO] [stderr] 173 | fn is_letter(ch: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.45s [INFO] running `"docker" "inspect" "76260e59301bb7e9d0e3fb79be16978b95c90aa27a1baf804bdf570cae5db546"` [INFO] running `"docker" "rm" "-f" "76260e59301bb7e9d0e3fb79be16978b95c90aa27a1baf804bdf570cae5db546"` [INFO] [stdout] 76260e59301bb7e9d0e3fb79be16978b95c90aa27a1baf804bdf570cae5db546