[INFO] updating cached repository ZapAnton/large_sort [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ZapAnton/large_sort [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ZapAnton/large_sort" "work/ex/clippy-test-run/sources/stable/gh/ZapAnton/large_sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ZapAnton/large_sort'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ZapAnton/large_sort" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZapAnton/large_sort"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZapAnton/large_sort'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4a3d33253ca3d24b84b24d44711ba66684ab316 [INFO] sha for GitHub repo ZapAnton/large_sort: b4a3d33253ca3d24b84b24d44711ba66684ab316 [INFO] validating manifest of ZapAnton/large_sort on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ZapAnton/large_sort on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ZapAnton/large_sort [INFO] finished frobbing ZapAnton/large_sort [INFO] frobbed toml for ZapAnton/large_sort written to work/ex/clippy-test-run/sources/stable/gh/ZapAnton/large_sort/Cargo.toml [INFO] started frobbing ZapAnton/large_sort [INFO] finished frobbing ZapAnton/large_sort [INFO] frobbed toml for ZapAnton/large_sort written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZapAnton/large_sort/Cargo.toml [INFO] crate ZapAnton/large_sort has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ZapAnton/large_sort against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZapAnton/large_sort:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c31a0a36301f8820a8abdaa6c0b7474bb1067962f3aa4dfe3dc855325be22097 [INFO] running `"docker" "start" "-a" "c31a0a36301f8820a8abdaa6c0b7474bb1067962f3aa4dfe3dc855325be22097"` [INFO] [stderr] Checking large_sort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | temp_file.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | for file_number in 1..(temp_files_count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=temp_files_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | let temp_file = File::open(&temp_file_name).expect(&format!( [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 56 | | "Cannot read unsorted temp file {}!", [INFO] [stderr] 57 | | &temp_file_name [INFO] [stderr] 58 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Cannot read unsorted temp file {}!", &temp_file_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:67:59 [INFO] [stderr] | [INFO] [stderr] 67 | let mut temp_file = File::create(&temp_file_name).expect(&format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 68 | | "Cannot write sorted lines to file {}!", [INFO] [stderr] 69 | | &temp_file_name [INFO] [stderr] 70 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Cannot write sorted lines to file {}!", &temp_file_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | temp_file.write(line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | temp_file.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | fn get_eof_count(first_lines: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | for file_num in 1..(temp_files_count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=temp_files_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("Could not open small_files/file_{}.txt", file_num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open small_files/file_{}.txt", file_num))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | big_file_sorted.write(smallest_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / temp_files [INFO] [stderr] 147 | | .get_mut(smallest_line_index) [INFO] [stderr] 148 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `temp_files[smallest_line_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `large_sort`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | temp_file.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | for file_number in 1..(temp_files_count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=temp_files_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | let temp_file = File::open(&temp_file_name).expect(&format!( [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 56 | | "Cannot read unsorted temp file {}!", [INFO] [stderr] 57 | | &temp_file_name [INFO] [stderr] 58 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Cannot read unsorted temp file {}!", &temp_file_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:67:59 [INFO] [stderr] | [INFO] [stderr] 67 | let mut temp_file = File::create(&temp_file_name).expect(&format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 68 | | "Cannot write sorted lines to file {}!", [INFO] [stderr] 69 | | &temp_file_name [INFO] [stderr] 70 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Cannot write sorted lines to file {}!", &temp_file_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | temp_file.write(line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | temp_file.write("\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | fn get_eof_count(first_lines: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | for file_num in 1..(temp_files_count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=temp_files_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("Could not open small_files/file_{}.txt", file_num)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open small_files/file_{}.txt", file_num))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | big_file_sorted.write(smallest_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / temp_files [INFO] [stderr] 147 | | .get_mut(smallest_line_index) [INFO] [stderr] 148 | | .unwrap() [INFO] [stderr] | |_____________________^ help: try this: `temp_files[smallest_line_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `large_sort`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c31a0a36301f8820a8abdaa6c0b7474bb1067962f3aa4dfe3dc855325be22097"` [INFO] running `"docker" "rm" "-f" "c31a0a36301f8820a8abdaa6c0b7474bb1067962f3aa4dfe3dc855325be22097"` [INFO] [stdout] c31a0a36301f8820a8abdaa6c0b7474bb1067962f3aa4dfe3dc855325be22097