[INFO] updating cached repository YoshikuniJujo/learn_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/YoshikuniJujo/learn_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/YoshikuniJujo/learn_rust" "work/ex/clippy-test-run/sources/stable/gh/YoshikuniJujo/learn_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/YoshikuniJujo/learn_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/YoshikuniJujo/learn_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YoshikuniJujo/learn_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YoshikuniJujo/learn_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7089594ac8104a4dd77f51e5f4f1a1108b8969d5 [INFO] sha for GitHub repo YoshikuniJujo/learn_rust: 7089594ac8104a4dd77f51e5f4f1a1108b8969d5 [INFO] validating manifest of YoshikuniJujo/learn_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of YoshikuniJujo/learn_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing YoshikuniJujo/learn_rust [INFO] finished frobbing YoshikuniJujo/learn_rust [INFO] frobbed toml for YoshikuniJujo/learn_rust written to work/ex/clippy-test-run/sources/stable/gh/YoshikuniJujo/learn_rust/Cargo.toml [INFO] started frobbing YoshikuniJujo/learn_rust [INFO] finished frobbing YoshikuniJujo/learn_rust [INFO] frobbed toml for YoshikuniJujo/learn_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YoshikuniJujo/learn_rust/Cargo.toml [INFO] crate YoshikuniJujo/learn_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting YoshikuniJujo/learn_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YoshikuniJujo/learn_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f238dd093e253ceb5f1ac39a17e31df03d05f1621b69654a5158169fb7b11184 [INFO] running `"docker" "start" "-a" "f238dd093e253ceb5f1ac39a17e31df03d05f1621b69654a5158169fb7b11184"` [INFO] [stderr] Checking learn_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `x` is never read [INFO] [stderr] --> src/mutability.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | let mut x = 5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `y` is assigned to, but never used [INFO] [stderr] --> src/mutability.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | let mut y = &mut x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y` is never read [INFO] [stderr] --> src/mutability.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | y = &mut z; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/mutability.rs:4:2 [INFO] [stderr] | [INFO] [stderr] 4 | x: i32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `foo` [INFO] [stderr] --> src/ownership.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | fn foo(v: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/borrowing.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | return v.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.iter().fold(0, |a, &b| a + b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:3:16 [INFO] [stderr] | [INFO] [stderr] 3 | fn sum_vec(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/borrowing.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | return v.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | fn foo(v1: &Vec, v2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | fn foo(v1: &Vec, v2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/borrowing.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | return v.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.iter().fold(0, |a, &b| a + b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:3:16 [INFO] [stderr] | [INFO] [stderr] 3 | fn sum_vec(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/borrowing.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | return v.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | fn foo(v1: &Vec, v2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/borrowing.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | fn foo(v1: &Vec, v2: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `x` is never read [INFO] [stderr] --> src/mutability.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | let mut x = 5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `y` is assigned to, but never used [INFO] [stderr] --> src/mutability.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | let mut y = &mut x; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y` is never read [INFO] [stderr] --> src/mutability.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | y = &mut z; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/mutability.rs:4:2 [INFO] [stderr] | [INFO] [stderr] 4 | x: i32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `foo` [INFO] [stderr] --> src/ownership.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | fn foo(v: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.00s [INFO] running `"docker" "inspect" "f238dd093e253ceb5f1ac39a17e31df03d05f1621b69654a5158169fb7b11184"` [INFO] running `"docker" "rm" "-f" "f238dd093e253ceb5f1ac39a17e31df03d05f1621b69654a5158169fb7b11184"` [INFO] [stdout] f238dd093e253ceb5f1ac39a17e31df03d05f1621b69654a5158169fb7b11184