[INFO] updating cached repository Woyten/tuning-util [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Woyten/tuning-util [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Woyten/tuning-util" "work/ex/clippy-test-run/sources/stable/gh/Woyten/tuning-util"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Woyten/tuning-util'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Woyten/tuning-util" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/tuning-util"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/tuning-util'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e8938ac02e65c8fb3ccf1083fb43aaddb6d13820 [INFO] sha for GitHub repo Woyten/tuning-util: e8938ac02e65c8fb3ccf1083fb43aaddb6d13820 [INFO] validating manifest of Woyten/tuning-util on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Woyten/tuning-util on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Woyten/tuning-util [INFO] finished frobbing Woyten/tuning-util [INFO] frobbed toml for Woyten/tuning-util written to work/ex/clippy-test-run/sources/stable/gh/Woyten/tuning-util/Cargo.toml [INFO] started frobbing Woyten/tuning-util [INFO] finished frobbing Woyten/tuning-util [INFO] frobbed toml for Woyten/tuning-util written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/tuning-util/Cargo.toml [INFO] crate Woyten/tuning-util has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Woyten/tuning-util against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/tuning-util:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 649b02b848164c7d345e34448ef652013be89092976103e7b0468e6211737b62 [INFO] running `"docker" "start" "-a" "649b02b848164c7d345e34448ef652013be89092976103e7b0468e6211737b62"` [INFO] [stderr] Checking tuning-util v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pitch.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | (1..number_of_notes + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=number_of_notes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pitch.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | format!("exact") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"exact".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pitch.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | (1..number_of_notes + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=number_of_notes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pitch.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | format!("exact") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"exact".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "649b02b848164c7d345e34448ef652013be89092976103e7b0468e6211737b62"` [INFO] running `"docker" "rm" "-f" "649b02b848164c7d345e34448ef652013be89092976103e7b0468e6211737b62"` [INFO] [stdout] 649b02b848164c7d345e34448ef652013be89092976103e7b0468e6211737b62