[INFO] updating cached repository WendySanarwanto/rust-tutorial-control-flow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/WendySanarwanto/rust-tutorial-control-flow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/WendySanarwanto/rust-tutorial-control-flow" "work/ex/clippy-test-run/sources/stable/gh/WendySanarwanto/rust-tutorial-control-flow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WendySanarwanto/rust-tutorial-control-flow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/WendySanarwanto/rust-tutorial-control-flow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WendySanarwanto/rust-tutorial-control-flow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WendySanarwanto/rust-tutorial-control-flow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] adc7c4d7cb18c676f2b9d0c10fbd169616318137 [INFO] sha for GitHub repo WendySanarwanto/rust-tutorial-control-flow: adc7c4d7cb18c676f2b9d0c10fbd169616318137 [INFO] validating manifest of WendySanarwanto/rust-tutorial-control-flow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WendySanarwanto/rust-tutorial-control-flow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WendySanarwanto/rust-tutorial-control-flow [INFO] finished frobbing WendySanarwanto/rust-tutorial-control-flow [INFO] frobbed toml for WendySanarwanto/rust-tutorial-control-flow written to work/ex/clippy-test-run/sources/stable/gh/WendySanarwanto/rust-tutorial-control-flow/Cargo.toml [INFO] started frobbing WendySanarwanto/rust-tutorial-control-flow [INFO] finished frobbing WendySanarwanto/rust-tutorial-control-flow [INFO] frobbed toml for WendySanarwanto/rust-tutorial-control-flow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WendySanarwanto/rust-tutorial-control-flow/Cargo.toml [INFO] crate WendySanarwanto/rust-tutorial-control-flow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WendySanarwanto/rust-tutorial-control-flow against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WendySanarwanto/rust-tutorial-control-flow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 607bfb3ceb8e53561404204a4471c65b214b318c9b90089ebd516ceea42678b1 [INFO] running `"docker" "start" "-a" "607bfb3ceb8e53561404204a4471c65b214b318c9b90089ebd516ceea42678b1"` [INFO] [stderr] Checking control v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | result.2 = if number < 10 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `number < 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | result.3 = if number > 25 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `number > 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | index = index+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | array_nums[i] = array_nums[i] * number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_nums[i] *= number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | result.2 = if number < 10 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `number < 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | result.3 = if number > 25 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `number > 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | index = index+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | array_nums[i] = array_nums[i] * number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_nums[i] *= number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "607bfb3ceb8e53561404204a4471c65b214b318c9b90089ebd516ceea42678b1"` [INFO] running `"docker" "rm" "-f" "607bfb3ceb8e53561404204a4471c65b214b318c9b90089ebd516ceea42678b1"` [INFO] [stdout] 607bfb3ceb8e53561404204a4471c65b214b318c9b90089ebd516ceea42678b1