[INFO] updating cached repository WJackKing/compare [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/WJackKing/compare [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/WJackKing/compare" "work/ex/clippy-test-run/sources/stable/gh/WJackKing/compare"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WJackKing/compare'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/WJackKing/compare" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WJackKing/compare"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WJackKing/compare'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ec3b79e19c9c9745744f33add91d7a1cffc78f1 [INFO] sha for GitHub repo WJackKing/compare: 8ec3b79e19c9c9745744f33add91d7a1cffc78f1 [INFO] validating manifest of WJackKing/compare on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WJackKing/compare on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WJackKing/compare [INFO] finished frobbing WJackKing/compare [INFO] frobbed toml for WJackKing/compare written to work/ex/clippy-test-run/sources/stable/gh/WJackKing/compare/Cargo.toml [INFO] started frobbing WJackKing/compare [INFO] finished frobbing WJackKing/compare [INFO] frobbed toml for WJackKing/compare written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WJackKing/compare/Cargo.toml [INFO] crate WJackKing/compare has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WJackKing/compare against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WJackKing/compare:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 631de42840971f764e884e21a2caef352cbdaac8cdc0f2ab92f7d9452ec6e249 [INFO] running `"docker" "start" "-a" "631de42840971f764e884e21a2caef352cbdaac8cdc0f2ab92f7d9452ec6e249"` [INFO] [stderr] Checking compare v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/dynamic/mod.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | fn max(a: i32, b: i32, c: i32, i: usize, j: usize) -> Score { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/dynamic/mod.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | fn max(a: i32, b: i32, c: i32, i: usize, j: usize) -> Score { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dna/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dna/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dna/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match base { [INFO] [stderr] 39 | | 0...4 => dna.push_num(base).unwrap(), [INFO] [stderr] 40 | | _ => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try this: `if let 0...4 = base { dna.push_num(base).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dna/mod.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(gene) => Ok(self.genes.push(gene)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | Ok(gene) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dna/mod.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(gene) => Ok(self.genes[index] = gene), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 68 | Ok(gene) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: item `dna::Dna` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/dna/mod.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / impl Dna { [INFO] [stderr] 75 | | ///获取index处的碱基 [INFO] [stderr] 76 | | pub fn index(&self, index: usize) -> Base { [INFO] [stderr] 77 | | self.genes[index].clone() [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dna/mod.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic/mod.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn dynamic(v1: &Dna, v2: &Dna, matrix: &Vec>, d: i32) -> Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sum_matrix` [INFO] [stderr] --> src/dynamic/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 1..sum_matrix.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (i, ) in sum_matrix.iter_mut().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic/mod.rs:66:50 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn dynamic_print(v1: &Dna, v2: &Dna, matrix: &Vec>, d: i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dna/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match base { [INFO] [stderr] 39 | | 0...4 => dna.push_num(base).unwrap(), [INFO] [stderr] 40 | | _ => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try this: `if let 0...4 = base { dna.push_num(base).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dna/mod.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(gene) => Ok(self.genes.push(gene)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | Ok(gene) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dna/mod.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(gene) => Ok(self.genes[index] = gene), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 68 | Ok(gene) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: item `dna::Dna` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/dna/mod.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / impl Dna { [INFO] [stderr] 75 | | ///获取index处的碱基 [INFO] [stderr] 76 | | pub fn index(&self, index: usize) -> Base { [INFO] [stderr] 77 | | self.genes[index].clone() [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dna/mod.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic/mod.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn dynamic(v1: &Dna, v2: &Dna, matrix: &Vec>, d: i32) -> Vec>{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sum_matrix` [INFO] [stderr] --> src/dynamic/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 1..sum_matrix.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for (i, ) in sum_matrix.iter_mut().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic/mod.rs:66:50 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn dynamic_print(v1: &Dna, v2: &Dna, matrix: &Vec>, d: i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `"docker" "inspect" "631de42840971f764e884e21a2caef352cbdaac8cdc0f2ab92f7d9452ec6e249"` [INFO] running `"docker" "rm" "-f" "631de42840971f764e884e21a2caef352cbdaac8cdc0f2ab92f7d9452ec6e249"` [INFO] [stdout] 631de42840971f764e884e21a2caef352cbdaac8cdc0f2ab92f7d9452ec6e249