[INFO] updating cached repository Vypo/spling
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Vypo/spling
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Vypo/spling" "work/ex/clippy-test-run/sources/stable/gh/Vypo/spling"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vypo/spling'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Vypo/spling" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vypo/spling"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vypo/spling'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8cec04ff00c40ab509ed372e1ef639d13c19b3b4
[INFO] sha for GitHub repo Vypo/spling: 8cec04ff00c40ab509ed372e1ef639d13c19b3b4
[INFO] validating manifest of Vypo/spling on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Vypo/spling on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Vypo/spling
[INFO] finished frobbing Vypo/spling
[INFO] frobbed toml for Vypo/spling written to work/ex/clippy-test-run/sources/stable/gh/Vypo/spling/Cargo.toml
[INFO] started frobbing Vypo/spling
[INFO] finished frobbing Vypo/spling
[INFO] frobbed toml for Vypo/spling written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vypo/spling/Cargo.toml
[INFO] crate Vypo/spling has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Vypo/spling against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vypo/spling:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 87d47fc23c86f66ff1b8fc9ad7240a8aa737e78b27b3508af87951f5ae16e4a9
[INFO] running `"docker" "start" "-a" "87d47fc23c86f66ff1b8fc9ad7240a8aa737e78b27b3508af87951f5ae16e4a9"`
[INFO] [stderr]     Checking spling v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn reserve<'a>(&'a mut self, len: usize) -> Option<Reservation<'a, T>> {
[INFO] [stderr] 30 | |         if self.head <= self.tail {
[INFO] [stderr] 31 | |             let available = self.data.len() - self.tail;
[INFO] [stderr] 32 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |         None
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     pub fn avail<'a>(&'a mut self) -> Availability<'a, T> {
[INFO] [stderr] 54 | |         let mut head = self.head;
[INFO] [stderr] 55 | |         let tail = self.tail;
[INFO] [stderr] 56 | |         let split = self.split;
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |         }
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `Availability<'a, T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / impl<'a, T: 'a> Availability<'a, T> {
[INFO] [stderr] 90  | |     pub fn len(&self) -> usize {
[INFO] [stderr] 91  | |         self.len
[INFO] [stderr] 92  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |     }
[INFO] [stderr] 103 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `Reservation<'a, T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:123:1
[INFO] [stderr]     |
[INFO] [stderr] 123 | / impl<'a, T> Reservation<'a, T> {
[INFO] [stderr] 124 | |     pub fn commit(self) {
[INFO] [stderr] 125 | |         if self.start == 0 {
[INFO] [stderr] 126 | |             self.spling.split = self.spling.tail;
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |     }
[INFO] [stderr] 135 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> tests/spling.rs:28:8
[INFO] [stderr]    |
[INFO] [stderr] 28 |     if !buf.reserve(100).is_none() {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.reserve(100).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn reserve<'a>(&'a mut self, len: usize) -> Option<Reservation<'a, T>> {
[INFO] [stderr] 30 | |         if self.head <= self.tail {
[INFO] [stderr] 31 | |             let available = self.data.len() - self.tail;
[INFO] [stderr] 32 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |         None
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     pub fn avail<'a>(&'a mut self) -> Availability<'a, T> {
[INFO] [stderr] 54 | |         let mut head = self.head;
[INFO] [stderr] 55 | |         let tail = self.tail;
[INFO] [stderr] 56 | |         let split = self.split;
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |         }
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `Availability<'a, T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:89:1
[INFO] [stderr]     |
[INFO] [stderr] 89  | / impl<'a, T: 'a> Availability<'a, T> {
[INFO] [stderr] 90  | |     pub fn len(&self) -> usize {
[INFO] [stderr] 91  | |         self.len
[INFO] [stderr] 92  | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |     }
[INFO] [stderr] 103 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `Reservation<'a, T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/lib.rs:123:1
[INFO] [stderr]     |
[INFO] [stderr] 123 | / impl<'a, T> Reservation<'a, T> {
[INFO] [stderr] 124 | |     pub fn commit(self) {
[INFO] [stderr] 125 | |         if self.start == 0 {
[INFO] [stderr] 126 | |             self.spling.split = self.spling.tail;
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |     }
[INFO] [stderr] 135 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.48s
[INFO] running `"docker" "inspect" "87d47fc23c86f66ff1b8fc9ad7240a8aa737e78b27b3508af87951f5ae16e4a9"`
[INFO] running `"docker" "rm" "-f" "87d47fc23c86f66ff1b8fc9ad7240a8aa737e78b27b3508af87951f5ae16e4a9"`
[INFO] [stdout] 87d47fc23c86f66ff1b8fc9ad7240a8aa737e78b27b3508af87951f5ae16e4a9