[INFO] updating cached repository VladMoldoveanu/Hangman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/VladMoldoveanu/Hangman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/VladMoldoveanu/Hangman" "work/ex/clippy-test-run/sources/stable/gh/VladMoldoveanu/Hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/VladMoldoveanu/Hangman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/VladMoldoveanu/Hangman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VladMoldoveanu/Hangman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VladMoldoveanu/Hangman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 378d90aa4b0323e11548e817a8a9234ac95351a2 [INFO] sha for GitHub repo VladMoldoveanu/Hangman: 378d90aa4b0323e11548e817a8a9234ac95351a2 [INFO] validating manifest of VladMoldoveanu/Hangman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of VladMoldoveanu/Hangman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing VladMoldoveanu/Hangman [INFO] finished frobbing VladMoldoveanu/Hangman [INFO] frobbed toml for VladMoldoveanu/Hangman written to work/ex/clippy-test-run/sources/stable/gh/VladMoldoveanu/Hangman/Cargo.toml [INFO] started frobbing VladMoldoveanu/Hangman [INFO] finished frobbing VladMoldoveanu/Hangman [INFO] frobbed toml for VladMoldoveanu/Hangman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VladMoldoveanu/Hangman/Cargo.toml [INFO] crate VladMoldoveanu/Hangman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting VladMoldoveanu/Hangman against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VladMoldoveanu/Hangman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1159e67ee466c0704048eff6d5c9caf9fd41aec7e8eb2b3d120181ebfaecd844 [INFO] running `"docker" "start" "-a" "1159e67ee466c0704048eff6d5c9caf9fd41aec7e8eb2b3d120181ebfaecd844"` [INFO] [stderr] Checking hangman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | aux [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let aux = read_line(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | aux [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let aux = read_line(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | let words: Vec = contents.split("\n").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &GameState::Lost(ref word) => println!("You are out of guesses!\nThe answer was {}.", word), [INFO] [stderr] 132 | | &GameState::Won(ref word) => println!("You won!\nThe word is {}.", word), [INFO] [stderr] 133 | | &GameState::Menu => println!("Start game? [y/n] Settings: [s]"), [INFO] [stderr] 134 | | &GameState::Playing(ref data) => data.print(), [INFO] [stderr] 135 | | &GameState::Settings => println!("Choose difficulty: [e/m/h] View stats: [s] Reset progress: [r]"), [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | GameState::Lost(ref word) => println!("You are out of guesses!\nThe answer was {}.", word), [INFO] [stderr] 132 | GameState::Won(ref word) => println!("You won!\nThe word is {}.", word), [INFO] [stderr] 133 | GameState::Menu => println!("Start game? [y/n] Settings: [s]"), [INFO] [stderr] 134 | GameState::Playing(ref data) => data.print(), [INFO] [stderr] 135 | GameState::Settings => println!("Choose difficulty: [e/m/h] View stats: [s] Reset progress: [r]"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:152:52 [INFO] [stderr] | [INFO] [stderr] 152 | let data: Vec = contents.trim().split("\n").map(|x| x.to_string().trim().parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | / match diff { [INFO] [stderr] 180 | | &Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1 + 1), [INFO] [stderr] 181 | | &Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1 + 1), [INFO] [stderr] 182 | | &Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1 + 1), [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *diff { [INFO] [stderr] 180 | Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1 + 1), [INFO] [stderr] 181 | Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1 + 1), [INFO] [stderr] 182 | Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1 + 1), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / match diff { [INFO] [stderr] 188 | | &Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1), [INFO] [stderr] 189 | | &Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1), [INFO] [stderr] 190 | | &Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1), [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *diff { [INFO] [stderr] 188 | Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1), [INFO] [stderr] 189 | Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1), [INFO] [stderr] 190 | Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / match self { [INFO] [stderr] 236 | | &Difficulty::Easy => 15u32, [INFO] [stderr] 237 | | &Difficulty::Medium => 10u32, [INFO] [stderr] 238 | | &Difficulty::Hard => 5u32, [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | match *self { [INFO] [stderr] 236 | Difficulty::Easy => 15u32, [INFO] [stderr] 237 | Difficulty::Medium => 10u32, [INFO] [stderr] 238 | Difficulty::Hard => 5u32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:245:38 [INFO] [stderr] | [INFO] [stderr] 245 | let words = Dictionaire::new(String::from(words)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / match &mut self.state { [INFO] [stderr] 260 | | &mut GameState::Playing(ref mut data) => { [INFO] [stderr] 261 | | let inp = read_line_space(); [INFO] [stderr] 262 | | if inp.len() != 1 { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *(&mut self.state) { [INFO] [stderr] 260 | GameState::Playing(ref mut data) => { [INFO] [stderr] 261 | let inp = read_line_space(); [INFO] [stderr] 262 | if inp.len() != 1 { [INFO] [stderr] 263 | println!("Please type only 1 letter."); [INFO] [stderr] 264 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:278:31 [INFO] [stderr] | [INFO] [stderr] 278 | if inp == String::from("n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | } else if inp == String::from("y") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:282:38 [INFO] [stderr] | [INFO] [stderr] 282 | } else if inp == String::from("s") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"s"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:291:31 [INFO] [stderr] | [INFO] [stderr] 291 | if inp == String::from("e") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"e"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:293:38 [INFO] [stderr] | [INFO] [stderr] 293 | } else if inp == String::from("m") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"m"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | } else if inp == String::from("h") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"h"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | } else if inp == String::from("s") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"s"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | } else if inp == String::from("r") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"r"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:302:36 [INFO] [stderr] | [INFO] [stderr] 302 | if inp2 == String::from("y") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:106:49 [INFO] [stderr] | [INFO] [stderr] 106 | let words: Vec = contents.split("\n").map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &GameState::Lost(ref word) => println!("You are out of guesses!\nThe answer was {}.", word), [INFO] [stderr] 132 | | &GameState::Won(ref word) => println!("You won!\nThe word is {}.", word), [INFO] [stderr] 133 | | &GameState::Menu => println!("Start game? [y/n] Settings: [s]"), [INFO] [stderr] 134 | | &GameState::Playing(ref data) => data.print(), [INFO] [stderr] 135 | | &GameState::Settings => println!("Choose difficulty: [e/m/h] View stats: [s] Reset progress: [r]"), [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | GameState::Lost(ref word) => println!("You are out of guesses!\nThe answer was {}.", word), [INFO] [stderr] 132 | GameState::Won(ref word) => println!("You won!\nThe word is {}.", word), [INFO] [stderr] 133 | GameState::Menu => println!("Start game? [y/n] Settings: [s]"), [INFO] [stderr] 134 | GameState::Playing(ref data) => data.print(), [INFO] [stderr] 135 | GameState::Settings => println!("Choose difficulty: [e/m/h] View stats: [s] Reset progress: [r]"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:152:52 [INFO] [stderr] | [INFO] [stderr] 152 | let data: Vec = contents.trim().split("\n").map(|x| x.to_string().trim().parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | / match diff { [INFO] [stderr] 180 | | &Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1 + 1), [INFO] [stderr] 181 | | &Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1 + 1), [INFO] [stderr] 182 | | &Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1 + 1), [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *diff { [INFO] [stderr] 180 | Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1 + 1), [INFO] [stderr] 181 | Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1 + 1), [INFO] [stderr] 182 | Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1 + 1), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | / match diff { [INFO] [stderr] 188 | | &Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1), [INFO] [stderr] 189 | | &Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1), [INFO] [stderr] 190 | | &Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1), [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *diff { [INFO] [stderr] 188 | Difficulty::Easy => self.easy = (self.easy.0 + 1, self.easy.1), [INFO] [stderr] 189 | Difficulty::Medium => self.medium = (self.medium.0 + 1, self.medium.1), [INFO] [stderr] 190 | Difficulty::Hard => self.hard = (self.hard.0 + 1, self.hard.1), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / match self { [INFO] [stderr] 236 | | &Difficulty::Easy => 15u32, [INFO] [stderr] 237 | | &Difficulty::Medium => 10u32, [INFO] [stderr] 238 | | &Difficulty::Hard => 5u32, [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | match *self { [INFO] [stderr] 236 | Difficulty::Easy => 15u32, [INFO] [stderr] 237 | Difficulty::Medium => 10u32, [INFO] [stderr] 238 | Difficulty::Hard => 5u32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:245:38 [INFO] [stderr] | [INFO] [stderr] 245 | let words = Dictionaire::new(String::from(words)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | / match &mut self.state { [INFO] [stderr] 260 | | &mut GameState::Playing(ref mut data) => { [INFO] [stderr] 261 | | let inp = read_line_space(); [INFO] [stderr] 262 | | if inp.len() != 1 { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *(&mut self.state) { [INFO] [stderr] 260 | GameState::Playing(ref mut data) => { [INFO] [stderr] 261 | let inp = read_line_space(); [INFO] [stderr] 262 | if inp.len() != 1 { [INFO] [stderr] 263 | println!("Please type only 1 letter."); [INFO] [stderr] 264 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:278:31 [INFO] [stderr] | [INFO] [stderr] 278 | if inp == String::from("n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:280:38 [INFO] [stderr] | [INFO] [stderr] 280 | } else if inp == String::from("y") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:282:38 [INFO] [stderr] | [INFO] [stderr] 282 | } else if inp == String::from("s") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"s"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:291:31 [INFO] [stderr] | [INFO] [stderr] 291 | if inp == String::from("e") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"e"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:293:38 [INFO] [stderr] | [INFO] [stderr] 293 | } else if inp == String::from("m") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"m"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:295:38 [INFO] [stderr] | [INFO] [stderr] 295 | } else if inp == String::from("h") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"h"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | } else if inp == String::from("s") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"s"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:299:38 [INFO] [stderr] | [INFO] [stderr] 299 | } else if inp == String::from("r") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"r"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:302:36 [INFO] [stderr] | [INFO] [stderr] 302 | if inp2 == String::from("y") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "1159e67ee466c0704048eff6d5c9caf9fd41aec7e8eb2b3d120181ebfaecd844"` [INFO] running `"docker" "rm" "-f" "1159e67ee466c0704048eff6d5c9caf9fd41aec7e8eb2b3d120181ebfaecd844"` [INFO] [stdout] 1159e67ee466c0704048eff6d5c9caf9fd41aec7e8eb2b3d120181ebfaecd844