[INFO] updating cached repository Virepri/synacor_challenge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Virepri/synacor_challenge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Virepri/synacor_challenge" "work/ex/clippy-test-run/sources/stable/gh/Virepri/synacor_challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Virepri/synacor_challenge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Virepri/synacor_challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Virepri/synacor_challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Virepri/synacor_challenge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4717bd1a8a27849d7b57f56757f53f92123b39cb [INFO] sha for GitHub repo Virepri/synacor_challenge: 4717bd1a8a27849d7b57f56757f53f92123b39cb [INFO] validating manifest of Virepri/synacor_challenge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Virepri/synacor_challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Virepri/synacor_challenge [INFO] finished frobbing Virepri/synacor_challenge [INFO] frobbed toml for Virepri/synacor_challenge written to work/ex/clippy-test-run/sources/stable/gh/Virepri/synacor_challenge/Cargo.toml [INFO] started frobbing Virepri/synacor_challenge [INFO] finished frobbing Virepri/synacor_challenge [INFO] frobbed toml for Virepri/synacor_challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Virepri/synacor_challenge/Cargo.toml [INFO] crate Virepri/synacor_challenge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Virepri/synacor_challenge against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Virepri/synacor_challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f545ee9363eff55d4026b40a890b230a00842b04eebf33a3811a2fdd4b5f71e [INFO] running `"docker" "start" "-a" "5f545ee9363eff55d4026b40a890b230a00842b04eebf33a3811a2fdd4b5f71e"` [INFO] [stderr] Checking synacor_challenge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return self.registers[loc - 32768] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.registers[loc - 32768]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | return loc as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `loc as u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | return self.memory[loc] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.memory[loc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return (*loc >= 32768) && (*loc <= 32775) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*loc >= 32768) && (*loc <= 32775)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return self.registers[loc - 32768] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.registers[loc - 32768]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | return loc as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `loc as u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | return self.memory[loc] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.memory[loc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/mod.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | return (*loc >= 32768) && (*loc <= 32775) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*loc >= 32768) && (*loc <= 32775)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CPU` [INFO] [stderr] --> src/cpu/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct CPU { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_program` [INFO] [stderr] --> src/cpu/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn load_program(&mut self, prog: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start_emulation` [INFO] [stderr] --> src/cpu/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn start_emulation(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_from_mem` [INFO] [stderr] --> src/cpu/mod.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | fn get_from_mem(&self, loc: usize, num: bool) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_location` [INFO] [stderr] --> src/cpu/mod.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | fn set_location(&mut self, loc: usize, data: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_register` [INFO] [stderr] --> src/cpu/mod.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | fn is_register(loc: &usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `make_cpu` [INFO] [stderr] --> src/cpu/mod.rs:112:1 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn make_cpu() -> CPU { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cpu/mod.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn load_program(&mut self, prog: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:16:71 [INFO] [stderr] | [INFO] [stderr] 16 | let combined_program: Vec = to_combine.iter().map(|x| { ((x[0] as u16) << 8) | (x[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:16:93 [INFO] [stderr] | [INFO] [stderr] 16 | let combined_program: Vec = to_combine.iter().map(|x| { ((x[0] as u16) << 8) | (x[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | self.set_location(arg1, ((arg3 as u32 + arg2 as u32) % 32768) as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(arg3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:58:65 [INFO] [stderr] | [INFO] [stderr] 58 | self.set_location(arg1, ((arg3 as u32 + arg2 as u32) % 32768) as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `Result` should have a snake case name such as `result` [INFO] [stderr] --> src/cpu/mod.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | Some(Result) => {self.memory_pointer = Result as usize} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | fn is_register(loc: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cpu/tests/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let mut program = [17,5,2,15,0]; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpu/tests/mod.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(*my_cpu.stack.get(0).unwrap(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&my_cpu.stack[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cpu/tests/mod.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | assert_ne!(*my_cpu.stack.get(0).unwrap(), 15); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&my_cpu.stack[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cpu/mod.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn load_program(&mut self, prog: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:16:71 [INFO] [stderr] | [INFO] [stderr] 16 | let combined_program: Vec = to_combine.iter().map(|x| { ((x[0] as u16) << 8) | (x[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:16:93 [INFO] [stderr] | [INFO] [stderr] 16 | let combined_program: Vec = to_combine.iter().map(|x| { ((x[0] as u16) << 8) | (x[1] as u16) }).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | self.set_location(arg1, ((arg3 as u32 + arg2 as u32) % 32768) as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(arg3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:58:65 [INFO] [stderr] | [INFO] [stderr] 58 | self.set_location(arg1, ((arg3 as u32 + arg2 as u32) % 32768) as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `Result` should have a snake case name such as `result` [INFO] [stderr] --> src/cpu/mod.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | Some(Result) => {self.memory_pointer = Result as usize} [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | fn is_register(loc: &usize) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "5f545ee9363eff55d4026b40a890b230a00842b04eebf33a3811a2fdd4b5f71e"` [INFO] running `"docker" "rm" "-f" "5f545ee9363eff55d4026b40a890b230a00842b04eebf33a3811a2fdd4b5f71e"` [INFO] [stdout] 5f545ee9363eff55d4026b40a890b230a00842b04eebf33a3811a2fdd4b5f71e