[INFO] updating cached repository Viniter/game_of_life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Viniter/game_of_life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Viniter/game_of_life" "work/ex/clippy-test-run/sources/stable/gh/Viniter/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Viniter/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Viniter/game_of_life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Viniter/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Viniter/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a3c854a54f70099affadb427e5c4f0322ad997db [INFO] sha for GitHub repo Viniter/game_of_life: a3c854a54f70099affadb427e5c4f0322ad997db [INFO] validating manifest of Viniter/game_of_life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Viniter/game_of_life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Viniter/game_of_life [INFO] finished frobbing Viniter/game_of_life [INFO] frobbed toml for Viniter/game_of_life written to work/ex/clippy-test-run/sources/stable/gh/Viniter/game_of_life/Cargo.toml [INFO] started frobbing Viniter/game_of_life [INFO] finished frobbing Viniter/game_of_life [INFO] frobbed toml for Viniter/game_of_life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Viniter/game_of_life/Cargo.toml [INFO] crate Viniter/game_of_life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Viniter/game_of_life against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Viniter/game_of_life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c323adbe5f17862b5e17982955c0a218fb640583bc62474a7a35e0ec67cfa6e9 [INFO] running `"docker" "start" "-a" "c323adbe5f17862b5e17982955c0a218fb640583bc62474a7a35e0ec67cfa6e9"` [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/field.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!{""}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/field.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!{""}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_alive` [INFO] [stderr] --> src/cell.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn set_alive(&mut self, val: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/field.rs:12:30 [INFO] [stderr] | [INFO] [stderr] 12 | let initial_coords = initial_coords.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `initial_coords.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/field.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | fn contains_coord(coords: &Vec, coord: &Coord) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Coord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_alive` [INFO] [stderr] --> src/cell.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn set_alive(&mut self, val: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/field.rs:12:30 [INFO] [stderr] | [INFO] [stderr] 12 | let initial_coords = initial_coords.unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `initial_coords.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | y = y + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `y += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/field.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | fn contains_coord(coords: &Vec, coord: &Coord) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Coord]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `"docker" "inspect" "c323adbe5f17862b5e17982955c0a218fb640583bc62474a7a35e0ec67cfa6e9"` [INFO] running `"docker" "rm" "-f" "c323adbe5f17862b5e17982955c0a218fb640583bc62474a7a35e0ec67cfa6e9"` [INFO] [stdout] c323adbe5f17862b5e17982955c0a218fb640583bc62474a7a35e0ec67cfa6e9