[INFO] updating cached repository Vinatorul/Coders-Of-The-Caribbean [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Vinatorul/Coders-Of-The-Caribbean [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Vinatorul/Coders-Of-The-Caribbean" "work/ex/clippy-test-run/sources/stable/gh/Vinatorul/Coders-Of-The-Caribbean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vinatorul/Coders-Of-The-Caribbean'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Vinatorul/Coders-Of-The-Caribbean" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/Coders-Of-The-Caribbean"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/Coders-Of-The-Caribbean'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 85228c614207e3956214ef6d3df4dc6b655551d3 [INFO] sha for GitHub repo Vinatorul/Coders-Of-The-Caribbean: 85228c614207e3956214ef6d3df4dc6b655551d3 [INFO] validating manifest of Vinatorul/Coders-Of-The-Caribbean on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Vinatorul/Coders-Of-The-Caribbean on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Vinatorul/Coders-Of-The-Caribbean [INFO] finished frobbing Vinatorul/Coders-Of-The-Caribbean [INFO] frobbed toml for Vinatorul/Coders-Of-The-Caribbean written to work/ex/clippy-test-run/sources/stable/gh/Vinatorul/Coders-Of-The-Caribbean/Cargo.toml [INFO] started frobbing Vinatorul/Coders-Of-The-Caribbean [INFO] finished frobbing Vinatorul/Coders-Of-The-Caribbean [INFO] frobbed toml for Vinatorul/Coders-Of-The-Caribbean written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/Coders-Of-The-Caribbean/Cargo.toml [INFO] crate Vinatorul/Coders-Of-The-Caribbean has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Vinatorul/Coders-Of-The-Caribbean against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/Coders-Of-The-Caribbean:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23d543850ebc0ca820dc828652a1eab00f2042de208e175aa9502571e60084c7 [INFO] running `"docker" "start" "-a" "23d543850ebc0ca820dc828652a1eab00f2042de208e175aa9502571e60084c7"` [INFO] [stderr] Checking Coders_Of_The_Caribean v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | rotation: rotation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | rum: rum, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | owner_id: owner_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `owner_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | impact_time: impact_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `impact_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | rotation: rotation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `rotation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | rum: rum, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | entity_id: entity_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | owner_id: owner_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `owner_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | impact_time: impact_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `impact_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:511:12 [INFO] [stderr] | [INFO] [stderr] 511 | if (speed > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:511:12 [INFO] [stderr] | [INFO] [stderr] 511 | if (speed > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `speed` [INFO] [stderr] --> src/main.rs:290:60 [INFO] [stderr] | [INFO] [stderr] 290 | fn check_position(&self, point: &Point, rotation: i32, speed: i32, depth: i32) -> i32 { [INFO] [stderr] | ^^^^^ help: consider using `_speed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:724:25 [INFO] [stderr] | [INFO] [stderr] 724 | for i in 0..offset { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MINE` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | MINE, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `quantity` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | quantity: i32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | entity_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | entity_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner_id` [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | owner_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_offset` [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn get_offset(&self, rotation: i32, speed: i32) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mine` [INFO] [stderr] --> src/main.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | fn get_mine(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Coders_Of_The_Caribean` should have a snake case name such as `coders_of_the_caribean` [INFO] [stderr] warning: unused variable: `speed` [INFO] [stderr] --> src/main.rs:290:60 [INFO] [stderr] | [INFO] [stderr] 290 | fn check_position(&self, point: &Point, rotation: i32, speed: i32, depth: i32) -> i32 { [INFO] [stderr] | ^^^^^ help: consider using `_speed` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:724:25 [INFO] [stderr] | [INFO] [stderr] 724 | for i in 0..offset { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | fn distance(&self, point: &Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | fn distance(&self, point: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | fn get_neighbour(&self, rotation: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | fn get_offset(&self, rotation: i32, speed: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | fn angle(&self, target: &Point) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | fn angle(&self, target: &Point) -> f64 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | let dy = ((target.y - self.y) as f64) * f64::sqrt(3f64) / 2f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.y - self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:18 [INFO] [stderr] | [INFO] [stderr] 177 | let dx = (target.x - self.x) as f64 + (((self.y - target.y) & 1) as f64) * 0.5f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.x - self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:47 [INFO] [stderr] | [INFO] [stderr] 177 | let dx = (target.x - self.x) as f64 + (((self.y - target.y) & 1) as f64) * 0.5f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.y - target.y) & 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | angle = angle + 6f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `angle += 6f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | angle = angle - 6f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `angle -= 6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | self.cd = self.cd - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cd -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | self.impact_time = self.impact_time - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.impact_time -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:290:37 [INFO] [stderr] | [INFO] [stderr] 290 | fn check_position(&self, point: &Point, rotation: i32, speed: i32, depth: i32) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:312:54 [INFO] [stderr] | [INFO] [stderr] 312 | if self.under_fire.contains_key(&stern) && (*self.under_fire.get(&stern).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[&stern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:315:53 [INFO] [stderr] | [INFO] [stderr] 315 | if self.under_fire.contains_key(point) && (*self.under_fire.get(point).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | value = value - 50; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:318:53 [INFO] [stderr] | [INFO] [stderr] 318 | if self.under_fire.contains_key(&nose) && (*self.under_fire.get(&nose).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[&nose]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MINE` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | MINE, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `quantity` [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | quantity: i32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | entity_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | entity_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `owner_id` [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | owner_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_offset` [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | fn get_offset(&self, rotation: i32, speed: i32) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_mine` [INFO] [stderr] --> src/main.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | fn get_mine(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Coders_Of_The_Caribean` should have a snake case name such as `coders_of_the_caribean` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | fn distance(&self, point: &Point) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | fn distance(&self, point: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | fn get_neighbour(&self, rotation: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | fn get_offset(&self, rotation: i32, speed: i32) -> Point { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | fn angle(&self, target: &Point) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | fn angle(&self, target: &Point) -> f64 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:176:18 [INFO] [stderr] | [INFO] [stderr] 176 | let dy = ((target.y - self.y) as f64) * f64::sqrt(3f64) / 2f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.y - self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:18 [INFO] [stderr] | [INFO] [stderr] 177 | let dx = (target.x - self.x) as f64 + (((self.y - target.y) & 1) as f64) * 0.5f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.x - self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:47 [INFO] [stderr] | [INFO] [stderr] 177 | let dx = (target.x - self.x) as f64 + (((self.y - target.y) & 1) as f64) * 0.5f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.y - target.y) & 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | angle = angle + 6f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `angle += 6f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | angle = angle - 6f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `angle -= 6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | self.cd = self.cd - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cd -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | self.impact_time = self.impact_time - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.impact_time -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:290:37 [INFO] [stderr] | [INFO] [stderr] 290 | fn check_position(&self, point: &Point, rotation: i32, speed: i32, depth: i32) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | value = value + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:307:13 [INFO] [stderr] | [INFO] [stderr] 307 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:312:54 [INFO] [stderr] | [INFO] [stderr] 312 | if self.under_fire.contains_key(&stern) && (*self.under_fire.get(&stern).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[&stern]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:315:53 [INFO] [stderr] | [INFO] [stderr] 315 | if self.under_fire.contains_key(point) && (*self.under_fire.get(point).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | value = value - 50; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:318:53 [INFO] [stderr] | [INFO] [stderr] 318 | if self.under_fire.contains_key(&nose) && (*self.under_fire.get(&nose).unwrap() == depth-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.under_fire[&nose]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:319:13 [INFO] [stderr] | [INFO] [stderr] 319 | value = value - 25; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | fn check_collision(&self, point: &Point, rotation: i32, ship_id: i32) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] 384 | | let mut t_point = *point; [INFO] [stderr] 385 | | let d = point.distance(&dest); [INFO] [stderr] 386 | | let angle = point.angle(&dest); [INFO] [stderr] ... | [INFO] [stderr] 506 | | (value, false) [INFO] [stderr] 507 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] 384 | | let mut t_point = *point; [INFO] [stderr] 385 | | let d = point.distance(&dest); [INFO] [stderr] 386 | | let angle = point.angle(&dest); [INFO] [stderr] ... | [INFO] [stderr] 506 | | (value, false) [INFO] [stderr] 507 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:383:32 [INFO] [stderr] | [INFO] [stderr] 383 | fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:383:47 [INFO] [stderr] | [INFO] [stderr] 383 | fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:387:40 [INFO] [stderr] | [INFO] [stderr] 387 | let angle_straight = f64::min((rotation as f64 - angle).abs(), 6f64 - (rotation as f64 - angle).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:387:80 [INFO] [stderr] | [INFO] [stderr] 387 | let angle_straight = f64::min((rotation as f64 - angle).abs(), 6f64 - (rotation as f64 - angle).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:423:21 [INFO] [stderr] | [INFO] [stderr] 423 | speed = speed - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `speed -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:436:21 [INFO] [stderr] | [INFO] [stderr] 436 | speed = speed + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `speed += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | value = value + self.check_position(&t_point, rotation, speed, depth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += self.check_position(&t_point, rotation, speed, depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | value = value + self.check_position(&t_point, rotation, speed, depth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += self.check_position(&t_point, rotation, speed, depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:469:45 [INFO] [stderr] | [INFO] [stderr] 469 | let angle_straighte_new = f64::min((rotation as f64 - angle_new).abs(), 6f64 - (rotation as f64 - angle_new).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:469:89 [INFO] [stderr] | [INFO] [stderr] 469 | let angle_straighte_new = f64::min((rotation as f64 - angle_new).abs(), 6f64 - (rotation as f64 - angle_new).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:471:13 [INFO] [stderr] | [INFO] [stderr] 471 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:474:12 [INFO] [stderr] | [INFO] [stderr] 474 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:478:12 [INFO] [stderr] | [INFO] [stderr] 478 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | value = value + m_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += m_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:509:29 [INFO] [stderr] | [INFO] [stderr] 509 | fn move_to(&self, dest: &Point, point: &Point, rotation: i32, speed: i32, ship_id: i32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:509:44 [INFO] [stderr] | [INFO] [stderr] 509 | fn move_to(&self, dest: &Point, point: &Point, rotation: i32, speed: i32, ship_id: i32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:550:43 [INFO] [stderr] | [INFO] [stderr] 550 | let inputs = input_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:612:30 [INFO] [stderr] | [INFO] [stderr] 612 | fn get_mine(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:652:40 [INFO] [stderr] | [INFO] [stderr] 652 | fn get_closest_target(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | / let mut wp_ind = ship.wp_ind; [INFO] [stderr] 672 | | if d < 3 { [INFO] [stderr] 673 | | wp_ind = (ship.wp_ind + 1)%4; [INFO] [stderr] 674 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let wp_ind = if d < 3 { (ship.wp_ind + 1)%4 } else { ship.wp_ind };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:683:28 [INFO] [stderr] | [INFO] [stderr] 683 | let ship = self.my_ships.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.my_ships[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:703:42 [INFO] [stderr] | [INFO] [stderr] 703 | let enemy_ship = self.enemy_ships.get(&enemy_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.enemy_ships[&enemy_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:708:33 [INFO] [stderr] | [INFO] [stderr] 708 | let barel = self.barrels.get(&barrel_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.barrels[&barrel_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:721:38 [INFO] [stderr] | [INFO] [stderr] 721 | let enemy_ship = self.enemy_ships.get(&enemy_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.enemy_ships[&enemy_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:763:43 [INFO] [stderr] | [INFO] [stderr] 763 | let inputs = input_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:783:21 [INFO] [stderr] | [INFO] [stderr] 783 | / if !self.barrels.contains_key(&entity_id) { [INFO] [stderr] 784 | | self.barrels.insert(entity_id, Barrel::new(entity_id, x, y, arg_1)); [INFO] [stderr] 785 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.barrels.entry(entity_id).or_insert(Barrel::new(entity_id, x, y, arg_1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:789:21 [INFO] [stderr] | [INFO] [stderr] 789 | / if !self.mines.contains_key(&entity_id) { [INFO] [stderr] 790 | | self.mines.insert(entity_id, Mine::new(entity_id, x, y)); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.mines.entry(entity_id).or_insert(Mine::new(entity_id, x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:795:21 [INFO] [stderr] | [INFO] [stderr] 795 | / if !self.cannonballs.contains_key(&entity_id) { [INFO] [stderr] 796 | | self.cannonballs.insert(entity_id, Cannoball::new(entity_id, arg_1, arg_2, x, y)); [INFO] [stderr] 797 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.cannonballs.entry(entity_id).or_insert(Cannoball::new(entity_id, arg_1, arg_2, x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | fn check_collision(&self, point: &Point, rotation: i32, ship_id: i32) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] 384 | | let mut t_point = *point; [INFO] [stderr] 385 | | let d = point.distance(&dest); [INFO] [stderr] 386 | | let angle = point.angle(&dest); [INFO] [stderr] ... | [INFO] [stderr] 506 | | (value, false) [INFO] [stderr] 507 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] 384 | | let mut t_point = *point; [INFO] [stderr] 385 | | let d = point.distance(&dest); [INFO] [stderr] 386 | | let angle = point.angle(&dest); [INFO] [stderr] ... | [INFO] [stderr] 506 | | (value, false) [INFO] [stderr] 507 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:383:32 [INFO] [stderr] | [INFO] [stderr] 383 | fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:383:47 [INFO] [stderr] | [INFO] [stderr] 383 | fn move_recur(&self, dest: &Point, point: &Point, mut rotation: i32, mut speed: i32, action: Action, depth: i32, ship_id: i32) -> (i32, bool) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:387:40 [INFO] [stderr] | [INFO] [stderr] 387 | let angle_straight = f64::min((rotation as f64 - angle).abs(), 6f64 - (rotation as f64 - angle).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:387:80 [INFO] [stderr] | [INFO] [stderr] 387 | let angle_straight = f64::min((rotation as f64 - angle).abs(), 6f64 - (rotation as f64 - angle).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:423:21 [INFO] [stderr] | [INFO] [stderr] 423 | speed = speed - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `speed -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:436:21 [INFO] [stderr] | [INFO] [stderr] 436 | speed = speed + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `speed += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | value = value + self.check_position(&t_point, rotation, speed, depth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += self.check_position(&t_point, rotation, speed, depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:465:13 [INFO] [stderr] | [INFO] [stderr] 465 | value = value + self.check_position(&t_point, rotation, speed, depth); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += self.check_position(&t_point, rotation, speed, depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:469:45 [INFO] [stderr] | [INFO] [stderr] 469 | let angle_straighte_new = f64::min((rotation as f64 - angle_new).abs(), 6f64 - (rotation as f64 - angle_new).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:469:89 [INFO] [stderr] | [INFO] [stderr] 469 | let angle_straighte_new = f64::min((rotation as f64 - angle_new).abs(), 6f64 - (rotation as f64 - angle_new).abs()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(rotation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:471:13 [INFO] [stderr] | [INFO] [stderr] 471 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:474:12 [INFO] [stderr] | [INFO] [stderr] 474 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:478:12 [INFO] [stderr] | [INFO] [stderr] 478 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:482:13 [INFO] [stderr] | [INFO] [stderr] 482 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:488:13 [INFO] [stderr] | [INFO] [stderr] 488 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | value = value - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | value = value + m_val; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value += m_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:509:29 [INFO] [stderr] | [INFO] [stderr] 509 | fn move_to(&self, dest: &Point, point: &Point, rotation: i32, speed: i32, ship_id: i32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:509:44 [INFO] [stderr] | [INFO] [stderr] 509 | fn move_to(&self, dest: &Point, point: &Point, rotation: i32, speed: i32, ship_id: i32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | value = value + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:550:43 [INFO] [stderr] | [INFO] [stderr] 550 | let inputs = input_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:612:30 [INFO] [stderr] | [INFO] [stderr] 612 | fn get_mine(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:652:40 [INFO] [stderr] | [INFO] [stderr] 652 | fn get_closest_target(&self, ship: &Point) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:671:9 [INFO] [stderr] | [INFO] [stderr] 671 | / let mut wp_ind = ship.wp_ind; [INFO] [stderr] 672 | | if d < 3 { [INFO] [stderr] 673 | | wp_ind = (ship.wp_ind + 1)%4; [INFO] [stderr] 674 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let wp_ind = if d < 3 { (ship.wp_ind + 1)%4 } else { ship.wp_ind };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:683:28 [INFO] [stderr] | [INFO] [stderr] 683 | let ship = self.my_ships.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.my_ships[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:703:42 [INFO] [stderr] | [INFO] [stderr] 703 | let enemy_ship = self.enemy_ships.get(&enemy_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.enemy_ships[&enemy_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:708:33 [INFO] [stderr] | [INFO] [stderr] 708 | let barel = self.barrels.get(&barrel_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.barrels[&barrel_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:721:38 [INFO] [stderr] | [INFO] [stderr] 721 | let enemy_ship = self.enemy_ships.get(&enemy_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.enemy_ships[&enemy_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:763:43 [INFO] [stderr] | [INFO] [stderr] 763 | let inputs = input_line.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:783:21 [INFO] [stderr] | [INFO] [stderr] 783 | / if !self.barrels.contains_key(&entity_id) { [INFO] [stderr] 784 | | self.barrels.insert(entity_id, Barrel::new(entity_id, x, y, arg_1)); [INFO] [stderr] 785 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.barrels.entry(entity_id).or_insert(Barrel::new(entity_id, x, y, arg_1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:789:21 [INFO] [stderr] | [INFO] [stderr] 789 | / if !self.mines.contains_key(&entity_id) { [INFO] [stderr] 790 | | self.mines.insert(entity_id, Mine::new(entity_id, x, y)); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.mines.entry(entity_id).or_insert(Mine::new(entity_id, x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:795:21 [INFO] [stderr] | [INFO] [stderr] 795 | / if !self.cannonballs.contains_key(&entity_id) { [INFO] [stderr] 796 | | self.cannonballs.insert(entity_id, Cannoball::new(entity_id, arg_1, arg_2, x, y)); [INFO] [stderr] 797 | | } [INFO] [stderr] | |_____________________^ help: consider using: `self.cannonballs.entry(entity_id).or_insert(Cannoball::new(entity_id, arg_1, arg_2, x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "23d543850ebc0ca820dc828652a1eab00f2042de208e175aa9502571e60084c7"` [INFO] running `"docker" "rm" "-f" "23d543850ebc0ca820dc828652a1eab00f2042de208e175aa9502571e60084c7"` [INFO] [stdout] 23d543850ebc0ca820dc828652a1eab00f2042de208e175aa9502571e60084c7