[INFO] updating cached repository TurkeyMcMac/Game-of-Life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TurkeyMcMac/Game-of-Life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TurkeyMcMac/Game-of-Life" "work/ex/clippy-test-run/sources/stable/gh/TurkeyMcMac/Game-of-Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TurkeyMcMac/Game-of-Life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TurkeyMcMac/Game-of-Life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TurkeyMcMac/Game-of-Life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TurkeyMcMac/Game-of-Life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 49a44cf16f355fc0b854d5405a160ae17d6b5dc2 [INFO] sha for GitHub repo TurkeyMcMac/Game-of-Life: 49a44cf16f355fc0b854d5405a160ae17d6b5dc2 [INFO] validating manifest of TurkeyMcMac/Game-of-Life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TurkeyMcMac/Game-of-Life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TurkeyMcMac/Game-of-Life [INFO] finished frobbing TurkeyMcMac/Game-of-Life [INFO] frobbed toml for TurkeyMcMac/Game-of-Life written to work/ex/clippy-test-run/sources/stable/gh/TurkeyMcMac/Game-of-Life/Cargo.toml [INFO] started frobbing TurkeyMcMac/Game-of-Life [INFO] finished frobbing TurkeyMcMac/Game-of-Life [INFO] frobbed toml for TurkeyMcMac/Game-of-Life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TurkeyMcMac/Game-of-Life/Cargo.toml [INFO] crate TurkeyMcMac/Game-of-Life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TurkeyMcMac/Game-of-Life against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TurkeyMcMac/Game-of-Life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06e4bbfa6c21bdee44dbaa3eff0c34bd0f3f2d8efe2e61ae6f40e9a9ab32d6fe [INFO] running `"docker" "start" "-a" "06e4bbfa6c21bdee44dbaa3eff0c34bd0f3f2d8efe2e61ae6f40e9a9ab32d6fe"` [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn realize(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn realize(&self) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = File::open(&env::args().skip(1).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(_) = tx.send(NextStep) { return; } [INFO] [stderr] | -------^^^^^^-------------------------------- help: try this: `if tx.send(NextStep).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | let mut file = File::open(&env::args().skip(1).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | if let Err(_) = tx.send(NextStep) { return; } [INFO] [stderr] | -------^^^^^^-------------------------------- help: try this: `if tx.send(NextStep).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "06e4bbfa6c21bdee44dbaa3eff0c34bd0f3f2d8efe2e61ae6f40e9a9ab32d6fe"` [INFO] running `"docker" "rm" "-f" "06e4bbfa6c21bdee44dbaa3eff0c34bd0f3f2d8efe2e61ae6f40e9a9ab32d6fe"` [INFO] [stdout] 06e4bbfa6c21bdee44dbaa3eff0c34bd0f3f2d8efe2e61ae6f40e9a9ab32d6fe