[INFO] updating cached repository TuringDisciple/AnotherTBCompiler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TuringDisciple/AnotherTBCompiler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TuringDisciple/AnotherTBCompiler" "work/ex/clippy-test-run/sources/stable/gh/TuringDisciple/AnotherTBCompiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TuringDisciple/AnotherTBCompiler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TuringDisciple/AnotherTBCompiler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuringDisciple/AnotherTBCompiler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuringDisciple/AnotherTBCompiler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b82ba38750e5905cfffe437ed21471296201167a [INFO] sha for GitHub repo TuringDisciple/AnotherTBCompiler: b82ba38750e5905cfffe437ed21471296201167a [INFO] validating manifest of TuringDisciple/AnotherTBCompiler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TuringDisciple/AnotherTBCompiler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TuringDisciple/AnotherTBCompiler [INFO] finished frobbing TuringDisciple/AnotherTBCompiler [INFO] frobbed toml for TuringDisciple/AnotherTBCompiler written to work/ex/clippy-test-run/sources/stable/gh/TuringDisciple/AnotherTBCompiler/Cargo.toml [INFO] started frobbing TuringDisciple/AnotherTBCompiler [INFO] finished frobbing TuringDisciple/AnotherTBCompiler [INFO] frobbed toml for TuringDisciple/AnotherTBCompiler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuringDisciple/AnotherTBCompiler/Cargo.toml [INFO] crate TuringDisciple/AnotherTBCompiler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TuringDisciple/AnotherTBCompiler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuringDisciple/AnotherTBCompiler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6dbd68a53b7baeb79d039635e120caa0ce9d396fade250b20f9c727504d326b [INFO] running `"docker" "start" "-a" "a6dbd68a53b7baeb79d039635e120caa0ce9d396fade250b20f9c727504d326b"` [INFO] [stderr] Checking tb-vm-compiler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lexer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | buffered_reader [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lexer.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | let buffered_reader = BufReader::new(f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `line_tag` [INFO] [stderr] --> src/parser.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut line_tag: Token; [INFO] [stderr] | ^^^^^^^^ help: consider using `_line_tag` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut line_tag: Token; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `StringToken` [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | type StringToken = Token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `ExprList` [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | type ExprList = Vec>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lexer.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if skip == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / loop { [INFO] [stderr] 88 | | match chars.next() { [INFO] [stderr] 89 | | Some(value) => { [INFO] [stderr] 90 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / loop { [INFO] [stderr] 105 | | match chars.next() { [INFO] [stderr] 106 | | Some(value) => { [INFO] [stderr] 107 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / loop { [INFO] [stderr] 140 | | match chars.next() { [INFO] [stderr] 141 | | Some(value) => { [INFO] [stderr] 142 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match tok { [INFO] [stderr] 31 | | Token::KEYWORD(w) => { [INFO] [stderr] 32 | | match w { [INFO] [stderr] 33 | | Word::END => lines.push((None, Stmt::EndStmt)), [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => () [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Token::KEYWORD(w) = tok { [INFO] [stderr] 31 | match w { [INFO] [stderr] 32 | Word::END => lines.push((None, Stmt::EndStmt)), [INFO] [stderr] 33 | Word::RUN => lines.push((None, Stmt::RunStmt)), [INFO] [stderr] 34 | Word::LIST => lines.push((None, Stmt::ListStmt)), [INFO] [stderr] 35 | Word::CLEAR => lines.push((None, Stmt::ClearStmt)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lexer.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | buffered_reader [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lexer.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | let buffered_reader = BufReader::new(f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `line_tag` [INFO] [stderr] --> src/parser.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut line_tag: Token; [INFO] [stderr] | ^^^^^^^^ help: consider using `_line_tag` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut line_tag: Token; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `StringToken` [INFO] [stderr] --> src/parser.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | type StringToken = Token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `ExprList` [INFO] [stderr] --> src/parser.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | type ExprList = Vec>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lexer.rs:45:12 [INFO] [stderr] | [INFO] [stderr] 45 | if skip == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / loop { [INFO] [stderr] 88 | | match chars.next() { [INFO] [stderr] 89 | | Some(value) => { [INFO] [stderr] 90 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / loop { [INFO] [stderr] 105 | | match chars.next() { [INFO] [stderr] 106 | | Some(value) => { [INFO] [stderr] 107 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / loop { [INFO] [stderr] 140 | | match chars.next() { [INFO] [stderr] 141 | | Some(value) => { [INFO] [stderr] 142 | | match value { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(value) = chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match tok { [INFO] [stderr] 31 | | Token::KEYWORD(w) => { [INFO] [stderr] 32 | | match w { [INFO] [stderr] 33 | | Word::END => lines.push((None, Stmt::EndStmt)), [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => () [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Token::KEYWORD(w) = tok { [INFO] [stderr] 31 | match w { [INFO] [stderr] 32 | Word::END => lines.push((None, Stmt::EndStmt)), [INFO] [stderr] 33 | Word::RUN => lines.push((None, Stmt::RunStmt)), [INFO] [stderr] 34 | Word::LIST => lines.push((None, Stmt::ListStmt)), [INFO] [stderr] 35 | Word::CLEAR => lines.push((None, Stmt::ClearStmt)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "a6dbd68a53b7baeb79d039635e120caa0ce9d396fade250b20f9c727504d326b"` [INFO] running `"docker" "rm" "-f" "a6dbd68a53b7baeb79d039635e120caa0ce9d396fade250b20f9c727504d326b"` [INFO] [stdout] a6dbd68a53b7baeb79d039635e120caa0ce9d396fade250b20f9c727504d326b