[INFO] updating cached repository ToruNiina/rust-ising [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ToruNiina/rust-ising [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ToruNiina/rust-ising" "work/ex/clippy-test-run/sources/stable/gh/ToruNiina/rust-ising"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ToruNiina/rust-ising'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ToruNiina/rust-ising" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToruNiina/rust-ising"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToruNiina/rust-ising'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 020ead5384428acb2fd45a2bc0fea7ec6baa59f8 [INFO] sha for GitHub repo ToruNiina/rust-ising: 020ead5384428acb2fd45a2bc0fea7ec6baa59f8 [INFO] validating manifest of ToruNiina/rust-ising on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ToruNiina/rust-ising on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ToruNiina/rust-ising [INFO] finished frobbing ToruNiina/rust-ising [INFO] frobbed toml for ToruNiina/rust-ising written to work/ex/clippy-test-run/sources/stable/gh/ToruNiina/rust-ising/Cargo.toml [INFO] started frobbing ToruNiina/rust-ising [INFO] finished frobbing ToruNiina/rust-ising [INFO] frobbed toml for ToruNiina/rust-ising written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToruNiina/rust-ising/Cargo.toml [INFO] crate ToruNiina/rust-ising has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ToruNiina/rust-ising against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToruNiina/rust-ising:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbea3b931e48b1377b5fd506c1c464aa81c7b23a03849a598cc8be997f24fa56 [INFO] running `"docker" "start" "-a" "cbea3b931e48b1377b5fd506c1c464aa81c7b23a03849a598cc8be997f24fa56"` [INFO] [stderr] Checking ising v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:43 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `beta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:28 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:43 [INFO] [stderr] | [INFO] [stderr] 75 | Field{width:width, height:height, beta:beta, nodes: ns} [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `beta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:147:63 [INFO] [stderr] | [INFO] [stderr] 147 | fn step(field: &mut Field, hamiltonian: &Hamiltonian, rng: &mut R) { [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:147:63 [INFO] [stderr] | [INFO] [stderr] 147 | fn step(field: &mut Field, hamiltonian: &Hamiltonian, rng: &mut R) { [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &Spin::Up => {write!(f, "Spin::Up")} [INFO] [stderr] 15 | | &Spin::Down => {write!(f, "Spin::Down")} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / match self { [INFO] [stderr] 14 | | &Spin::Up => {write!(f, "Spin::Up")} [INFO] [stderr] 15 | | &Spin::Down => {write!(f, "Spin::Down")} [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | Spin::Up => {write!(f, "Spin::Up")} [INFO] [stderr] 15 | Spin::Down => {write!(f, "Spin::Down")} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &Spin::Up => {write!(f, "+")} [INFO] [stderr] 24 | | &Spin::Down => {write!(f, " ")} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *self { [INFO] [stderr] 14 | Spin::Up => {write!(f, "Spin::Up")} [INFO] [stderr] 15 | Spin::Down => {write!(f, "Spin::Down")} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &Spin::Up => {write!(f, "+")} [INFO] [stderr] 24 | | &Spin::Down => {write!(f, " ")} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | Spin::Up => {write!(f, "+")} [INFO] [stderr] 24 | Spin::Down => {write!(f, " ")} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | Spin::Up => {write!(f, "+")} [INFO] [stderr] 24 | Spin::Down => {write!(f, " ")} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "cbea3b931e48b1377b5fd506c1c464aa81c7b23a03849a598cc8be997f24fa56"` [INFO] running `"docker" "rm" "-f" "cbea3b931e48b1377b5fd506c1c464aa81c7b23a03849a598cc8be997f24fa56"` [INFO] [stdout] cbea3b931e48b1377b5fd506c1c464aa81c7b23a03849a598cc8be997f24fa56