[INFO] updating cached repository TheKK/rustnes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheKK/rustnes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheKK/rustnes" "work/ex/clippy-test-run/sources/stable/gh/TheKK/rustnes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheKK/rustnes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheKK/rustnes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheKK/rustnes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheKK/rustnes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc9ae424b51b4f3c9f40ed1e29f55d4f1f729080 [INFO] sha for GitHub repo TheKK/rustnes: dc9ae424b51b4f3c9f40ed1e29f55d4f1f729080 [INFO] validating manifest of TheKK/rustnes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheKK/rustnes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheKK/rustnes [INFO] finished frobbing TheKK/rustnes [INFO] frobbed toml for TheKK/rustnes written to work/ex/clippy-test-run/sources/stable/gh/TheKK/rustnes/Cargo.toml [INFO] started frobbing TheKK/rustnes [INFO] finished frobbing TheKK/rustnes [INFO] frobbed toml for TheKK/rustnes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheKK/rustnes/Cargo.toml [INFO] crate TheKK/rustnes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheKK/rustnes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheKK/rustnes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8ad2ad4f78793db1a428576b797e2cbaaa60c964780831bdb895295b80c19ca [INFO] running `"docker" "start" "-a" "f8ad2ad4f78793db1a428576b797e2cbaaa60c964780831bdb895295b80c19ca"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking rustnes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | P(0b00100000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/utils.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | let negtive = (val & 0b10000000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:293:20 [INFO] [stderr] | [INFO] [stderr] 293 | let addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | indexed_addr [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:308:28 [INFO] [stderr] | [INFO] [stderr] 308 | let indexed_addr = (base_addr + x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | indexed_addr [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:323:28 [INFO] [stderr] | [INFO] [stderr] 323 | let indexed_addr = (base_addr + y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | let addr = compose_addr(addr_high, addr_low); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:402:9 [INFO] [stderr] | [INFO] [stderr] 402 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:400:20 [INFO] [stderr] | [INFO] [stderr] 400 | let addr = compose_addr(addr_high, addr_low); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | registers.set_carry_flag((val & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | 0b01000000 & val > 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `opcode::OpCode` [INFO] [stderr] --> src/opcode/lda.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use opcode::OpCode; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::OpCode` [INFO] [stderr] --> src/opcode/ldx.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::OpCode; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::OpCode` [INFO] [stderr] --> src/opcode/ldy.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::OpCode; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::OpCode` [INFO] [stderr] --> src/opcode/nop.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::OpCode; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | let mirroring = match data & 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:117:58 [INFO] [stderr] | [INFO] [stderr] 117 | contains_battery_backed_prg_ram: (data & 0b00000010) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | has_trainer: (data & 0b00000100) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:119:50 [INFO] [stderr] | [INFO] [stderr] 119 | igore_mirroring_control: (data & 0b00001000) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:132:39 [INFO] [stderr] | [INFO] [stderr] 132 | vs_unisystem: (data & 0b00000001) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:133:45 [INFO] [stderr] | [INFO] [stderr] 133 | has_play_choice_10: (data & 0b00000010) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | is_nes_2_0: (data & 0b00001100) == 0b1000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | let tv_system = match data & 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MEM_ADDR_MAX` [INFO] [stderr] --> src/cpu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const MEM_ADDR_MAX: usize = 0xffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new() -> P { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn new() -> Registers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `p` [INFO] [stderr] --> src/cpu.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn p(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_carry_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | bit_flag_getter_setter!(set_carry_flag, carry_flag, 0); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `carry_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | bit_flag_getter_setter!(set_carry_flag, carry_flag, 0); [INFO] [stderr] | ------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_zero_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | bit_flag_getter_setter!(set_zero_flag, zero_flag, 1); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `zero_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | bit_flag_getter_setter!(set_zero_flag, zero_flag, 1); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_interrupt_disable_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 82 | bit_flag_getter_setter!(set_interrupt_disable_flag, interrupt_disable_flag, 2); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `interrupt_disable_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 82 | bit_flag_getter_setter!(set_interrupt_disable_flag, interrupt_disable_flag, 2); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_decimal_mode_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 83 | bit_flag_getter_setter!(set_decimal_mode_flag, decimal_mode_flag, 3); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decimal_mode_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 83 | bit_flag_getter_setter!(set_decimal_mode_flag, decimal_mode_flag, 3); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_break_command_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 84 | bit_flag_getter_setter!(set_break_command_flag, break_command_flag, 4); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `break_command_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 84 | bit_flag_getter_setter!(set_break_command_flag, break_command_flag, 4); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_overflow_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 85 | bit_flag_getter_setter!(set_overflow_flag, overflow_flag, 6); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `overflow_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 85 | bit_flag_getter_setter!(set_overflow_flag, overflow_flag, 6); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_sign_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | bit_flag_getter_setter!(set_sign_flag, sign_flag, 7); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sign_flag` [INFO] [stderr] --> src/cpu.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn $getter_name(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 86 | bit_flag_getter_setter!(set_sign_flag, sign_flag, 7); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn new() -> Memory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read` [INFO] [stderr] --> src/cpu.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn read(&self, addr: u16) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/cpu.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn write(&mut self, addr: u16, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RP2A03` [INFO] [stderr] --> src/cpu.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | pub struct RP2A03 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn new() -> RP2A03 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute` [INFO] [stderr] --> src/cpu.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn execute(&mut self) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `new_page` [INFO] [stderr] --> src/opcode/utils.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | fn new_page(old_pc: u16, new_pc: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rel_addr` [INFO] [stderr] --> src/opcode/utils.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn rel_addr(pc: u16, val: u8) -> (u16, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_sign` [INFO] [stderr] --> src/opcode/utils.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn is_sign(val: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `compose_addr` [INFO] [stderr] --> src/opcode/utils.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | fn compose_addr(addr_high: u8, addr_low: u8) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `compose_indexed_addr` [INFO] [stderr] --> src/opcode/utils.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | fn compose_indexed_addr(addr_high: u8, addr_low: u8, index: u8) -> (u16, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_imm_addr` [INFO] [stderr] --> src/opcode/utils.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | pub fn get_imm_addr(_mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_imm` [INFO] [stderr] --> src/opcode/utils.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn read_imm(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_zero_page_addr` [INFO] [stderr] --> src/opcode/utils.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | pub fn get_zero_page_addr(mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | pub fn read_zero_page(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_zero_page_x_addr` [INFO] [stderr] --> src/opcode/utils.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | pub fn get_zero_page_x_addr(mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | pub fn read_zero_page_x(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_zero_page_y_addr` [INFO] [stderr] --> src/opcode/utils.rs:319:5 [INFO] [stderr] | [INFO] [stderr] 319 | pub fn get_zero_page_y_addr(mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_zero_page_y` [INFO] [stderr] --> src/opcode/utils.rs:329:5 [INFO] [stderr] | [INFO] [stderr] 329 | pub fn read_zero_page_y(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_rel` [INFO] [stderr] --> src/opcode/utils.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | pub fn read_rel(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_abs_addr` [INFO] [stderr] --> src/opcode/utils.rs:341:5 [INFO] [stderr] | [INFO] [stderr] 341 | pub fn get_abs_addr(mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_abs` [INFO] [stderr] --> src/opcode/utils.rs:351:5 [INFO] [stderr] | [INFO] [stderr] 351 | pub fn read_abs(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_abs_x_addr` [INFO] [stderr] --> src/opcode/utils.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | pub fn get_abs_x_addr(mem: &Memory, registers: &Registers) -> (u16, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | pub fn read_abs_x(mem: &Memory, registers: &Registers) -> (u8, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_abs_y_addr` [INFO] [stderr] --> src/opcode/utils.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | pub fn get_abs_y_addr(mem: &Memory, registers: &Registers) -> (u16, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_abs_y` [INFO] [stderr] --> src/opcode/utils.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | pub fn read_abs_y(mem: &Memory, registers: &Registers) -> (u8, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_indirect_x_addr` [INFO] [stderr] --> src/opcode/utils.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | pub fn get_indirect_x_addr(mem: &Memory, registers: &Registers) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_indirect_x` [INFO] [stderr] --> src/opcode/utils.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn read_indirect_x(mem: &Memory, registers: &Registers) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_indirect_y_addr` [INFO] [stderr] --> src/opcode/utils.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | pub fn get_indirect_y_addr(mem: &Memory, registers: &Registers) -> (u16, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_indirect_y` [INFO] [stderr] --> src/opcode/utils.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn read_indirect_y(mem: &Memory, registers: &Registers) -> (u8, bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc` [INFO] [stderr] --> src/opcode/adc.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn adc(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_imm` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | opcode_fn_with_mode!(imm -> (adc_imm, adc, Cycle(2))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | opcode_fn_with_mode!(zero_page -> (adc_zero_page, adc, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | opcode_fn_with_mode!(zero_page_x -> (adc_zero_page_x, adc, Cycle(4))); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | opcode_fn_with_mode!(abs -> (adc_abs, adc, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(abs_x -> (adc_abs_x, adc, [INFO] [stderr] 25 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_abs_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(abs_y -> (adc_abs_y, adc, [INFO] [stderr] 27 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_indirect_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | opcode_fn_with_mode!(indirect_x -> (adc_indirect_x, adc, Cycle(6))); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `adc_indirect_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / opcode_fn_with_mode!(indirect_y -> (adc_indirect_y, adc, [INFO] [stderr] 30 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and` [INFO] [stderr] --> src/opcode/and.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn and(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_imm` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | opcode_fn_with_mode!(imm -> (and_imm, and, Cycle(2))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | opcode_fn_with_mode!(zero_page -> (and_zero_page, and, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | opcode_fn_with_mode!(zero_page_x -> (and_zero_page_x, and, Cycle(4))); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | opcode_fn_with_mode!(abs -> (and_abs, and, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_x -> (and_abs_x, and, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_abs_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / opcode_fn_with_mode!(abs_y -> (and_abs_y, and, [INFO] [stderr] 24 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_indirect_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | opcode_fn_with_mode!(indirect_x -> (and_indirect_x, and, Cycle(6))); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `and_indirect_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(indirect_y -> (and_indirect_y, and, [INFO] [stderr] 27 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl` [INFO] [stderr] --> src/opcode/asl.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn asl(registers: &mut Registers, val: u8) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl_register_a` [INFO] [stderr] --> src/opcode/asl.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn asl_register_a(registers: &mut Registers, _mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | opcode_fn_with_mode!(zero_page_memory -> (asl_zero_page, asl, Cycle(5))); [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | opcode_fn_with_mode!(zero_page_x_memory -> (asl_zero_page_x, asl, Cycle(6))); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl_abs` [INFO] [stderr] --> src/opcode/utils.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | opcode_fn_with_mode!(abs_memory -> (asl_abs, asl, Cycle(6))); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `asl_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | opcode_fn_with_mode!(abs_x_memory -> (asl_abs_x, asl, Cycle(7))); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bcc` [INFO] [stderr] --> src/opcode/bcc.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bcc(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bcc_relative` [INFO] [stderr] --> src/opcode/bcc.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bcc_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bcs` [INFO] [stderr] --> src/opcode/bcs.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bcs(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bcs_relative` [INFO] [stderr] --> src/opcode/bcs.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bcs_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `beq` [INFO] [stderr] --> src/opcode/beq.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn beq(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `beq_relative` [INFO] [stderr] --> src/opcode/beq.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn beq_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bit` [INFO] [stderr] --> src/opcode/bit.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn bit(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bit_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/bit.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | opcode_fn_with_mode!(zero_page -> (bit_zero_page, bit, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bit_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/bit.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | opcode_fn_with_mode!(abs -> (bit_abs, bit, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bmi` [INFO] [stderr] --> src/opcode/bmi.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bmi(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bmi_relative` [INFO] [stderr] --> src/opcode/bmi.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bmi_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bne` [INFO] [stderr] --> src/opcode/bne.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bne(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bne_relative` [INFO] [stderr] --> src/opcode/bne.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bne_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bpl` [INFO] [stderr] --> src/opcode/bpl.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bpl(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bpl_relative` [INFO] [stderr] --> src/opcode/bpl.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bpl_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bvc` [INFO] [stderr] --> src/opcode/bvc.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bvc(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bvc_relative` [INFO] [stderr] --> src/opcode/bvc.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bvc_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bvs` [INFO] [stderr] --> src/opcode/bvs.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | fn bvs(registers: &mut Registers, offset: u8) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `bvs_relative` [INFO] [stderr] --> src/opcode/bvs.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn bvs_relative(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clc` [INFO] [stderr] --> src/opcode/clc.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn clc(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clc_implied` [INFO] [stderr] --> src/opcode/clc.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn clc_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cld` [INFO] [stderr] --> src/opcode/cld.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn cld(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cld_implied` [INFO] [stderr] --> src/opcode/cld.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn cld_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cli` [INFO] [stderr] --> src/opcode/cli.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn cli(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `cli_implied` [INFO] [stderr] --> src/opcode/cli.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn cli_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clv` [INFO] [stderr] --> src/opcode/clv.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn clv(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clv_implied` [INFO] [stderr] --> src/opcode/clv.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn clv_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda` [INFO] [stderr] --> src/opcode/lda.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn lda(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_imm` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | opcode_fn_with_mode!(imm -> (lda_imm, lda, Cycle(2))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | opcode_fn_with_mode!(zero_page -> (lda_zero_page, lda, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | opcode_fn_with_mode!(zero_page_x -> (lda_zero_page_x, lda, Cycle(4))); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | opcode_fn_with_mode!(abs -> (lda_abs, lda, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (lda_abs_x, lda, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_abs_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_y -> (lda_abs_y, lda, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_indirect_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | opcode_fn_with_mode!(indirect_x -> (lda_indirect_x, lda, Cycle(6))); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lda_indirect_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(indirect_y -> (lda_indirect_y, lda, [INFO] [stderr] 25 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx` [INFO] [stderr] --> src/opcode/ldx.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn ldx(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx_imm` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | opcode_fn_with_mode!(imm -> (ldx_imm, ldx, Cycle(2))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | opcode_fn_with_mode!(zero_page -> (ldx_zero_page, ldx, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx_zero_page_y` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | opcode_fn_with_mode!(zero_page_y -> (ldx_zero_page_y, ldx, Cycle(4))); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | opcode_fn_with_mode!(abs -> (ldx_abs, ldx, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldx_abs_y` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_y -> (ldx_abs_y, ldx, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy` [INFO] [stderr] --> src/opcode/ldy.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn ldy(registers: &mut Registers, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy_imm` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | opcode_fn_with_mode!(imm -> (ldy_imm, ldy, Cycle(2))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy_zero_page` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | opcode_fn_with_mode!(zero_page -> (ldy_zero_page, ldy, Cycle(3))); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy_zero_page_x` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | opcode_fn_with_mode!(zero_page_x -> (ldy_zero_page_x, ldy, Cycle(4))); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy_abs` [INFO] [stderr] --> src/opcode/utils.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | opcode_fn_with_mode!(abs -> (ldy_abs, ldy, Cycle(4))); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ldy_abs_x` [INFO] [stderr] --> src/opcode/utils.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn $fn_name(registers: &mut Registers, mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (ldy_abs_x, ldy, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: function is never used: `nop` [INFO] [stderr] --> src/opcode/nop.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn nop(_registers: &mut Registers, _mem: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sec` [INFO] [stderr] --> src/opcode/sec.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn sec(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sec_implied` [INFO] [stderr] --> src/opcode/sec.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn sec_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sed` [INFO] [stderr] --> src/opcode/sed.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn sed(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sed_implied` [INFO] [stderr] --> src/opcode/sed.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn sed_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sei` [INFO] [stderr] --> src/opcode/sei.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn sei(registers: &mut Registers) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sei_implied` [INFO] [stderr] --> src/opcode/sei.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn sei_implied(registers: &mut Registers, _: &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Cycle` [INFO] [stderr] --> src/opcode/mod.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | pub struct Cycle(pub u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `operands_num` [INFO] [stderr] --> src/opcode/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn operands_num(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fn` [INFO] [stderr] --> src/opcode/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn get_fn(&self) -> fn(&mut Registers, &mut Memory) -> Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `INes` [INFO] [stderr] --> src/rom.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct INes<'n> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Header` [INFO] [stderr] --> src/rom.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub struct Header { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Horizontal` [INFO] [stderr] --> src/rom.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | Horizontal, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Vertical` [INFO] [stderr] --> src/rom.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | Vertical, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NTSC` [INFO] [stderr] --> src/rom.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | NTSC, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PAL` [INFO] [stderr] --> src/rom.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | PAL, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | .field("carry", &(self.0 & (1 << 0) > 0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:131:30 [INFO] [stderr] | [INFO] [stderr] 131 | self.registers.pc += (1 + opcode.operands_num()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(1 + opcode.operands_num())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let unsigned_val = ((val << 1) >> 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((val << 1) >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let new_pc = match negtive { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | true => pc - unsigned_val, [INFO] [stderr] 15 | | false => pc + unsigned_val, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if negtive { pc - unsigned_val } else { pc + unsigned_val }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:261:10 [INFO] [stderr] | [INFO] [stderr] 261 | ((addr_high as u16) << 8) + addr_low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:261:37 [INFO] [stderr] | [INFO] [stderr] 261 | ((addr_high as u16) << 8) + addr_low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(addr_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:293:20 [INFO] [stderr] | [INFO] [stderr] 293 | let addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.read((pc + 1) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:308:28 [INFO] [stderr] | [INFO] [stderr] 308 | let indexed_addr = (base_addr + x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(base_addr + x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:323:28 [INFO] [stderr] | [INFO] [stderr] 323 | let indexed_addr = (base_addr + y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(base_addr + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | let indirect_addr = indirect_addr as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(indirect_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:414:29 [INFO] [stderr] | [INFO] [stderr] 414 | let indirect_addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.read((pc + 1) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/adc.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | let temp = val as u16 + a as u16 + carry; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/adc.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | let temp = val as u16 + a as u16 + carry; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `temp.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, temp)); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | (($operand_a as u16 ^ $result) & 0x80) > 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | set_flag!(overflow -> (registers, a, val, temp)); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(abs_x -> (adc_abs_x, adc, [INFO] [stderr] 25 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(abs_y -> (adc_abs_y, adc, [INFO] [stderr] 27 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / opcode_fn_with_mode!(indirect_y -> (adc_indirect_y, adc, [INFO] [stderr] 30 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `result.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, result)); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_x -> (and_abs_x, and, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / opcode_fn_with_mode!(abs_y -> (and_abs_y, and, [INFO] [stderr] 24 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(indirect_y -> (and_indirect_y, and, [INFO] [stderr] 27 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `new_val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, new_val)); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bcc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.carry_flag() { [INFO] [stderr] 13 | | false => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | true => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.carry_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bcs.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.carry_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.carry_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/beq.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.zero_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.zero_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bmi.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.sign_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.sign_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bne.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.zero_flag() { [INFO] [stderr] 13 | | true => Cycle(2), [INFO] [stderr] 14 | | false => { [INFO] [stderr] 15 | | registers.pc = new_pc; [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.zero_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bpl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.sign_flag() { [INFO] [stderr] 13 | | true => Cycle(2), [INFO] [stderr] 14 | | false => { [INFO] [stderr] 15 | | registers.pc = new_pc; [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.sign_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bvc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.overflow_flag() { [INFO] [stderr] 13 | | false => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | true => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.overflow_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bvs.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.overflow_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.overflow_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (lda_abs_x, lda, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_y -> (lda_abs_y, lda, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(indirect_y -> (lda_indirect_y, lda, [INFO] [stderr] 25 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_y -> (ldx_abs_y, ldx, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (ldy_abs_x, ldy, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcode/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / match self { [INFO] [stderr] 77 | | $( [INFO] [stderr] 78 | | &OpCode::$opcode => $operands_size, [INFO] [stderr] 79 | | )* [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcode/mod.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | $( [INFO] [stderr] 86 | | &OpCode::$opcode => $opcode_fn, [INFO] [stderr] 87 | | )* [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | prg_rom_data: take!(16384 * header.prg_rom_size as u32) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.prg_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:65:69 [INFO] [stderr] | [INFO] [stderr] 65 | chr_rom_data: cond!(header.chr_rom_size != 0, take!(8192 * header.chr_rom_size as u32)) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.chr_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | P(0b00100000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/utils.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | let negtive = (val & 0b10000000) > 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:293:20 [INFO] [stderr] | [INFO] [stderr] 293 | let addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | indexed_addr [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:308:28 [INFO] [stderr] | [INFO] [stderr] 308 | let indexed_addr = (base_addr + x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | indexed_addr [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:323:28 [INFO] [stderr] | [INFO] [stderr] 323 | let indexed_addr = (base_addr + y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | let addr = compose_addr(addr_high, addr_low); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcode/utils.rs:402:9 [INFO] [stderr] | [INFO] [stderr] 402 | addr [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcode/utils.rs:400:20 [INFO] [stderr] | [INFO] [stderr] 400 | let addr = compose_addr(addr_high, addr_low); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/adc.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | registers.a = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/adc.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | adc(&mut registers, 0b11111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/adc.rs:100:23 [INFO] [stderr] | [INFO] [stderr] 100 | registers.a = 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/adc.rs:112:29 [INFO] [stderr] | [INFO] [stderr] 112 | adc(&mut registers, 0b10000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | let a = 0b00000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let val = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let a = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | let val = 0b00000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | let a = 0b10000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/and.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let val = 0b10000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | registers.set_carry_flag((val & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | let input_value = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | let expected_value = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | let input_value = 0b10000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | let expected_value = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:82:30 [INFO] [stderr] | [INFO] [stderr] 82 | let expected_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | let input_value = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/asl.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | let expected_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcc.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcc.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcc.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcc.rs:144:27 [INFO] [stderr] | [INFO] [stderr] 144 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcs.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcs.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcs.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bcs.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/beq.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/beq.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/beq.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/beq.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | 0b01000000 & val > 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let a = 0b00000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let val = 0b00000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | let a = 0b00000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | let val = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | let a = 0b00000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:78:19 [INFO] [stderr] | [INFO] [stderr] 78 | let val = 0b01000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | let a = 0b10000101; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bit.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | let val = 0b10000111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bmi.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bmi.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bmi.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bmi.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bne.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bne.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bne.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bne.rs:168:27 [INFO] [stderr] | [INFO] [stderr] 168 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bpl.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bpl.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bpl.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bpl.rs:168:27 [INFO] [stderr] | [INFO] [stderr] 168 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvc.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvc.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvc.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvc.rs:144:27 [INFO] [stderr] | [INFO] [stderr] 144 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvs.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let input_value = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvs.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | let input_value = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvs.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/bvs.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | let input_value = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | let expected_val = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:279:17 [INFO] [stderr] | [INFO] [stderr] 279 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:287:17 [INFO] [stderr] | [INFO] [stderr] 287 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:319:17 [INFO] [stderr] | [INFO] [stderr] 319 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:327:17 [INFO] [stderr] | [INFO] [stderr] 327 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/lda.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | reg_a = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | let expected_val = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | reg_x = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | reg_x = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | reg_x = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | reg_x = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldx.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | reg_x = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | let expected_val = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | reg_y = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | reg_y = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | reg_y = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | reg_y = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcode/ldy.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | reg_y = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | let mirroring = match data & 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:117:58 [INFO] [stderr] | [INFO] [stderr] 117 | contains_battery_backed_prg_ram: (data & 0b00000010) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:118:38 [INFO] [stderr] | [INFO] [stderr] 118 | has_trainer: (data & 0b00000100) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:119:50 [INFO] [stderr] | [INFO] [stderr] 119 | igore_mirroring_control: (data & 0b00001000) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:132:39 [INFO] [stderr] | [INFO] [stderr] 132 | vs_unisystem: (data & 0b00000001) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:133:45 [INFO] [stderr] | [INFO] [stderr] 133 | has_play_choice_10: (data & 0b00000010) != 0b0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | is_nes_2_0: (data & 0b00001100) == 0b1000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | let tv_system = match data & 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:228:30 [INFO] [stderr] | [INFO] [stderr] 228 | let raw_byte = &[0b01011011][..]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:248:30 [INFO] [stderr] | [INFO] [stderr] 248 | let raw_byte = &[0b01111001][..]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:253:47 [INFO] [stderr] | [INFO] [stderr] 253 | upper_nybble_of_mapper_numbe: 0b01110000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rom.rs:267:30 [INFO] [stderr] | [INFO] [stderr] 267 | let raw_byte = &[0b00000001][..]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_break_command_flag` [INFO] [stderr] --> src/cpu.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn $setter_name(&mut self, flag: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 84 | bit_flag_getter_setter!(set_break_command_flag, break_command_flag, 4); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `INes` [INFO] [stderr] --> src/rom.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct INes<'n> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | .field("carry", &(self.0 & (1 << 0) > 0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:131:30 [INFO] [stderr] | [INFO] [stderr] 131 | self.registers.pc += (1 + opcode.operands_num()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(1 + opcode.operands_num())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | let unsigned_val = ((val << 1) >> 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((val << 1) >> 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let new_pc = match negtive { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | true => pc - unsigned_val, [INFO] [stderr] 15 | | false => pc + unsigned_val, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if negtive { pc - unsigned_val } else { pc + unsigned_val }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:261:10 [INFO] [stderr] | [INFO] [stderr] 261 | ((addr_high as u16) << 8) + addr_low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(addr_high)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:261:37 [INFO] [stderr] | [INFO] [stderr] 261 | ((addr_high as u16) << 8) + addr_low as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(addr_low)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:293:20 [INFO] [stderr] | [INFO] [stderr] 293 | let addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.read((pc + 1) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:308:28 [INFO] [stderr] | [INFO] [stderr] 308 | let indexed_addr = (base_addr + x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(base_addr + x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:323:28 [INFO] [stderr] | [INFO] [stderr] 323 | let indexed_addr = (base_addr + y) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(base_addr + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | let indirect_addr = indirect_addr as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(indirect_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:414:29 [INFO] [stderr] | [INFO] [stderr] 414 | let indirect_addr = mem.read((pc + 1) as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(mem.read((pc + 1) as u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(0) } else { Cycle(0) }` [INFO] [stderr] ... [INFO] [stderr] 646 | / opcode_fn_with_mode!(abs_x -> (target_fn, dumb_lda, [INFO] [stderr] 647 | | page_crossed Cycle(0), or_else Cycle(0))); [INFO] [stderr] | |_________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(0) } else { Cycle(0) }` [INFO] [stderr] ... [INFO] [stderr] 664 | / opcode_fn_with_mode!(abs_y -> (target_fn, dumb_lda, [INFO] [stderr] 665 | | page_crossed Cycle(0), or_else Cycle(0))); [INFO] [stderr] | |_________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(0) } else { Cycle(0) }` [INFO] [stderr] ... [INFO] [stderr] 699 | / opcode_fn_with_mode!(indirect_y -> (target_fn, dumb_lda, [INFO] [stderr] 700 | | page_crossed Cycle(0), or_else Cycle(0))); [INFO] [stderr] | |______________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/adc.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | let temp = val as u16 + a as u16 + carry; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/adc.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | let temp = val as u16 + a as u16 + carry; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `temp.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, temp)); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/opcode/utils.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | (($operand_a as u16 ^ $result) & 0x80) > 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | set_flag!(overflow -> (registers, a, val, temp)); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(abs_x -> (adc_abs_x, adc, [INFO] [stderr] 25 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(abs_y -> (adc_abs_y, adc, [INFO] [stderr] 27 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/adc.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / opcode_fn_with_mode!(indirect_y -> (adc_indirect_y, adc, [INFO] [stderr] 30 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `result.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, result)); [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_x -> (and_abs_x, and, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / opcode_fn_with_mode!(abs_y -> (and_abs_y, and, [INFO] [stderr] 24 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/and.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / opcode_fn_with_mode!(indirect_y -> (and_indirect_y, and, [INFO] [stderr] 27 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `new_val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/asl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | set_flag!(zero -> (registers, new_val)); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bcc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.carry_flag() { [INFO] [stderr] 13 | | false => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | true => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.carry_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bcs.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.carry_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.carry_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/beq.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.zero_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.zero_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bmi.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.sign_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.sign_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bne.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.zero_flag() { [INFO] [stderr] 13 | | true => Cycle(2), [INFO] [stderr] 14 | | false => { [INFO] [stderr] 15 | | registers.pc = new_pc; [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.zero_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bpl.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.sign_flag() { [INFO] [stderr] 13 | | true => Cycle(2), [INFO] [stderr] 14 | | false => { [INFO] [stderr] 15 | | registers.pc = new_pc; [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.sign_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bvc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.overflow_flag() { [INFO] [stderr] 13 | | false => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | true => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.overflow_flag() { Cycle(2) } else { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/bvs.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match registers.overflow_flag() { [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | registers.pc = new_pc; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 18 | | false => Cycle(2), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 12 | if registers.overflow_flag() { [INFO] [stderr] 13 | registers.pc = new_pc; [INFO] [stderr] 14 | [INFO] [stderr] 15 | if new_page { Cycle(4) } else { Cycle(3) } [INFO] [stderr] 16 | } else { Cycle(2) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (lda_abs_x, lda, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / opcode_fn_with_mode!(abs_y -> (lda_abs_y, lda, [INFO] [stderr] 22 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(6) } else { Cycle(5) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/lda.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / opcode_fn_with_mode!(indirect_y -> (lda_indirect_y, lda, [INFO] [stderr] 25 | | page_crossed Cycle(6), or_else Cycle(5))); [INFO] [stderr] | |______________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldx.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_y -> (ldx_abs_y, ldx, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/opcode/utils.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | $registers.set_zero_flag($val & 0xFF == 0x00); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | set_flag!(zero -> (registers, val)); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/opcode/utils.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match page_crossed { [INFO] [stderr] 117 | | true => $page_crossed_cycles_num, [INFO] [stderr] 118 | | false => $normal_cycles_num, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if page_crossed { Cycle(5) } else { Cycle(4) }` [INFO] [stderr] | [INFO] [stderr] ::: src/opcode/ldy.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / opcode_fn_with_mode!(abs_x -> (ldy_abs_x, ldy, [INFO] [stderr] 20 | | page_crossed Cycle(5), or_else Cycle(4))); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcode/mod.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / match self { [INFO] [stderr] 77 | | $( [INFO] [stderr] 78 | | &OpCode::$opcode => $operands_size, [INFO] [stderr] 79 | | )* [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcode/mod.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | $( [INFO] [stderr] 86 | | &OpCode::$opcode => $opcode_fn, [INFO] [stderr] 87 | | )* [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 115 | / opcodes!( [INFO] [stderr] 116 | | (AdcImm, 0x69, 1, adc_imm), [INFO] [stderr] 117 | | (AdcZeroPage, 0x65, 1, adc_zero_page), [INFO] [stderr] 118 | | (AdcZeroPageX, 0x75, 1, adc_zero_page_x), [INFO] [stderr] ... | [INFO] [stderr] 194 | | (Sei, 0x78, 0, sei_implied) [INFO] [stderr] 195 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | prg_rom_data: take!(16384 * header.prg_rom_size as u32) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.prg_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:65:69 [INFO] [stderr] | [INFO] [stderr] 65 | chr_rom_data: cond!(header.chr_rom_size != 0, take!(8192 * header.chr_rom_size as u32)) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.chr_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rom.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / match parse_header(header) { [INFO] [stderr] 189 | | IResult::Error(e) => panic!("{}", e), [INFO] [stderr] 190 | | _ => {} [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____________^ help: try this: `if let IResult::Error(e) = parse_header(header) { panic!("{}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.19s [INFO] running `"docker" "inspect" "f8ad2ad4f78793db1a428576b797e2cbaaa60c964780831bdb895295b80c19ca"` [INFO] running `"docker" "rm" "-f" "f8ad2ad4f78793db1a428576b797e2cbaaa60c964780831bdb895295b80c19ca"` [INFO] [stdout] f8ad2ad4f78793db1a428576b797e2cbaaa60c964780831bdb895295b80c19ca