[INFO] updating cached repository TheAdnan/hrdja [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheAdnan/hrdja [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheAdnan/hrdja" "work/ex/clippy-test-run/sources/stable/gh/TheAdnan/hrdja"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheAdnan/hrdja'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheAdnan/hrdja" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheAdnan/hrdja"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheAdnan/hrdja'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d481e00847345d7695c6d06c083428c9e6d6fc1 [INFO] sha for GitHub repo TheAdnan/hrdja: 7d481e00847345d7695c6d06c083428c9e6d6fc1 [INFO] validating manifest of TheAdnan/hrdja on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheAdnan/hrdja on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheAdnan/hrdja [INFO] finished frobbing TheAdnan/hrdja [INFO] frobbed toml for TheAdnan/hrdja written to work/ex/clippy-test-run/sources/stable/gh/TheAdnan/hrdja/Cargo.toml [INFO] started frobbing TheAdnan/hrdja [INFO] finished frobbing TheAdnan/hrdja [INFO] frobbed toml for TheAdnan/hrdja written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheAdnan/hrdja/Cargo.toml [INFO] crate TheAdnan/hrdja has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheAdnan/hrdja against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheAdnan/hrdja:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e432e7054688de5eae5bf0f36b99c677c1f949d218f0f37f38c6d20f8fa7bf09 [INFO] running `"docker" "start" "-a" "e432e7054688de5eae5bf0f36b99c677c1f949d218f0f37f38c6d20f8fa7bf09"` [INFO] [stderr] Checking hrdja v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:12:4 [INFO] [stderr] | [INFO] [stderr] 12 | email: email, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:13:4 [INFO] [stderr] | [INFO] [stderr] 13 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:11:4 [INFO] [stderr] | [INFO] [stderr] 11 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:12:4 [INFO] [stderr] | [INFO] [stderr] 12 | email: email, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:13:4 [INFO] [stderr] | [INFO] [stderr] 13 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functions.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functions.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | let number = thread_rng().gen_range(1,33); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:11:2 [INFO] [stderr] | [INFO] [stderr] 11 | return tup [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/functions.rs:6:2 [INFO] [stderr] | [INFO] [stderr] 6 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/functions.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | let number = thread_rng().gen_range(1,33); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:11:2 [INFO] [stderr] | [INFO] [stderr] 11 | return tup [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `active` [INFO] [stderr] --> src/user.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | active: bool [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn calculate_string_length(s: &String) -> usize{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: field is never used: `active` [INFO] [stderr] --> src/user.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | active: bool [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn calculate_string_length(s: &String) -> usize{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "e432e7054688de5eae5bf0f36b99c677c1f949d218f0f37f38c6d20f8fa7bf09"` [INFO] running `"docker" "rm" "-f" "e432e7054688de5eae5bf0f36b99c677c1f949d218f0f37f38c6d20f8fa7bf09"` [INFO] [stdout] e432e7054688de5eae5bf0f36b99c677c1f949d218f0f37f38c6d20f8fa7bf09