[INFO] updating cached repository The-Geek-Squad/spacequery
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/The-Geek-Squad/spacequery
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/The-Geek-Squad/spacequery" "work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/spacequery"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/spacequery'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/The-Geek-Squad/spacequery" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/spacequery"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/spacequery'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c6d6ff3b656cba1e6536d1d07f57fce60ae11517
[INFO] sha for GitHub repo The-Geek-Squad/spacequery: c6d6ff3b656cba1e6536d1d07f57fce60ae11517
[INFO] validating manifest of The-Geek-Squad/spacequery on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of The-Geek-Squad/spacequery on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing The-Geek-Squad/spacequery
[INFO] finished frobbing The-Geek-Squad/spacequery
[INFO] frobbed toml for The-Geek-Squad/spacequery written to work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/spacequery/Cargo.toml
[INFO] started frobbing The-Geek-Squad/spacequery
[INFO] finished frobbing The-Geek-Squad/spacequery
[INFO] frobbed toml for The-Geek-Squad/spacequery written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/spacequery/Cargo.toml
[INFO] crate The-Geek-Squad/spacequery has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting The-Geek-Squad/spacequery against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/spacequery:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1d197a251e30f4305ba2df8864c1dece819d5afad28d7ff819213038479ef921
[INFO] running `"docker" "start" "-a" "1d197a251e30f4305ba2df8864c1dece819d5afad28d7ff819213038479ef921"`
[INFO] [stderr]     Checking clap v2.27.1
[INFO] [stderr]     Checking spacequery v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             qtype: qtype
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `qtype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:218:21
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     domain: domain,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `domain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:219:21
[INFO] [stderr]     |
[INFO] [stderr] 219 |                     addr: addr,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:220:21
[INFO] [stderr]     |
[INFO] [stderr] 220 |                     ttl: ttl
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:227:21
[INFO] [stderr]     |
[INFO] [stderr] 227 |                     domain: domain,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `domain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:229:21
[INFO] [stderr]     |
[INFO] [stderr] 229 |                     data_len: data_len,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_len`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:230:21
[INFO] [stderr]     |
[INFO] [stderr] 230 |                     ttl: ttl
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:156:13
[INFO] [stderr]     |
[INFO] [stderr] 156 |             qtype: qtype
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `qtype`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:218:21
[INFO] [stderr]     |
[INFO] [stderr] 218 |                     domain: domain,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `domain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:219:21
[INFO] [stderr]     |
[INFO] [stderr] 219 |                     addr: addr,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:220:21
[INFO] [stderr]     |
[INFO] [stderr] 220 |                     ttl: ttl
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:227:21
[INFO] [stderr]     |
[INFO] [stderr] 227 |                     domain: domain,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `domain`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:229:21
[INFO] [stderr]     |
[INFO] [stderr] 229 |                     data_len: data_len,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_len`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dnspacket.rs:230:21
[INFO] [stderr]     |
[INFO] [stderr] 230 |                     ttl: ttl
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ttl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/dnspacket.rs:103:31
[INFO] [stderr]     |
[INFO] [stderr] 103 |         try!(buffer.write_u8( ((self.recursion_desired as u8)) |
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/dnspacket.rs:103:31
[INFO] [stderr]     |
[INFO] [stderr] 103 |         try!(buffer.write_u8( ((self.recursion_desired as u8)) |
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/dnspacket.rs:79:39
[INFO] [stderr]    |
[INFO] [stderr] 79 |         self.recursion_desired = (a & (1 << 0)) > 0;
[INFO] [stderr]    |                                       ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/dnspacket.rs:109:32
[INFO] [stderr]     |
[INFO] [stderr] 109 |         try!(buffer.write_u8( (self.rescode.clone() as u8) |
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.rescode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dnspacket.rs:131:19
[INFO] [stderr]     |
[INFO] [stderr] 131 |     pub fn to_num(&self) -> u16 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `raw_addr`
[INFO] [stderr]    --> src/dnspacket.rs:215:43
[INFO] [stderr]     |
[INFO] [stderr] 215 |                                          ((raw_addr >> 0) & 0xFF) as u8);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let res = ((try!(self.read()) as u16) << 8) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let res = (u16::from(match $ expr {
[INFO] [stderr] 60 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 61 | :: Err ( err ) => {
[INFO] [stderr] 62 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 63 | $ crate :: convert :: From :: from ( err ) ) } }) << 8) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:60:19
[INFO] [stderr]    |
[INFO] [stderr] 60 |                   (try!(self.read()) as u16);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 60 |                   u16::from(match $ expr {
[INFO] [stderr] 61 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 62 | :: Err ( err ) => {
[INFO] [stderr] 63 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 64 | $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:67:20
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let res = ((try!(self.read()) as u32) << 24) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let res = (u32::from(match $ expr {
[INFO] [stderr] 68 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 69 | :: Err ( err ) => {
[INFO] [stderr] 70 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 71 | $ crate :: convert :: From :: from ( err ) ) } }) << 24) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:68:20
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   ((try!(self.read()) as u32) << 16) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   (u32::from(match $ expr {
[INFO] [stderr] 69 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 70 | :: Err ( err ) => {
[INFO] [stderr] 71 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 72 | $ crate :: convert :: From :: from ( err ) ) } }) << 16) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   ((try!(self.read()) as u32) << 8) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   (u32::from(match $ expr {
[INFO] [stderr] 70 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 71 | :: Err ( err ) => {
[INFO] [stderr] 72 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 73 | $ crate :: convert :: From :: from ( err ) ) } }) << 8) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(try!(self.read()) as u32)`
[INFO] [stderr]   --> src/packetbuffer.rs:70:19
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   ((try!(self.read()) as u32) << 0);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   ((try!(self.read()) as u32) << 0);
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   (u32::from(match $ expr {
[INFO] [stderr] 71 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 72 | :: Err ( err ) => {
[INFO] [stderr] 73 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 74 | $ crate :: convert :: From :: from ( err ) ) } }) << 0);
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:96:26
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 let b2 = try!(self.get(pos+1)) as u16;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 let b2 = u16::from(match $ expr {
[INFO] [stderr] 97 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 98 | :: Err ( err ) => {
[INFO] [stderr] 99 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 100| $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:97:32
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let offset = (((len as u16) ^ 0xC0) << 8) | b2;
[INFO] [stderr]    |                                ^^^^^^^^^^^^ help: try: `u16::from(len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val`
[INFO] [stderr]    --> src/packetbuffer.rs:153:26
[INFO] [stderr]     |
[INFO] [stderr] 153 |         try!(self.write(((val >> 0) & 0xFF) as u8));
[INFO] [stderr]     |                          ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/dnspacket.rs:79:39
[INFO] [stderr]    |
[INFO] [stderr] 79 |         self.recursion_desired = (a & (1 << 0)) > 0;
[INFO] [stderr]    |                                       ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/dnspacket.rs:109:32
[INFO] [stderr]     |
[INFO] [stderr] 109 |         try!(buffer.write_u8( (self.rescode.clone() as u8) |
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.rescode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/dnspacket.rs:131:19
[INFO] [stderr]     |
[INFO] [stderr] 131 |     pub fn to_num(&self) -> u16 {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `raw_addr`
[INFO] [stderr]    --> src/dnspacket.rs:215:43
[INFO] [stderr]     |
[INFO] [stderr] 215 |                                          ((raw_addr >> 0) & 0xFF) as u8);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let res = ((try!(self.read()) as u16) << 8) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 59 |         let res = (u16::from(match $ expr {
[INFO] [stderr] 60 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 61 | :: Err ( err ) => {
[INFO] [stderr] 62 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 63 | $ crate :: convert :: From :: from ( err ) ) } }) << 8) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:60:19
[INFO] [stderr]    |
[INFO] [stderr] 60 |                   (try!(self.read()) as u16);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 60 |                   u16::from(match $ expr {
[INFO] [stderr] 61 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 62 | :: Err ( err ) => {
[INFO] [stderr] 63 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 64 | $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:67:20
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let res = ((try!(self.read()) as u32) << 24) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let res = (u32::from(match $ expr {
[INFO] [stderr] 68 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 69 | :: Err ( err ) => {
[INFO] [stderr] 70 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 71 | $ crate :: convert :: From :: from ( err ) ) } }) << 24) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:68:20
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   ((try!(self.read()) as u32) << 16) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   (u32::from(match $ expr {
[INFO] [stderr] 69 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 70 | :: Err ( err ) => {
[INFO] [stderr] 71 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 72 | $ crate :: convert :: From :: from ( err ) ) } }) << 16) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:69:20
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   ((try!(self.read()) as u32) << 8) |
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   (u32::from(match $ expr {
[INFO] [stderr] 70 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 71 | :: Err ( err ) => {
[INFO] [stderr] 72 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 73 | $ crate :: convert :: From :: from ( err ) ) } }) << 8) |
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(try!(self.read()) as u32)`
[INFO] [stderr]   --> src/packetbuffer.rs:70:19
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   ((try!(self.read()) as u32) << 0);
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   ((try!(self.read()) as u32) << 0);
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   (u32::from(match $ expr {
[INFO] [stderr] 71 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 72 | :: Err ( err ) => {
[INFO] [stderr] 73 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 74 | $ crate :: convert :: From :: from ( err ) ) } }) << 0);
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:96:26
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 let b2 = try!(self.get(pos+1)) as u16;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 let b2 = u16::from(match $ expr {
[INFO] [stderr] 97 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 98 | :: Err ( err ) => {
[INFO] [stderr] 99 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 100| $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packetbuffer.rs:97:32
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let offset = (((len as u16) ^ 0xC0) << 8) | b2;
[INFO] [stderr]    |                                ^^^^^^^^^^^^ help: try: `u16::from(len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val`
[INFO] [stderr]    --> src/packetbuffer.rs:153:26
[INFO] [stderr]     |
[INFO] [stderr] 153 |         try!(self.write(((val >> 0) & 0xFF) as u8));
[INFO] [stderr]     |                          ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.51s
[INFO] running `"docker" "inspect" "1d197a251e30f4305ba2df8864c1dece819d5afad28d7ff819213038479ef921"`
[INFO] running `"docker" "rm" "-f" "1d197a251e30f4305ba2df8864c1dece819d5afad28d7ff819213038479ef921"`
[INFO] [stdout] 1d197a251e30f4305ba2df8864c1dece819d5afad28d7ff819213038479ef921