[INFO] updating cached repository ThatOtherPerson/forth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ThatOtherPerson/forth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ThatOtherPerson/forth" "work/ex/clippy-test-run/sources/stable/gh/ThatOtherPerson/forth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ThatOtherPerson/forth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ThatOtherPerson/forth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThatOtherPerson/forth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThatOtherPerson/forth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f2eb40633f3710e75ca391e9c7055a695ea1c31 [INFO] sha for GitHub repo ThatOtherPerson/forth: 9f2eb40633f3710e75ca391e9c7055a695ea1c31 [INFO] validating manifest of ThatOtherPerson/forth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ThatOtherPerson/forth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ThatOtherPerson/forth [INFO] finished frobbing ThatOtherPerson/forth [INFO] frobbed toml for ThatOtherPerson/forth written to work/ex/clippy-test-run/sources/stable/gh/ThatOtherPerson/forth/Cargo.toml [INFO] started frobbing ThatOtherPerson/forth [INFO] finished frobbing ThatOtherPerson/forth [INFO] frobbed toml for ThatOtherPerson/forth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThatOtherPerson/forth/Cargo.toml [INFO] crate ThatOtherPerson/forth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ThatOtherPerson/forth against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThatOtherPerson/forth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b50b2d8aa85aa134e06d99973b2c4f8db0a13e881933915da14e275fd69ff5d [INFO] running `"docker" "start" "-a" "4b50b2d8aa85aa134e06d99973b2c4f8db0a13e881933915da14e275fd69ff5d"` [INFO] [stderr] Checking forth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `unary_word` [INFO] [stderr] --> src/stdlib.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / fn unary_word(forth: &mut Runtime, callback: F) -> FResult [INFO] [stderr] 12 | | where [INFO] [stderr] 13 | | F: FnMut(i32) -> i32, [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 19 | | .ok_or("Stack underflow".to_string()) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .ok_or("Stack underflow".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | success.ok_or("Stack underflow".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let name = try!(forth.parse().ok_or( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 83 | | "Attempt to use zero-length string as name".to_string(), [INFO] [stderr] 84 | | )); [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| "Attempt to use zero-length string as name".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | let condition = try!(forth.pop().ok_or("Stack underflow".to_string())) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &Word::Native(callback) => Word::Native(callback), [INFO] [stderr] 17 | | &Word::Colon(ref definition) => Word::Colon(definition.clone()), [INFO] [stderr] 18 | | &Word::Number(num) => Word::Number(num), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | Word::Native(callback) => Word::Native(callback), [INFO] [stderr] 17 | Word::Colon(ref definition) => Word::Colon(definition.clone()), [INFO] [stderr] 18 | Word::Number(num) => Word::Number(num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Runtime` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Runtime { [INFO] [stderr] 31 | | let mut forth = Runtime { [INFO] [stderr] 32 | | input: VecDeque::new(), [INFO] [stderr] 33 | | dictionary: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | forth [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | fn prepend_names(&mut self, names: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:68:59 [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or(Err(format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 69 | | "Undefined word \"{}\"", [INFO] [stderr] 70 | | name [INFO] [stderr] 71 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or_else(|_| Err(format!( [INFO] [stderr] 69 | "Undefined word \"{}\"", [INFO] [stderr] 70 | name [INFO] [stderr] 71 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:68:34 [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or(Err(format!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Word::Number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if let Err(_) = result { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 83 | | self.input.clear(); [INFO] [stderr] 84 | | return result; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match word { [INFO] [stderr] 97 | | &Word::Native(callback) => callback(self), [INFO] [stderr] 98 | | &Word::Colon(ref definition) => { [INFO] [stderr] 99 | | self.prepend_names(definition); [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *word { [INFO] [stderr] 97 | Word::Native(callback) => callback(self), [INFO] [stderr] 98 | Word::Colon(ref definition) => { [INFO] [stderr] 99 | self.prepend_names(definition); [INFO] [stderr] 100 | Ok(()) [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function is never used: `unary_word` [INFO] [stderr] --> src/stdlib.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / fn unary_word(forth: &mut Runtime, callback: F) -> FResult [INFO] [stderr] 12 | | where [INFO] [stderr] 13 | | F: FnMut(i32) -> i32, [INFO] [stderr] 14 | | { [INFO] [stderr] ... | [INFO] [stderr] 19 | | .ok_or("Stack underflow".to_string()) [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:19:10 [INFO] [stderr] | [INFO] [stderr] 19 | .ok_or("Stack underflow".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | success.ok_or("Stack underflow".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | let value = try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | try!(forth.pop().ok_or("Stack underflow".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let name = try!(forth.parse().ok_or( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 83 | | "Attempt to use zero-length string as name".to_string(), [INFO] [stderr] 84 | | )); [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| "Attempt to use zero-length string as name".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/stdlib.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | let condition = try!(forth.pop().ok_or("Stack underflow".to_string())) != 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Stack underflow".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match self { [INFO] [stderr] 16 | | &Word::Native(callback) => Word::Native(callback), [INFO] [stderr] 17 | | &Word::Colon(ref definition) => Word::Colon(definition.clone()), [INFO] [stderr] 18 | | &Word::Number(num) => Word::Number(num), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *self { [INFO] [stderr] 16 | Word::Native(callback) => Word::Native(callback), [INFO] [stderr] 17 | Word::Colon(ref definition) => Word::Colon(definition.clone()), [INFO] [stderr] 18 | Word::Number(num) => Word::Number(num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Runtime` [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Runtime { [INFO] [stderr] 31 | | let mut forth = Runtime { [INFO] [stderr] 32 | | input: VecDeque::new(), [INFO] [stderr] 33 | | dictionary: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 39 | | forth [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | fn prepend_names(&mut self, names: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:68:59 [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or(Err(format!( [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 69 | | "Undefined word \"{}\"", [INFO] [stderr] 70 | | name [INFO] [stderr] 71 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or_else(|_| Err(format!( [INFO] [stderr] 69 | "Undefined word \"{}\"", [INFO] [stderr] 70 | name [INFO] [stderr] 71 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:68:34 [INFO] [stderr] | [INFO] [stderr] 68 | name.parse().map(|num| Word::Number(num)).or(Err(format!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Word::Number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | if let Err(_) = result { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 83 | | self.input.clear(); [INFO] [stderr] 84 | | return result; [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match word { [INFO] [stderr] 97 | | &Word::Native(callback) => callback(self), [INFO] [stderr] 98 | | &Word::Colon(ref definition) => { [INFO] [stderr] 99 | | self.prepend_names(definition); [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *word { [INFO] [stderr] 97 | Word::Native(callback) => callback(self), [INFO] [stderr] 98 | Word::Colon(ref definition) => { [INFO] [stderr] 99 | self.prepend_names(definition); [INFO] [stderr] 100 | Ok(()) [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.62s [INFO] running `"docker" "inspect" "4b50b2d8aa85aa134e06d99973b2c4f8db0a13e881933915da14e275fd69ff5d"` [INFO] running `"docker" "rm" "-f" "4b50b2d8aa85aa134e06d99973b2c4f8db0a13e881933915da14e275fd69ff5d"` [INFO] [stdout] 4b50b2d8aa85aa134e06d99973b2c4f8db0a13e881933915da14e275fd69ff5d