[INFO] updating cached repository TechnoCrunch/acro [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TechnoCrunch/acro [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TechnoCrunch/acro" "work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/acro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/acro'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TechnoCrunch/acro" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/acro"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/acro'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d92755b30efae61f32bd33eb2f9fc26b020db037 [INFO] sha for GitHub repo TechnoCrunch/acro: d92755b30efae61f32bd33eb2f9fc26b020db037 [INFO] validating manifest of TechnoCrunch/acro on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TechnoCrunch/acro on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TechnoCrunch/acro [INFO] finished frobbing TechnoCrunch/acro [INFO] frobbed toml for TechnoCrunch/acro written to work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/acro/Cargo.toml [INFO] started frobbing TechnoCrunch/acro [INFO] finished frobbing TechnoCrunch/acro [INFO] frobbed toml for TechnoCrunch/acro written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/acro/Cargo.toml [INFO] crate TechnoCrunch/acro has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TechnoCrunch/acro against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/acro:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bba4dc9dac894c6fcb4d3f89fbd8d84f40fd5cdfdec2435b27c9df47c7d6614a [INFO] running `"docker" "start" "-a" "bba4dc9dac894c6fcb4d3f89fbd8d84f40fd5cdfdec2435b27c9df47c7d6614a"` [INFO] [stderr] Checking acro v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/mod.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | bios: bios, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bios` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/mod.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | bios: bios, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bios` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::memory` [INFO] [stderr] --> src/arm/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::memory; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `LittleEndian` [INFO] [stderr] --> src/arm/mod.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | use super::byteorder::{ByteOrder, LittleEndian}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::memory` [INFO] [stderr] --> src/arm/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use super::memory; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `LittleEndian` [INFO] [stderr] --> src/arm/mod.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | use super::byteorder::{ByteOrder, LittleEndian}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/arm/mod.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | use super::byteorder::{ByteOrder, LittleEndian}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `inter` [INFO] [stderr] --> src/arm/mod.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn execute(&mut self, inter: &mut Interconnect, instr: Instruction) { [INFO] [stderr] | ^^^^^ help: consider using `_inter` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn read_u8(&self, addr: u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn read_u16(&self, addr: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_u8(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn write_u16(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn write_u32(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `arm::Core` [INFO] [stderr] --> src/arm/mod.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Core { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Core { [INFO] [stderr] 18 | | regs: Registers::new(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for arm::Core { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `arm::Registers` [INFO] [stderr] --> src/arm/mod.rs:56:2 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn new() -> Registers { [INFO] [stderr] | _____^ [INFO] [stderr] 57 | | Registers { [INFO] [stderr] 58 | | gpr: [0; 16], [INFO] [stderr] 59 | | cpsr: 0, [INFO] [stderr] 60 | | spsr: 0, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/arm/mod.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | use super::byteorder::{ByteOrder, LittleEndian}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `inter` [INFO] [stderr] --> src/arm/mod.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | fn execute(&mut self, inter: &mut Interconnect, instr: Instruction) { [INFO] [stderr] | ^^^^^ help: consider using `_inter` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn read_u8(&self, addr: u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn read_u16(&self, addr: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn write_u8(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn write_u16(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/memory/mod.rs:49:30 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn write_u32(&mut self, addr: u32) { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `arm::Core` [INFO] [stderr] --> src/arm/mod.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> Core { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Core { [INFO] [stderr] 18 | | regs: Registers::new(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for arm::Core { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `arm::Registers` [INFO] [stderr] --> src/arm/mod.rs:56:2 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn new() -> Registers { [INFO] [stderr] | _____^ [INFO] [stderr] 57 | | Registers { [INFO] [stderr] 58 | | gpr: [0; 16], [INFO] [stderr] 59 | | cpsr: 0, [INFO] [stderr] 60 | | spsr: 0, [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "bba4dc9dac894c6fcb4d3f89fbd8d84f40fd5cdfdec2435b27c9df47c7d6614a"` [INFO] running `"docker" "rm" "-f" "bba4dc9dac894c6fcb4d3f89fbd8d84f40fd5cdfdec2435b27c9df47c7d6614a"` [INFO] [stdout] bba4dc9dac894c6fcb4d3f89fbd8d84f40fd5cdfdec2435b27c9df47c7d6614a