[INFO] updating cached repository Tahler/assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tahler/assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tahler/assembler" "work/ex/clippy-test-run/sources/stable/gh/Tahler/assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tahler/assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tahler/assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tahler/assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tahler/assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 001775dcea7b8f8165d6d5c95eb479902cb00e3b [INFO] sha for GitHub repo Tahler/assembler: 001775dcea7b8f8165d6d5c95eb479902cb00e3b [INFO] validating manifest of Tahler/assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tahler/assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tahler/assembler [INFO] finished frobbing Tahler/assembler [INFO] frobbed toml for Tahler/assembler written to work/ex/clippy-test-run/sources/stable/gh/Tahler/assembler/Cargo.toml [INFO] started frobbing Tahler/assembler [INFO] finished frobbing Tahler/assembler [INFO] frobbed toml for Tahler/assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tahler/assembler/Cargo.toml [INFO] crate Tahler/assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tahler/assembler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tahler/assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fabcca8db9997b260c2ed72db73b65e70449c29275e1aa4cb852bee5586b8b73 [INFO] running `"docker" "start" "-a" "fabcca8db9997b260c2ed72db73b65e70449c29275e1aa4cb852bee5586b8b73"` [INFO] [stderr] Checking assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | zero_based_num [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | let zero_based_num = one_based_num - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | zero_based_num [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | let zero_based_num = one_based_num - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | assert!(reg_str.starts_with("R")); [INFO] [stderr] | ^^^ help: try using a char instead: `'R'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0x00FF & val)` [INFO] [stderr] --> src/main.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | [((0xFF00 & val) >> 8) as u8, ((0x00FF & val) >> 0) as u8] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / let mut clean_token = token; [INFO] [stderr] 88 | | // TODO: consider removing R and 0x prefixes [INFO] [stderr] 89 | | if token.ends_with(",") { [INFO] [stderr] 90 | | clean_token = &token[..token.len() - 1]; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let clean_token = if token.ends_with(",") { &token[..token.len() - 1] } else { token };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | if token.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | fs::remove_file(out_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:138:65 [INFO] [stderr] | [INFO] [stderr] 138 | let is_src_line = !line.is_empty() && !line.starts_with("#"); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | out_file.write_all(&instruction_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match result { [INFO] [stderr] 164 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 165 | | _ => {} [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = result { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | assert!(reg_str.starts_with("R")); [INFO] [stderr] | ^^^ help: try using a char instead: `'R'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0x00FF & val)` [INFO] [stderr] --> src/main.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | [((0xFF00 & val) >> 8) as u8, ((0x00FF & val) >> 0) as u8] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / let mut clean_token = token; [INFO] [stderr] 88 | | // TODO: consider removing R and 0x prefixes [INFO] [stderr] 89 | | if token.ends_with(",") { [INFO] [stderr] 90 | | clean_token = &token[..token.len() - 1]; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let clean_token = if token.ends_with(",") { &token[..token.len() - 1] } else { token };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | if token.ends_with(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | fs::remove_file(out_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:138:65 [INFO] [stderr] | [INFO] [stderr] 138 | let is_src_line = !line.is_empty() && !line.starts_with("#"); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | out_file.write_all(&instruction_bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match result { [INFO] [stderr] 164 | | Err(err) => println!("{:?}", err), [INFO] [stderr] 165 | | _ => {} [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = result { println!("{:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "fabcca8db9997b260c2ed72db73b65e70449c29275e1aa4cb852bee5586b8b73"` [INFO] running `"docker" "rm" "-f" "fabcca8db9997b260c2ed72db73b65e70449c29275e1aa4cb852bee5586b8b73"` [INFO] [stdout] fabcca8db9997b260c2ed72db73b65e70449c29275e1aa4cb852bee5586b8b73