[INFO] updating cached repository Tacolizard/asm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tacolizard/asm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tacolizard/asm" "work/ex/clippy-test-run/sources/stable/gh/Tacolizard/asm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tacolizard/asm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tacolizard/asm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacolizard/asm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacolizard/asm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf08148fbea183ff01373220798d03015e96cd06 [INFO] sha for GitHub repo Tacolizard/asm: cf08148fbea183ff01373220798d03015e96cd06 [INFO] validating manifest of Tacolizard/asm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tacolizard/asm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tacolizard/asm [INFO] finished frobbing Tacolizard/asm [INFO] frobbed toml for Tacolizard/asm written to work/ex/clippy-test-run/sources/stable/gh/Tacolizard/asm/Cargo.toml [INFO] started frobbing Tacolizard/asm [INFO] finished frobbing Tacolizard/asm [INFO] frobbed toml for Tacolizard/asm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacolizard/asm/Cargo.toml [INFO] crate Tacolizard/asm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tacolizard/asm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacolizard/asm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a6899bc0553c3a372207494b04367f2993ff8845d21428f9f34ad99185755b8 [INFO] running `"docker" "start" "-a" "8a6899bc0553c3a372207494b04367f2993ff8845d21428f9f34ad99185755b8"` [INFO] [stderr] Checking asm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | pub static mut RAM: [u32; 4095] = [0xDEADBEEF; 4095]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | RAM[1] = 0xC001BABE; //ret [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC001_BABE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | RAM[2] = 0x00000000; //EFLAGS [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | RAM[3] = 0x00000000; //stdout [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | RAM[4] = 0x00000000; //stdin [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return top.parse::().expect("Const err."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `top.parse::().expect("Const err.")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return 4093; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `4093` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/asm.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | if vm::RAM[i] == 0xDEADBEEFu32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return prog_translated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `prog_translated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `out_inst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / return buf.lines() [INFO] [stderr] 23 | | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 24 | | .collect() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | buf.lines() [INFO] [stderr] 23 | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 24 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | pub static mut RAM: [u32; 4095] = [0xDEADBEEF; 4095]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | RAM[1] = 0xC001BABE; //ret [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC001_BABE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | RAM[2] = 0x00000000; //EFLAGS [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | RAM[3] = 0x00000000; //stdout [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vm.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | RAM[4] = 0x00000000; //stdin [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return top.parse::().expect("Const err."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `top.parse::().expect("Const err.")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return 4093; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `4093` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/asm.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | if vm::RAM[i] == 0xDEADBEEFu32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return prog_translated; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `prog_translated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `out_inst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / return buf.lines() [INFO] [stderr] 23 | | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 24 | | .collect() [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | buf.lines() [INFO] [stderr] 23 | .map(|l| l.expect("Could not parse line")) [INFO] [stderr] 24 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_str` [INFO] [stderr] --> src/vm.rs:237:1 [INFO] [stderr] | [INFO] [stderr] 237 | pub unsafe fn exec_str(s: &str) {//execute unassembled string [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_str_vec` [INFO] [stderr] --> src/vm.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub unsafe fn exec_str_vec(p: Vec<&str>) {//execute unassembled vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_vec` [INFO] [stderr] --> src/vm.rs:245:1 [INFO] [stderr] | [INFO] [stderr] 245 | pub unsafe fn exec_vec(pro: Vec) {//execute an assembled vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if RAM[0] == cache_ip {RAM[0] = RAM[0] + 0x1};//if an instruction has modified the ip, don't overwrite the change [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[0] += 0x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | stdin.read_line(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | RAM[2] = RAM[2] ^ 0x0_0_0_0_1_0_0_0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[2] ^= 0x0_0_0_0_1_0_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stdout.write(String::from_utf8_lossy(&hex::decode(tv).unwrap()).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/vm.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub unsafe fn exec(space: u32, silent: bool) { [INFO] [stderr] 73 | | //at this level there are no numerical constants, the assembler will [INFO] [stderr] 74 | | //assign the constant value to some open address and all references to the [INFO] [stderr] 75 | | //constant will point to that address [INFO] [stderr] ... | [INFO] [stderr] 234 | | if !silent { dprintln!("AFTER: {:X}\nRET: {:X}\n", RAM[arg1 as usize], RAM[1]); } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(RAM[2] & (1u32<<0))` [INFO] [stderr] --> src/vm.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let zf: u32 = (RAM[2] & (1u32<<0))>>0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/vm.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | let zf: u32 = (RAM[2] & (1u32<<0))>>0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:101:62 [INFO] [stderr] | [INFO] [stderr] 101 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:119:62 [INFO] [stderr] | [INFO] [stderr] 119 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:137:62 [INFO] [stderr] | [INFO] [stderr] 137 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:178:62 [INFO] [stderr] | [INFO] [stderr] 178 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | RAM[arg1 as usize] = RAM[arg1 as usize] & RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] &= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | RAM[arg1 as usize] = RAM[arg1 as usize] | RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] |= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | RAM[arg1 as usize] = RAM[arg1 as usize] ^ RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] ^= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(RAM[2] & (1u32<<0))` [INFO] [stderr] --> src/vm.rs:233:48 [INFO] [stderr] | [INFO] [stderr] 233 | if !silent { dprintln!("zf:{} of:{} sf:{}",(RAM[2] & (1u32<<0))>>0,(RAM[2] & (1u32<<4))>>4,(RAM[2] & (1u32<<8))>>8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/vm.rs:233:58 [INFO] [stderr] | [INFO] [stderr] 233 | if !silent { dprintln!("zf:{} of:{} sf:{}",(RAM[2] & (1u32<<0))>>0,(RAM[2] & (1u32<<4))>>4,(RAM[2] & (1u32<<8))>>8); } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:253:28 [INFO] [stderr] | [INFO] [stderr] 253 | if RAM[a1] < RAM[a2] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | if top.starts_with("\'") { //string [INFO] [stderr] | ^^^^ help: try using a char instead: `'\''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/asm.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | i=i+1; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | if piece.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:38:90 [INFO] [stderr] | [INFO] [stderr] 38 | constants.insert(piece, bind_open(multiparse(piece.trim_left_matches("$")))); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/asm.rs:40:47 [INFO] [stderr] | [INFO] [stderr] 40 | outln = outln.replace(piece, &constants.get(piece).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&constants[piece]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | let pieces = inst.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | out_inst = (0x00_FFF_000 & (string_arg1.parse::().expect("Arg1 masking error.") << 12)) | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= (0x00_FFF_000 & (string_arg1.parse::().expect("Arg1 masking error.") << 12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | out_inst = (0x00_000_FFF & (string_arg2.parse::().expect("Arg2 masking error."))) | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= (0x00_000_FFF & (string_arg2.parse::().expect("Arg2 masking error.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | out_inst = 0xFF_000_000 | out_inst; //apply opcode mask using bitwise OR [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0xFF_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | out_inst = 0x01_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x01_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | out_inst = 0x02_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x02_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | out_inst = 0x03_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x03_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | out_inst = 0x04_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x04_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | out_inst = 0x05_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x05_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | out_inst = 0x06_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x06_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | out_inst = 0x07_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x07_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | out_inst = 0x08_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x08_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | out_inst = 0x09_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x09_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | out_inst = 0x0A_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0A_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | out_inst = 0x0B_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0B_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | out_inst = 0x0C_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0C_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out_inst = 0x0D_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0D_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | out_inst = 0x0F_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0F_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | out_inst = 0x10_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | out_inst = 0x11_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x11_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | out_inst = 0x12_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x12_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | out_inst = 0x13_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x13_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_str` [INFO] [stderr] --> src/vm.rs:237:1 [INFO] [stderr] | [INFO] [stderr] 237 | pub unsafe fn exec_str(s: &str) {//execute unassembled string [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_str_vec` [INFO] [stderr] --> src/vm.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub unsafe fn exec_str_vec(p: Vec<&str>) {//execute unassembled vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `exec_vec` [INFO] [stderr] --> src/vm.rs:245:1 [INFO] [stderr] | [INFO] [stderr] 245 | pub unsafe fn exec_vec(pro: Vec) {//execute an assembled vec [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | if RAM[0] == cache_ip {RAM[0] = RAM[0] + 0x1};//if an instruction has modified the ip, don't overwrite the change [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[0] += 0x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | stdin.read_line(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | RAM[2] = RAM[2] ^ 0x0_0_0_0_1_0_0_0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[2] ^= 0x0_0_0_0_1_0_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stdout.write(String::from_utf8_lossy(&hex::decode(tv).unwrap()).as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/vm.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/vm.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub unsafe fn exec(space: u32, silent: bool) { [INFO] [stderr] 73 | | //at this level there are no numerical constants, the assembler will [INFO] [stderr] 74 | | //assign the constant value to some open address and all references to the [INFO] [stderr] 75 | | //constant will point to that address [INFO] [stderr] ... | [INFO] [stderr] 234 | | if !silent { dprintln!("AFTER: {:X}\nRET: {:X}\n", RAM[arg1 as usize], RAM[1]); } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(RAM[2] & (1u32<<0))` [INFO] [stderr] --> src/vm.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | let zf: u32 = (RAM[2] & (1u32<<0))>>0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/vm.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | let zf: u32 = (RAM[2] & (1u32<<0))>>0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:101:62 [INFO] [stderr] | [INFO] [stderr] 101 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:119:62 [INFO] [stderr] | [INFO] [stderr] 119 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:137:62 [INFO] [stderr] | [INFO] [stderr] 137 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:178:62 [INFO] [stderr] | [INFO] [stderr] 178 | if RAM[arg1 as usize] < RAM[arg2 as usize] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | RAM[arg1 as usize] = RAM[arg1 as usize] & RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] &= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | RAM[arg1 as usize] = RAM[arg1 as usize] | RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] |= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | RAM[arg1 as usize] = RAM[arg1 as usize] ^ RAM[arg2 as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `RAM[arg1 as usize] ^= RAM[arg2 as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(RAM[2] & (1u32<<0))` [INFO] [stderr] --> src/vm.rs:233:48 [INFO] [stderr] | [INFO] [stderr] 233 | if !silent { dprintln!("zf:{} of:{} sf:{}",(RAM[2] & (1u32<<0))>>0,(RAM[2] & (1u32<<4))>>4,(RAM[2] & (1u32<<8))>>8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/vm.rs:233:58 [INFO] [stderr] | [INFO] [stderr] 233 | if !silent { dprintln!("zf:{} of:{} sf:{}",(RAM[2] & (1u32<<0))>>0,(RAM[2] & (1u32<<4))>>4,(RAM[2] & (1u32<<8))>>8); } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vm.rs:253:28 [INFO] [stderr] | [INFO] [stderr] 253 | if RAM[a1] < RAM[a2] { flags = 0x0_0_0_0_0_0_1_0_0 | flags; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= 0x0_0_0_0_0_0_1_0_0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | if top.starts_with("\'") { //string [INFO] [stderr] | ^^^^ help: try using a char instead: `'\''` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/asm.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | i=i+1; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:36:34 [INFO] [stderr] | [INFO] [stderr] 36 | if piece.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:38:90 [INFO] [stderr] | [INFO] [stderr] 38 | constants.insert(piece, bind_open(multiparse(piece.trim_left_matches("$")))); [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/asm.rs:40:47 [INFO] [stderr] | [INFO] [stderr] 40 | outln = outln.replace(piece, &constants.get(piece).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&constants[piece]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | let pieces = inst.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | out_inst = (0x00_FFF_000 & (string_arg1.parse::().expect("Arg1 masking error.") << 12)) | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= (0x00_FFF_000 & (string_arg1.parse::().expect("Arg1 masking error.") << 12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | out_inst = (0x00_000_FFF & (string_arg2.parse::().expect("Arg2 masking error."))) | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= (0x00_000_FFF & (string_arg2.parse::().expect("Arg2 masking error.")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | out_inst = 0xFF_000_000 | out_inst; //apply opcode mask using bitwise OR [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0xFF_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | out_inst = 0x01_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x01_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | out_inst = 0x02_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x02_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | out_inst = 0x03_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x03_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | out_inst = 0x04_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x04_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | out_inst = 0x05_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x05_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | out_inst = 0x06_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x06_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | out_inst = 0x07_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x07_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | out_inst = 0x08_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x08_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | out_inst = 0x09_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x09_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | out_inst = 0x0A_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0A_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | out_inst = 0x0B_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0B_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | out_inst = 0x0C_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0C_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | out_inst = 0x0D_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0D_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | out_inst = 0x0F_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x0F_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | out_inst = 0x10_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | out_inst = 0x11_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x11_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | out_inst = 0x12_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x12_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/asm.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | out_inst = 0x13_000_000 | out_inst; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_inst |= 0x13_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "8a6899bc0553c3a372207494b04367f2993ff8845d21428f9f34ad99185755b8"` [INFO] running `"docker" "rm" "-f" "8a6899bc0553c3a372207494b04367f2993ff8845d21428f9f34ad99185755b8"` [INFO] [stdout] 8a6899bc0553c3a372207494b04367f2993ff8845d21428f9f34ad99185755b8