[INFO] updating cached repository Tacklebox/serialcom [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tacklebox/serialcom [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tacklebox/serialcom" "work/ex/clippy-test-run/sources/stable/gh/Tacklebox/serialcom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tacklebox/serialcom'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tacklebox/serialcom" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacklebox/serialcom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacklebox/serialcom'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 78c32fdd21648ac87579990ab17ab2b48dc4f00c [INFO] sha for GitHub repo Tacklebox/serialcom: 78c32fdd21648ac87579990ab17ab2b48dc4f00c [INFO] validating manifest of Tacklebox/serialcom on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tacklebox/serialcom on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tacklebox/serialcom [INFO] finished frobbing Tacklebox/serialcom [INFO] frobbed toml for Tacklebox/serialcom written to work/ex/clippy-test-run/sources/stable/gh/Tacklebox/serialcom/Cargo.toml [INFO] started frobbing Tacklebox/serialcom [INFO] finished frobbing Tacklebox/serialcom [INFO] frobbed toml for Tacklebox/serialcom written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacklebox/serialcom/Cargo.toml [INFO] crate Tacklebox/serialcom has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tacklebox/serialcom against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tacklebox/serialcom:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34e744068f27bcd7d767eac11d4ccd1dc6abb3b40509cc37b170e028e6268953 [INFO] running `"docker" "start" "-a" "34e744068f27bcd7d767eac11d4ccd1dc6abb3b40509cc37b170e028e6268953"` [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking tui v0.2.0 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking serialcom v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | port.write(&serial_buffer).expect("Unable to write to port"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | event::Key::Ctrl(the_char) => match the_char { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 156 | | 'l' => { [INFO] [stderr] 157 | | serial_output = String::new(); [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | _ => (), [INFO] [stderr] 160 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 155 | event::Key::Ctrl(the_char) => if let 'l' = the_char { [INFO] [stderr] 156 | serial_output = String::new(); [INFO] [stderr] 157 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:188:47 [INFO] [stderr] | [INFO] [stderr] 188 | fn draw(t: &mut Terminal, size: &Rect, user_input: &str, serial_output: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serialcom`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | port.write(&serial_buffer).expect("Unable to write to port"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | event::Key::Ctrl(the_char) => match the_char { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 156 | | 'l' => { [INFO] [stderr] 157 | | serial_output = String::new(); [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | _ => (), [INFO] [stderr] 160 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 155 | event::Key::Ctrl(the_char) => if let 'l' = the_char { [INFO] [stderr] 156 | serial_output = String::new(); [INFO] [stderr] 157 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:188:47 [INFO] [stderr] | [INFO] [stderr] 188 | fn draw(t: &mut Terminal, size: &Rect, user_input: &str, serial_output: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serialcom`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "34e744068f27bcd7d767eac11d4ccd1dc6abb3b40509cc37b170e028e6268953"` [INFO] running `"docker" "rm" "-f" "34e744068f27bcd7d767eac11d4ccd1dc6abb3b40509cc37b170e028e6268953"` [INFO] [stdout] 34e744068f27bcd7d767eac11d4ccd1dc6abb3b40509cc37b170e028e6268953