[INFO] updating cached repository StormtideGame/corrosion [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/StormtideGame/corrosion [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/StormtideGame/corrosion" "work/ex/clippy-test-run/sources/stable/gh/StormtideGame/corrosion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/StormtideGame/corrosion'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/StormtideGame/corrosion" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StormtideGame/corrosion"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StormtideGame/corrosion'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba2c4b9efd81b7dc4dcf984af76832575f27a894 [INFO] sha for GitHub repo StormtideGame/corrosion: ba2c4b9efd81b7dc4dcf984af76832575f27a894 [INFO] validating manifest of StormtideGame/corrosion on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of StormtideGame/corrosion on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing StormtideGame/corrosion [INFO] finished frobbing StormtideGame/corrosion [INFO] frobbed toml for StormtideGame/corrosion written to work/ex/clippy-test-run/sources/stable/gh/StormtideGame/corrosion/Cargo.toml [INFO] started frobbing StormtideGame/corrosion [INFO] finished frobbing StormtideGame/corrosion [INFO] frobbed toml for StormtideGame/corrosion written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StormtideGame/corrosion/Cargo.toml [INFO] crate StormtideGame/corrosion has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting StormtideGame/corrosion against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StormtideGame/corrosion:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5297fc1cef37b90dc05dfdd8bf629646c764c2e4e12c10016dab1aa0d79f4b2e [INFO] running `"docker" "start" "-a" "5297fc1cef37b90dc05dfdd8bf629646c764c2e4e12c10016dab1aa0d79f4b2e"` [INFO] [stderr] Checking corrosion v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/tap_land.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | let forest = game.objects.get(&forest_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.objects[&forest_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/tap_land.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | let mana = *game.mana_pools.get(&player1_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.mana_pools[&player1_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "5297fc1cef37b90dc05dfdd8bf629646c764c2e4e12c10016dab1aa0d79f4b2e"` [INFO] running `"docker" "rm" "-f" "5297fc1cef37b90dc05dfdd8bf629646c764c2e4e12c10016dab1aa0d79f4b2e"` [INFO] [stdout] 5297fc1cef37b90dc05dfdd8bf629646c764c2e4e12c10016dab1aa0d79f4b2e