[INFO] updating cached repository SteffenSunde/aoc_2018_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SteffenSunde/aoc_2018_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SteffenSunde/aoc_2018_rs" "work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/aoc_2018_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/aoc_2018_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SteffenSunde/aoc_2018_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/aoc_2018_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/aoc_2018_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e63cbdb6473c1bc47a600459fab74d510f8a9ebe [INFO] sha for GitHub repo SteffenSunde/aoc_2018_rs: e63cbdb6473c1bc47a600459fab74d510f8a9ebe [INFO] validating manifest of SteffenSunde/aoc_2018_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SteffenSunde/aoc_2018_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SteffenSunde/aoc_2018_rs [INFO] finished frobbing SteffenSunde/aoc_2018_rs [INFO] frobbed toml for SteffenSunde/aoc_2018_rs written to work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/aoc_2018_rs/Cargo.toml [INFO] started frobbing SteffenSunde/aoc_2018_rs [INFO] finished frobbing SteffenSunde/aoc_2018_rs [INFO] frobbed toml for SteffenSunde/aoc_2018_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/aoc_2018_rs/Cargo.toml [INFO] crate SteffenSunde/aoc_2018_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SteffenSunde/aoc_2018_rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/aoc_2018_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a327305a44ee42ecd9be4306b95a3029fc4308e0caee652931cb3a941cbf7518 [INFO] running `"docker" "start" "-a" "a327305a44ee42ecd9be4306b95a3029fc4308e0caee652931cb3a941cbf7518"` [INFO] [stderr] Checking aoc_2018_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day01.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | total_change = total_change + line.unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_change += line.unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day01.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | total_change = total_change + line.unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_change += line.unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day01.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / if visited.contains_key(&total_change) { [INFO] [stderr] 37 | | first_repeat = Some(total_change); [INFO] [stderr] 38 | | break; [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | visited.insert(total_change, true); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: consider using: `visited.entry(total_change)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day02.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / if characters.contains_key(&character) { [INFO] [stderr] 53 | | *characters.get_mut(&character).unwrap() += 1; [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | characters.insert(character, 1); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ help: consider using: `characters.entry(character)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day02.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | fn compare_ids(id1: &String, id2: &String) -> Result<(i32, String), &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day02.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | fn compare_ids(id1: &String, id2: &String) -> Result<(i32, String), &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day01.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | total_change = total_change + line.unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_change += line.unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day01.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | total_change = total_change + line.unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_change += line.unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day01.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | / if visited.contains_key(&total_change) { [INFO] [stderr] 37 | | first_repeat = Some(total_change); [INFO] [stderr] 38 | | break; [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | visited.insert(total_change, true); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: consider using: `visited.entry(total_change)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/day02.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / if characters.contains_key(&character) { [INFO] [stderr] 53 | | *characters.get_mut(&character).unwrap() += 1; [INFO] [stderr] 54 | | } else { [INFO] [stderr] 55 | | characters.insert(character, 1); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ help: consider using: `characters.entry(character)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day02.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | fn compare_ids(id1: &String, id2: &String) -> Result<(i32, String), &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day02.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | fn compare_ids(id1: &String, id2: &String) -> Result<(i32, String), &'static str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `"docker" "inspect" "a327305a44ee42ecd9be4306b95a3029fc4308e0caee652931cb3a941cbf7518"` [INFO] running `"docker" "rm" "-f" "a327305a44ee42ecd9be4306b95a3029fc4308e0caee652931cb3a941cbf7518"` [INFO] [stdout] a327305a44ee42ecd9be4306b95a3029fc4308e0caee652931cb3a941cbf7518