[INFO] updating cached repository Starfunk/largeint [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Starfunk/largeint [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Starfunk/largeint" "work/ex/clippy-test-run/sources/stable/gh/Starfunk/largeint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Starfunk/largeint'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Starfunk/largeint" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Starfunk/largeint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Starfunk/largeint'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d080166a1424cfc929701032daa5f46b582bca01 [INFO] sha for GitHub repo Starfunk/largeint: d080166a1424cfc929701032daa5f46b582bca01 [INFO] validating manifest of Starfunk/largeint on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Starfunk/largeint on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Starfunk/largeint [INFO] finished frobbing Starfunk/largeint [INFO] frobbed toml for Starfunk/largeint written to work/ex/clippy-test-run/sources/stable/gh/Starfunk/largeint/Cargo.toml [INFO] started frobbing Starfunk/largeint [INFO] finished frobbing Starfunk/largeint [INFO] frobbed toml for Starfunk/largeint written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Starfunk/largeint/Cargo.toml [INFO] crate Starfunk/largeint has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Starfunk/largeint against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Starfunk/largeint:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e878902fb75c2d8f1c21dc4d395135f0d7822251145a1f7b1783bdc2ce0390f [INFO] running `"docker" "start" "-a" "4e878902fb75c2d8f1c21dc4d395135f0d7822251145a1f7b1783bdc2ce0390f"` [INFO] [stderr] Checking largeint v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | sign: sign, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:458:13 [INFO] [stderr] | [INFO] [stderr] 458 | sign: sign, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/addition.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | digits [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/addition.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | let digits = vec_to_str(&sum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/multiplication.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | output_str [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/multiplication.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let output_str = vec_to_str(&output_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/multiplication.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | output_vec [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/multiplication.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let output_vec = match num { [INFO] [stderr] | ______________________^ [INFO] [stderr] 46 | | 10...19 => vec![1, num - 10], [INFO] [stderr] 47 | | 20...29 => vec![2, num - 20], [INFO] [stderr] 48 | | 30...39 => vec![3, num - 30], [INFO] [stderr] ... | [INFO] [stderr] 55 | | should not equal more than 89! See carry in the multiplication module."), [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:460:9 [INFO] [stderr] | [INFO] [stderr] 460 | new_int [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:456:23 [INFO] [stderr] | [INFO] [stderr] 456 | let new_int = LargeInt { [INFO] [stderr] | _______________________^ [INFO] [stderr] 457 | | digits: digits_clone, [INFO] [stderr] 458 | | sign: sign, [INFO] [stderr] 459 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/addition.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | digits [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/addition.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | let digits = vec_to_str(&sum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/multiplication.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | output_str [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/multiplication.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let output_str = vec_to_str(&output_vec); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/multiplication.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | output_vec [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/multiplication.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let output_vec = match num { [INFO] [stderr] | ______________________^ [INFO] [stderr] 46 | | 10...19 => vec![1, num - 10], [INFO] [stderr] 47 | | 20...29 => vec![2, num - 20], [INFO] [stderr] 48 | | 30...39 => vec![3, num - 30], [INFO] [stderr] ... | [INFO] [stderr] 55 | | should not equal more than 89! See carry in the multiplication module."), [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:460:9 [INFO] [stderr] | [INFO] [stderr] 460 | new_int [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:456:23 [INFO] [stderr] | [INFO] [stderr] 456 | let new_int = LargeInt { [INFO] [stderr] | _______________________^ [INFO] [stderr] 457 | | digits: digits_clone, [INFO] [stderr] 458 | | sign: sign, [INFO] [stderr] 459 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/addition.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | input = input - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input -= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/addition.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | input = input - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | loopback = loopback + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `loopback += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/difference.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | for _ in 0..count+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | large1[i + index - 1 - loopback] = large1[i + index - 1 - loopback] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index - 1 - loopback] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | large1[i + index - loopback] = large1[i + index - loopback] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index - loopback] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | large1[i + index] = large1[i + index] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | large1[i + index + 1] = large1[i + index + 1] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index + 1] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/difference.rs:49:64 [INFO] [stderr] | [INFO] [stderr] 49 | output_str = String::from(output_str.trim_left_matches("0")); [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/difference.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | } else if &large1.len() == &large2.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 50 | } else if large1.len() == large2.len() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | large1[i] = large1[i] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | large1[i + 1] = large1[i + 1] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + 1] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/difference.rs:69:72 [INFO] [stderr] | [INFO] [stderr] 69 | output_str = String::from(output_str.trim_left_matches("0")); [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/multiplication.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn multiplication_1(large1: &Vec, large2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/multiplication.rs:4:51 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn multiplication_1(large1: &Vec, large2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/division.rs:15:11 [INFO] [stderr] | [INFO] [stderr] 15 | while flag == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `flag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | for i in 1..large1_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=large1_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] --> src/division.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | counter += 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | for _ in counter..large1_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `counter..=large1_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/division.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | if remainder_str == String::from("0") && &large1[counter..counter+1] == "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:64:62 [INFO] [stderr] | [INFO] [stderr] 64 | if remainder_str == String::from("0") && &large1[counter..counter+1] == "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/addition.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | input = input - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input -= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/division.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | else if remainder_str == String::from("0") && &large1[counter..counter+1] != "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | else if remainder_str == String::from("0") && &large1[counter..counter+1] != "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | remainder_str = large1[counter..counter+1].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | remainder_str.push_str(&large1[counter..counter+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/division.rs:104:40 [INFO] [stderr] | [INFO] [stderr] 104 | fn find_the_highest_divider(remainder: &String, large2: &LargeInt, divided: &mut String) -> (String, String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 104 | fn find_the_highest_divider(remainder: &str, large2: &LargeInt, divided: &mut String) -> (String, String) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `remainder.clone()` to [INFO] [stderr] | [INFO] [stderr] 107 | let remainder_largeint = new(remainder.to_string(), sign); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/addition.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | input = input - 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input -= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/division.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | / let index1_str: String; [INFO] [stderr] 127 | | if index1 == 0 { [INFO] [stderr] 128 | | index1_str = String::from("0"); [INFO] [stderr] 129 | | } else { [INFO] [stderr] 130 | | index1_str = index1.to_string(); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let index1_str = if index1 == 0 { String::from("0") } else { index1.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | loopback = loopback + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `loopback += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/difference.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | for _ in 0..count+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | large1[i + index - 1 - loopback] = large1[i + index - 1 - loopback] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index - 1 - loopback] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | large1[i + index - loopback] = large1[i + index - loopback] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index - loopback] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | large1[i + index] = large1[i + index] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | large1[i + index + 1] = large1[i + index + 1] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + index + 1] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if &self.sign == &Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 63 | if self.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | } else if &self.sign == &Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 65 | } else if self.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/difference.rs:49:64 [INFO] [stderr] | [INFO] [stderr] 49 | output_str = String::from(output_str.trim_left_matches("0")); [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/difference.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | } else if &large1.len() == &large2.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 50 | } else if large1.len() == large2.len() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | if &large2[i] > &large1[i] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 100 | if large2[i] > large1[i] { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | else if &large2[i] < &large1[i] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 104 | else if large2[i] < large1[i] { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | large1[i] = large1[i] - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i] -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | large1[i + 1] = large1[i + 1] + 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `large1[i + 1] += 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/difference.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/difference.rs:69:72 [INFO] [stderr] | [INFO] [stderr] 69 | output_str = String::from(output_str.trim_left_matches("0")); [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/multiplication.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn multiplication_1(large1: &Vec, large2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/multiplication.rs:4:51 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn multiplication_1(large1: &Vec, large2: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 133 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 136 | } else if self.sign == Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 137 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 140 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 143 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 146 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 153 | } else if self.sign == Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 154 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 157 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:160:27 [INFO] [stderr] | [INFO] [stderr] 160 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 160 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 163 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 170 | } else if self.sign == Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | / match &self.sign { [INFO] [stderr] 172 | | &Sign::Unsigned => { [INFO] [stderr] 173 | | if large2.sign == Sign::Positive { [INFO] [stderr] 174 | | digits = large2.get_int(); [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 171 | match self.sign { [INFO] [stderr] 172 | Sign::Unsigned => { [INFO] [stderr] 173 | if large2.sign == Sign::Positive { [INFO] [stderr] 174 | digits = large2.get_int(); [INFO] [stderr] 175 | sign = Sign::Positive; [INFO] [stderr] 176 | } else if large2.sign == Sign::Negative { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 221 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] | [INFO] [stderr] --> src/division.rs:15:11 [INFO] [stderr] | [INFO] [stderr] 15 | while flag == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `flag` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 222 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:225:27 [INFO] [stderr] | [INFO] [stderr] 225 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | for i in 1..large1_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=large1_length` [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 225 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 228 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:231:27 [INFO] [stderr] | [INFO] [stderr] 231 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 231 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:238:23 [INFO] [stderr] | [INFO] [stderr] 238 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 238 | } else if self.sign == Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:241:23 [INFO] [stderr] | [INFO] [stderr] 241 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: attempt to mutate range bound within loop; note that the range of the loop is unchanged [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] --> src/division.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | counter += 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 241 | } else if self.sign == Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mut_range_bound)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | for _ in counter..large1_length + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `counter..=large1_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 244 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/division.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | if remainder_str == String::from("0") && &large1[counter..counter+1] == "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 245 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:248:27 [INFO] [stderr] | [INFO] [stderr] 248 | } else if &self.digits.len() < &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 248 | } else if self.digits.len() < large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:64:62 [INFO] [stderr] | [INFO] [stderr] 64 | if remainder_str == String::from("0") && &large1[counter..counter+1] == "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 251 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:254:27 [INFO] [stderr] | [INFO] [stderr] 254 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/division.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | else if remainder_str == String::from("0") && &large1[counter..counter+1] != "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 254 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | else if remainder_str == String::from("0") && &large1[counter..counter+1] != "0" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | / match &self.sign { [INFO] [stderr] 263 | | &Sign::Unsigned => { [INFO] [stderr] 264 | | if large2.sign == Sign::Positive { [INFO] [stderr] 265 | | digits = large2.get_int(); [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | match self.sign { [INFO] [stderr] 263 | Sign::Unsigned => { [INFO] [stderr] 264 | if large2.sign == Sign::Positive { [INFO] [stderr] 265 | digits = large2.get_int(); [INFO] [stderr] 266 | sign = Sign::Negative; [INFO] [stderr] 267 | } else if large2.sign == Sign::Negative { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | remainder_str = large1[counter..counter+1].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/division.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | remainder_str.push_str(&large1[counter..counter+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `counter..=counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/division.rs:104:40 [INFO] [stderr] | [INFO] [stderr] 104 | fn find_the_highest_divider(remainder: &String, large2: &LargeInt, divided: &mut String) -> (String, String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:312:86 [INFO] [stderr] | [INFO] [stderr] 312 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 313 | | digits = multiplication_2(&self.digits, &large2.digits); [INFO] [stderr] 314 | | sign = Sign::Positive; [INFO] [stderr] 315 | | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 104 | fn find_the_highest_divider(remainder: &str, large2: &LargeInt, divided: &mut String) -> (String, String) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `remainder.clone()` to [INFO] [stderr] | [INFO] [stderr] 107 | let remainder_largeint = new(remainder.to_string(), sign); [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:309:79 [INFO] [stderr] | [INFO] [stderr] 309 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 310 | | digits = multiplication_2(&self.digits, &large2.digits); [INFO] [stderr] 311 | | sign = Sign::Positive; [INFO] [stderr] 312 | | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:309:16 [INFO] [stderr] | [INFO] [stderr] 309 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 309 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 315 | } else if self.sign == Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:318:23 [INFO] [stderr] | [INFO] [stderr] 318 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 318 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/division.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | / let index1_str: String; [INFO] [stderr] 127 | | if index1 == 0 { [INFO] [stderr] 128 | | index1_str = String::from("0"); [INFO] [stderr] 129 | | } else { [INFO] [stderr] 130 | | index1_str = index1.to_string(); [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let index1_str = if index1 == 0 { String::from("0") } else { index1.to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | else if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 351 | else if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:353:23 [INFO] [stderr] | [INFO] [stderr] 353 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 353 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:356:23 [INFO] [stderr] | [INFO] [stderr] 356 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 356 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:358:24 [INFO] [stderr] | [INFO] [stderr] 358 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 358 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:364:16 [INFO] [stderr] | [INFO] [stderr] 364 | if &self.compare(large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 364 | if self.compare(large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:366:23 [INFO] [stderr] | [INFO] [stderr] 366 | } else if &self.compare(large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 366 | } else if self.compare(large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:368:23 [INFO] [stderr] | [INFO] [stderr] 368 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 368 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if &self.sign == &Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 63 | if self.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | } else if &self.sign == &Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 65 | } else if self.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:403:23 [INFO] [stderr] | [INFO] [stderr] 403 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 403 | } else if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | if &large2[i] > &large1[i] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:405:23 [INFO] [stderr] | [INFO] [stderr] 405 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 100 | if large2[i] > large1[i] { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 405 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:104:29 [INFO] [stderr] | [INFO] [stderr] 104 | else if &large2[i] < &large1[i] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 104 | else if large2[i] < large1[i] { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:407:23 [INFO] [stderr] | [INFO] [stderr] 407 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 407 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:409:24 [INFO] [stderr] | [INFO] [stderr] 409 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 409 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:418:21 [INFO] [stderr] | [INFO] [stderr] 418 | else if &self.compare(large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 418 | else if self.compare(large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:424:23 [INFO] [stderr] | [INFO] [stderr] 424 | } else if &self.compare(large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 424 | } else if self.compare(large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:445:22 [INFO] [stderr] | [INFO] [stderr] 445 | if digits == String::from("") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:133:16 [INFO] [stderr] | [INFO] [stderr] 133 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 133 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 136 | } else if self.sign == Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 137 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 140 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:143:27 [INFO] [stderr] | [INFO] [stderr] 143 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 143 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 146 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:474:28 [INFO] [stderr] | [INFO] [stderr] 474 | pub fn vec_to_str(vec: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 153 | } else if self.sign == Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 154 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 157 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:160:27 [INFO] [stderr] | [INFO] [stderr] 160 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 160 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 163 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 170 | } else if self.sign == Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | / match &self.sign { [INFO] [stderr] 172 | | &Sign::Unsigned => { [INFO] [stderr] 173 | | if large2.sign == Sign::Positive { [INFO] [stderr] 174 | | digits = large2.get_int(); [INFO] [stderr] ... | [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 171 | match self.sign { [INFO] [stderr] 172 | Sign::Unsigned => { [INFO] [stderr] 173 | if large2.sign == Sign::Positive { [INFO] [stderr] 174 | digits = large2.get_int(); [INFO] [stderr] 175 | sign = Sign::Positive; [INFO] [stderr] 176 | } else if large2.sign == Sign::Negative { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 221 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 222 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:225:27 [INFO] [stderr] | [INFO] [stderr] 225 | } else if &self.digits.len() < &large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 225 | } else if self.digits.len() < large2.digits.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:228:27 [INFO] [stderr] | [INFO] [stderr] 228 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 228 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:231:27 [INFO] [stderr] | [INFO] [stderr] 231 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 231 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:238:23 [INFO] [stderr] | [INFO] [stderr] 238 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 238 | } else if self.sign == Sign::Positive && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:241:23 [INFO] [stderr] | [INFO] [stderr] 241 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 241 | } else if self.sign == Sign::Negative && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 244 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:245:20 [INFO] [stderr] | [INFO] [stderr] 245 | if &self.digits.len() > &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 245 | if self.digits.len() > large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:248:27 [INFO] [stderr] | [INFO] [stderr] 248 | } else if &self.digits.len() < &large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 248 | } else if self.digits.len() < large2.digits.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | } else if &self.compare(&large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 251 | } else if self.compare(&large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:254:27 [INFO] [stderr] | [INFO] [stderr] 254 | } else if &self.compare(&large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 254 | } else if self.compare(&large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | / match &self.sign { [INFO] [stderr] 263 | | &Sign::Unsigned => { [INFO] [stderr] 264 | | if large2.sign == Sign::Positive { [INFO] [stderr] 265 | | digits = large2.get_int(); [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | match self.sign { [INFO] [stderr] 263 | Sign::Unsigned => { [INFO] [stderr] 264 | if large2.sign == Sign::Positive { [INFO] [stderr] 265 | digits = large2.get_int(); [INFO] [stderr] 266 | sign = Sign::Negative; [INFO] [stderr] 267 | } else if large2.sign == Sign::Negative { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:312:86 [INFO] [stderr] | [INFO] [stderr] 312 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 313 | | digits = multiplication_2(&self.digits, &large2.digits); [INFO] [stderr] 314 | | sign = Sign::Positive; [INFO] [stderr] 315 | | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:309:79 [INFO] [stderr] | [INFO] [stderr] 309 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 310 | | digits = multiplication_2(&self.digits, &large2.digits); [INFO] [stderr] 311 | | sign = Sign::Positive; [INFO] [stderr] 312 | | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:309:16 [INFO] [stderr] | [INFO] [stderr] 309 | if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 309 | if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | } else if &self.sign == &Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 315 | } else if self.sign == Sign::Unsigned || large2.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:318:23 [INFO] [stderr] | [INFO] [stderr] 318 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 318 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `largeint`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:351:21 [INFO] [stderr] | [INFO] [stderr] 351 | else if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 351 | else if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:353:23 [INFO] [stderr] | [INFO] [stderr] 353 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 353 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:356:23 [INFO] [stderr] | [INFO] [stderr] 356 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 356 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:358:24 [INFO] [stderr] | [INFO] [stderr] 358 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 358 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:364:16 [INFO] [stderr] | [INFO] [stderr] 364 | if &self.compare(large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 364 | if self.compare(large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:366:23 [INFO] [stderr] | [INFO] [stderr] 366 | } else if &self.compare(large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 366 | } else if self.compare(large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:368:23 [INFO] [stderr] | [INFO] [stderr] 368 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 368 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:403:23 [INFO] [stderr] | [INFO] [stderr] 403 | } else if &self.sign == &Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 403 | } else if self.sign == Sign::Positive && large2.sign == Sign::Positive { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:405:23 [INFO] [stderr] | [INFO] [stderr] 405 | } else if &self.sign == &Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 405 | } else if self.sign == Sign::Unsigned { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:407:23 [INFO] [stderr] | [INFO] [stderr] 407 | } else if &self.sign == &Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 407 | } else if self.sign == Sign::Negative && large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:409:24 [INFO] [stderr] | [INFO] [stderr] 409 | } else if &self.sign == &Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 409 | } else if self.sign == Sign::Negative || large2.sign == Sign::Negative { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:418:21 [INFO] [stderr] | [INFO] [stderr] 418 | else if &self.compare(large2) == &Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 418 | else if self.compare(large2) == Compare::Larger { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:424:23 [INFO] [stderr] | [INFO] [stderr] 424 | } else if &self.compare(large2) == &Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 424 | } else if self.compare(large2) == Compare::Smaller { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:445:22 [INFO] [stderr] | [INFO] [stderr] 445 | if digits == String::from("") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:474:28 [INFO] [stderr] | [INFO] [stderr] 474 | pub fn vec_to_str(vec: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `largeint`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4e878902fb75c2d8f1c21dc4d395135f0d7822251145a1f7b1783bdc2ce0390f"` [INFO] running `"docker" "rm" "-f" "4e878902fb75c2d8f1c21dc4d395135f0d7822251145a1f7b1783bdc2ce0390f"` [INFO] [stdout] 4e878902fb75c2d8f1c21dc4d395135f0d7822251145a1f7b1783bdc2ce0390f