[INFO] updating cached repository Sorrop/word-parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Sorrop/word-parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Sorrop/word-parser" "work/ex/clippy-test-run/sources/stable/gh/Sorrop/word-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sorrop/word-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Sorrop/word-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sorrop/word-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sorrop/word-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8313771b01feef91e775aa879571a112749f6a80
[INFO] sha for GitHub repo Sorrop/word-parser: 8313771b01feef91e775aa879571a112749f6a80
[INFO] validating manifest of Sorrop/word-parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Sorrop/word-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Sorrop/word-parser
[INFO] finished frobbing Sorrop/word-parser
[INFO] frobbed toml for Sorrop/word-parser written to work/ex/clippy-test-run/sources/stable/gh/Sorrop/word-parser/Cargo.toml
[INFO] started frobbing Sorrop/word-parser
[INFO] finished frobbing Sorrop/word-parser
[INFO] frobbed toml for Sorrop/word-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sorrop/word-parser/Cargo.toml
[INFO] crate Sorrop/word-parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Sorrop/word-parser against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sorrop/word-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b7e00abcee99e83400bbebd7401b34380862f0ab69e1b5ddb3f099a4a340415f
[INFO] running `"docker" "start" "-a" "b7e00abcee99e83400bbebd7401b34380862f0ab69e1b5ddb3f099a4a340415f"`
[INFO] [stderr]     Checking word_parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return words;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `words`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return &s[start..]
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&s[start..]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return contents
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return words;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `words`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return &s[start..]
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&s[start..]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/finder.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return contents
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/finder.rs:3:24
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn parse_words (s: &String) -> Vec<&str> {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/finder.rs:3:24
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn parse_words (s: &String) -> Vec<&str> {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/finder.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     if *c == [b','] || *c == [b'.'] || *c == [b'!'] || *c == [b'?']
[INFO] [stderr] 44 | |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0 {
[INFO] [stderr] 45 | |         return false;
[INFO] [stderr] 46 | |     }
[INFO] [stderr] 47 | |     else {
[INFO] [stderr] 48 | |         return true;
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] help: you can reduce it to
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return !(*c == [b','] || *c == [b'.'] || *c == [b'!'] || *c == [b'?']
[INFO] [stderr] 44 |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/finder.rs:44:44
[INFO] [stderr]    |
[INFO] [stderr] 44 |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0 {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn slurp_file(filename: &String) -> String {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/finder.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     if *c == [b','] || *c == [b'.'] || *c == [b'!'] || *c == [b'?']
[INFO] [stderr] 44 | |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0 {
[INFO] [stderr] 45 | |         return false;
[INFO] [stderr] 46 | |     }
[INFO] [stderr] 47 | |     else {
[INFO] [stderr] 48 | |         return true;
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] help: you can reduce it to
[INFO] [stderr]    |
[INFO] [stderr] 43 |     return !(*c == [b','] || *c == [b'.'] || *c == [b'!'] || *c == [b'?']
[INFO] [stderr] 44 |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/finder.rs:44:44
[INFO] [stderr]    |
[INFO] [stderr] 44 |         || *c == [b' '] || *c == [b'\n'] ||c.len() == 0 {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `c.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:23:25
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn slurp_file(filename: &String) -> String {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.39s
[INFO] running `"docker" "inspect" "b7e00abcee99e83400bbebd7401b34380862f0ab69e1b5ddb3f099a4a340415f"`
[INFO] running `"docker" "rm" "-f" "b7e00abcee99e83400bbebd7401b34380862f0ab69e1b5ddb3f099a4a340415f"`
[INFO] [stdout] b7e00abcee99e83400bbebd7401b34380862f0ab69e1b5ddb3f099a4a340415f