[INFO] updating cached repository Soft/palettematch
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Soft/palettematch
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Soft/palettematch" "work/ex/clippy-test-run/sources/stable/gh/Soft/palettematch"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Soft/palettematch'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Soft/palettematch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Soft/palettematch"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Soft/palettematch'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b7a4f83745b34b57e7c1866ab2196d4886d5c2e1
[INFO] sha for GitHub repo Soft/palettematch: b7a4f83745b34b57e7c1866ab2196d4886d5c2e1
[INFO] validating manifest of Soft/palettematch on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Soft/palettematch on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Soft/palettematch
[INFO] finished frobbing Soft/palettematch
[INFO] frobbed toml for Soft/palettematch written to work/ex/clippy-test-run/sources/stable/gh/Soft/palettematch/Cargo.toml
[INFO] started frobbing Soft/palettematch
[INFO] finished frobbing Soft/palettematch
[INFO] frobbed toml for Soft/palettematch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Soft/palettematch/Cargo.toml
[INFO] crate Soft/palettematch has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Soft/palettematch against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Soft/palettematch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fb030e01134861e25489c23601ca6ea35002fcb7984f7b2d4c1674d5895532a6
[INFO] running `"docker" "start" "-a" "fb030e01134861e25489c23601ca6ea35002fcb7984f7b2d4c1674d5895532a6"`
[INFO] [stderr]     Checking palettematch v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return best;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `best`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return best;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `best`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |             r: r as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(r)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:40:16
[INFO] [stderr]    |
[INFO] [stderr] 40 |             g: g as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(g)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |             b: b as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:159:34
[INFO] [stderr]     |
[INFO] [stderr] 159 |                         palette: &'a Palette<LABColor>,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LABColor]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/main.rs:166:5
[INFO] [stderr]     |
[INFO] [stderr] 166 | /     if best.is_none() {
[INFO] [stderr] 167 | |         return None;
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^ help: replace_it_with: `best?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:182:40
[INFO] [stderr]     |
[INFO] [stderr] 182 | fn read_colors<F>(metric: &F, palette: &Palette<LABColor>)
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^ help: change this to: `&[LABColor]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |             r: r as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(r)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:40:16
[INFO] [stderr]    |
[INFO] [stderr] 40 |             g: g as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(g)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |             b: b as f64 / 255.0,
[INFO] [stderr]    |                ^^^^^^^^ help: try: `f64::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:159:34
[INFO] [stderr]     |
[INFO] [stderr] 159 |                         palette: &'a Palette<LABColor>,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[LABColor]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/main.rs:166:5
[INFO] [stderr]     |
[INFO] [stderr] 166 | /     if best.is_none() {
[INFO] [stderr] 167 | |         return None;
[INFO] [stderr] 168 | |     }
[INFO] [stderr]     | |_____^ help: replace_it_with: `best?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:182:40
[INFO] [stderr]     |
[INFO] [stderr] 182 | fn read_colors<F>(metric: &F, palette: &Palette<LABColor>)
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^ help: change this to: `&[LABColor]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.55s
[INFO] running `"docker" "inspect" "fb030e01134861e25489c23601ca6ea35002fcb7984f7b2d4c1674d5895532a6"`
[INFO] running `"docker" "rm" "-f" "fb030e01134861e25489c23601ca6ea35002fcb7984f7b2d4c1674d5895532a6"`
[INFO] [stdout] fb030e01134861e25489c23601ca6ea35002fcb7984f7b2d4c1674d5895532a6