[INFO] updating cached repository SmilingNavern/rconsole [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SmilingNavern/rconsole [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SmilingNavern/rconsole" "work/ex/clippy-test-run/sources/stable/gh/SmilingNavern/rconsole"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SmilingNavern/rconsole'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SmilingNavern/rconsole" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SmilingNavern/rconsole"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SmilingNavern/rconsole'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdd83e2a89e420a52b014b3faa0b3688cc03dc54 [INFO] sha for GitHub repo SmilingNavern/rconsole: cdd83e2a89e420a52b014b3faa0b3688cc03dc54 [INFO] validating manifest of SmilingNavern/rconsole on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SmilingNavern/rconsole on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SmilingNavern/rconsole [INFO] finished frobbing SmilingNavern/rconsole [INFO] frobbed toml for SmilingNavern/rconsole written to work/ex/clippy-test-run/sources/stable/gh/SmilingNavern/rconsole/Cargo.toml [INFO] started frobbing SmilingNavern/rconsole [INFO] finished frobbing SmilingNavern/rconsole [INFO] frobbed toml for SmilingNavern/rconsole written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SmilingNavern/rconsole/Cargo.toml [INFO] crate SmilingNavern/rconsole has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SmilingNavern/rconsole against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SmilingNavern/rconsole:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 132e61e63c6c5f828ad11cb21910718c4e0963ab5bd0c11571d9dd61aee70b46 [INFO] running `"docker" "start" "-a" "132e61e63c6c5f828ad11cb21910718c4e0963ab5bd0c11571d9dd61aee70b46"` [INFO] [stderr] Checking rconsole v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | if answer.to_lowercase() == "y".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | sysreq_fh.write(key.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | fn handle_client(mut stream: TcpStream, password: &String, sysreq_fh: &mut File) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | do_sysreq(&mut stream, c.to_lowercase(), sysreq_fh); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | if answer.to_lowercase() == "y".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | sysreq_fh.write(key.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | fn handle_client(mut stream: TcpStream, password: &String, sysreq_fh: &mut File) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | do_sysreq(&mut stream, c.to_lowercase(), sysreq_fh); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "132e61e63c6c5f828ad11cb21910718c4e0963ab5bd0c11571d9dd61aee70b46"` [INFO] running `"docker" "rm" "-f" "132e61e63c6c5f828ad11cb21910718c4e0963ab5bd0c11571d9dd61aee70b46"` [INFO] [stdout] 132e61e63c6c5f828ad11cb21910718c4e0963ab5bd0c11571d9dd61aee70b46