[INFO] updating cached repository ShotaroTsuji/simple-phom [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ShotaroTsuji/simple-phom [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ShotaroTsuji/simple-phom" "work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/simple-phom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/simple-phom'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ShotaroTsuji/simple-phom" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/simple-phom"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/simple-phom'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7b53ef017d6b7b08b041bd90995a16eec8c427b2 [INFO] sha for GitHub repo ShotaroTsuji/simple-phom: 7b53ef017d6b7b08b041bd90995a16eec8c427b2 [INFO] validating manifest of ShotaroTsuji/simple-phom on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ShotaroTsuji/simple-phom on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ShotaroTsuji/simple-phom [INFO] finished frobbing ShotaroTsuji/simple-phom [INFO] frobbed toml for ShotaroTsuji/simple-phom written to work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/simple-phom/Cargo.toml [INFO] started frobbing ShotaroTsuji/simple-phom [INFO] finished frobbing ShotaroTsuji/simple-phom [INFO] frobbed toml for ShotaroTsuji/simple-phom written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/simple-phom/Cargo.toml [INFO] crate ShotaroTsuji/simple-phom has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ShotaroTsuji/simple-phom against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/simple-phom:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c247016b621feda0b683eee90d0743b339ff37aafdd4ec33a5e34a958082531e [INFO] running `"docker" "start" "-a" "c247016b621feda0b683eee90d0743b339ff37aafdd4ec33a5e34a958082531e"` [INFO] [stderr] Checking simple-phom v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `dimension` [INFO] [stderr] --> src/z2reduction.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | dimension: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `birth` [INFO] [stderr] --> src/z2reduction.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | birth: usize, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `death` [INFO] [stderr] --> src/z2reduction.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | death: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `parent` [INFO] [stderr] --> src/z2reduction.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | parent: Pairing<'a, C>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `filteredcomplex::FilteredComplex` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/filteredcomplex.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl FilteredComplex { [INFO] [stderr] 33 | | pub fn new() -> FilteredComplex { [INFO] [stderr] 34 | | FilteredComplex { [INFO] [stderr] 35 | | start: 0, [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filteredcomplex::FilteredComplex` [INFO] [stderr] --> src/filteredcomplex.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> FilteredComplex { [INFO] [stderr] 34 | | FilteredComplex { [INFO] [stderr] 35 | | start: 0, [INFO] [stderr] 36 | | simplices: Vec::new(), [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filteredcomplex.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simplex.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | assert!(vec.len() > 0, "vector has no element"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/simplex.rs:44:53 [INFO] [stderr] | [INFO] [stderr] 44 | } else if self.index == self.vertices.len() { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 45 | | None [INFO] [stderr] 46 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/simplex.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | if self.vertices.len() == 1 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 43 | | None [INFO] [stderr] 44 | | } else if self.index == self.vertices.len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/simplex.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let vec: Vec = head.chain(tail).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `head.chain(tail).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/simplex.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let ref v = &self.vertices; [INFO] [stderr] | ----^^^^^------------------ help: try: `let v = &(&self.vertices);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `z2reduction::Z2BoundaryMatrix` [INFO] [stderr] --> src/z2reduction.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Z2BoundaryMatrix { [INFO] [stderr] 18 | | Z2BoundaryMatrix { [INFO] [stderr] 19 | | columns: Vec::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.columns.get(index).unwrap().lowest() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | let left = self.columns.get(j1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | let right = self.columns.get(j2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | let right = self.columns.get_mut(j2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if self.elements.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | while left_slice.len() > 0 || right_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | while left_slice.len() > 0 || right_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/z2vector.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | } else if left_slice[0] > right_slice[0] { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 51 | | result.push(left_slice[0]); [INFO] [stderr] 52 | | left_slice = &left_slice[1..]; [INFO] [stderr] 53 | | } else if left_slice[0] < right_slice[0] { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/z2vector.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | } else if right_slice.len() == 0 { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 48 | | result.push(left_slice[0]); [INFO] [stderr] 49 | | left_slice = &left_slice[1..]; [INFO] [stderr] 50 | | } else if left_slice[0] > right_slice[0] { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if left_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | } else if right_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.elements.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/z2vector.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let ref v = &self.elements; [INFO] [stderr] | ----^^^^^------------------ help: try: `let v = &(&self.elements);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple-phom`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `dimension` [INFO] [stderr] --> src/z2reduction.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | dimension: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `birth` [INFO] [stderr] --> src/z2reduction.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | birth: usize, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `death` [INFO] [stderr] --> src/z2reduction.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | death: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `parent` [INFO] [stderr] --> src/z2reduction.rs:201:5 [INFO] [stderr] | [INFO] [stderr] 201 | parent: Pairing<'a, C>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `filteredcomplex::FilteredComplex` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/filteredcomplex.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl FilteredComplex { [INFO] [stderr] 33 | | pub fn new() -> FilteredComplex { [INFO] [stderr] 34 | | FilteredComplex { [INFO] [stderr] 35 | | start: 0, [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filteredcomplex::FilteredComplex` [INFO] [stderr] --> src/filteredcomplex.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> FilteredComplex { [INFO] [stderr] 34 | | FilteredComplex { [INFO] [stderr] 35 | | start: 0, [INFO] [stderr] 36 | | simplices: Vec::new(), [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/filteredcomplex.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/simplex.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | assert!(vec.len() > 0, "vector has no element"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/simplex.rs:44:53 [INFO] [stderr] | [INFO] [stderr] 44 | } else if self.index == self.vertices.len() { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 45 | | None [INFO] [stderr] 46 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/simplex.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | if self.vertices.len() == 1 { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 43 | | None [INFO] [stderr] 44 | | } else if self.index == self.vertices.len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/simplex.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let vec: Vec = head.chain(tail).map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `head.chain(tail).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/simplex.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | self.index = self.index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/simplex.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let ref v = &self.vertices; [INFO] [stderr] | ----^^^^^------------------ help: try: `let v = &(&self.vertices);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `z2reduction::Z2BoundaryMatrix` [INFO] [stderr] --> src/z2reduction.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Z2BoundaryMatrix { [INFO] [stderr] 18 | | Z2BoundaryMatrix { [INFO] [stderr] 19 | | columns: Vec::new(), [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | self.columns.get(index).unwrap().lowest() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | let left = self.columns.get(j1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | let right = self.columns.get(j2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/z2reduction.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | let right = self.columns.get_mut(j2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.columns[j2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if self.elements.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | while left_slice.len() > 0 || right_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | while left_slice.len() > 0 || right_slice.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/z2vector.rs:50:54 [INFO] [stderr] | [INFO] [stderr] 50 | } else if left_slice[0] > right_slice[0] { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 51 | | result.push(left_slice[0]); [INFO] [stderr] 52 | | left_slice = &left_slice[1..]; [INFO] [stderr] 53 | | } else if left_slice[0] < right_slice[0] { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/z2vector.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | } else if right_slice.len() == 0 { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 48 | | result.push(left_slice[0]); [INFO] [stderr] 49 | | left_slice = &left_slice[1..]; [INFO] [stderr] 50 | | } else if left_slice[0] > right_slice[0] { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if left_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | } else if right_slice.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/z2vector.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | self.elements.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/z2vector.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let ref v = &self.elements; [INFO] [stderr] | ----^^^^^------------------ help: try: `let v = &(&self.elements);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple-phom`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c247016b621feda0b683eee90d0743b339ff37aafdd4ec33a5e34a958082531e"` [INFO] running `"docker" "rm" "-f" "c247016b621feda0b683eee90d0743b339ff37aafdd4ec33a5e34a958082531e"` [INFO] [stdout] c247016b621feda0b683eee90d0743b339ff37aafdd4ec33a5e34a958082531e