[INFO] updating cached repository ShaunKarran/virmic-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ShaunKarran/virmic-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ShaunKarran/virmic-rs" "work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/virmic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/virmic-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ShaunKarran/virmic-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/virmic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/virmic-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6d6dc99779a82bd4e5dd0e60d8f64ebe507be12 [INFO] sha for GitHub repo ShaunKarran/virmic-rs: b6d6dc99779a82bd4e5dd0e60d8f64ebe507be12 [INFO] validating manifest of ShaunKarran/virmic-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ShaunKarran/virmic-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ShaunKarran/virmic-rs [INFO] finished frobbing ShaunKarran/virmic-rs [INFO] frobbed toml for ShaunKarran/virmic-rs written to work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/virmic-rs/Cargo.toml [INFO] started frobbing ShaunKarran/virmic-rs [INFO] finished frobbing ShaunKarran/virmic-rs [INFO] frobbed toml for ShaunKarran/virmic-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/virmic-rs/Cargo.toml [INFO] crate ShaunKarran/virmic-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ShaunKarran/virmic-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/virmic-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d52354d85aaeabcfa49e8e5ac2cdfe34d1c4bcd5e952f075b760d2e93a08e358 [INFO] running `"docker" "start" "-a" "d52354d85aaeabcfa49e8e5ac2cdfe34d1c4bcd5e952f075b760d2e93a08e358"` [INFO] [stderr] Checking virmic-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | CPU { r0: 0, r1: 0, pc: 0, memory: memory, is_running: true } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | CPU { r0: 0, r1: 0, pc: 0, memory: memory, is_running: true } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | 0x01 => { self.r0 = self.r0 + self.r1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 += self.r1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | 0x02 => { self.r0 = self.r0 - self.r1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 -= self.r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | 0x03 => { self.r0 = self.r0 + 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | 0x04 => { self.r1 = self.r1 + 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r1 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | 0x05 => { self.r0 = self.r0 - 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | 0x06 => { self.r1 = self.r1 - 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r1 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | file.read(&mut program).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `virmic-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | 0x01 => { self.r0 = self.r0 + self.r1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 += self.r1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | 0x02 => { self.r0 = self.r0 - self.r1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 -= self.r1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | 0x03 => { self.r0 = self.r0 + 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | 0x04 => { self.r1 = self.r1 + 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r1 += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | 0x05 => { self.r0 = self.r0 - 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r0 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | 0x06 => { self.r1 = self.r1 - 1; 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.r1 -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | file.read(&mut program).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `virmic-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d52354d85aaeabcfa49e8e5ac2cdfe34d1c4bcd5e952f075b760d2e93a08e358"` [INFO] running `"docker" "rm" "-f" "d52354d85aaeabcfa49e8e5ac2cdfe34d1c4bcd5e952f075b760d2e93a08e358"` [INFO] [stdout] d52354d85aaeabcfa49e8e5ac2cdfe34d1c4bcd5e952f075b760d2e93a08e358