[INFO] updating cached repository ShadowNinja/mt_media_collector
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ShadowNinja/mt_media_collector
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ShadowNinja/mt_media_collector" "work/ex/clippy-test-run/sources/stable/gh/ShadowNinja/mt_media_collector"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ShadowNinja/mt_media_collector'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ShadowNinja/mt_media_collector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShadowNinja/mt_media_collector"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShadowNinja/mt_media_collector'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] dadaedacc1d639f6c73dce5922824103f5d35858
[INFO] sha for GitHub repo ShadowNinja/mt_media_collector: dadaedacc1d639f6c73dce5922824103f5d35858
[INFO] validating manifest of ShadowNinja/mt_media_collector on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ShadowNinja/mt_media_collector on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ShadowNinja/mt_media_collector
[INFO] finished frobbing ShadowNinja/mt_media_collector
[INFO] frobbed toml for ShadowNinja/mt_media_collector written to work/ex/clippy-test-run/sources/stable/gh/ShadowNinja/mt_media_collector/Cargo.toml
[INFO] started frobbing ShadowNinja/mt_media_collector
[INFO] finished frobbing ShadowNinja/mt_media_collector
[INFO] frobbed toml for ShadowNinja/mt_media_collector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShadowNinja/mt_media_collector/Cargo.toml
[INFO] crate ShadowNinja/mt_media_collector has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ShadowNinja/mt_media_collector against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShadowNinja/mt_media_collector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a16c0802acd97ca2f5001c64af2944a18a184bda4878223e38db5abf8dd6807b
[INFO] running `"docker" "start" "-a" "a16c0802acd97ca2f5001c64af2944a18a184bda4878223e38db5abf8dd6807b"`
[INFO] [stderr]     Checking mt_media_collector v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:301:2
[INFO] [stderr]     |
[INFO] [stderr] 301 |     matches
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:294:16
[INFO] [stderr]     |
[INFO] [stderr] 294 |       let matches = add_symlink_arg(app)
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 295 | |         .group(ArgGroup::with_name("media_out")
[INFO] [stderr] 296 | |             .args(&["out", "media"]))
[INFO] [stderr] 297 | |         .group(ArgGroup::with_name("media_transfer")
[INFO] [stderr] 298 | |             .args(&["copy", "symlink", "hardlink"]))
[INFO] [stderr] 299 | |         .get_matches();
[INFO] [stderr]     | |______________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/main.rs:301:2
[INFO] [stderr]     |
[INFO] [stderr] 301 |     matches
[INFO] [stderr]     |     ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/main.rs:294:16
[INFO] [stderr]     |
[INFO] [stderr] 294 |       let matches = add_symlink_arg(app)
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 295 | |         .group(ArgGroup::with_name("media_out")
[INFO] [stderr] 296 | |             .args(&["out", "media"]))
[INFO] [stderr] 297 | |         .group(ArgGroup::with_name("media_transfer")
[INFO] [stderr] 298 | |             .args(&["copy", "symlink", "hardlink"]))
[INFO] [stderr] 299 | |         .get_matches();
[INFO] [stderr]     | |______________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:151:20
[INFO] [stderr]     |
[INFO] [stderr] 151 | fn write_index(ms: &MediaSet, path: &Path) -> io::Result<()> {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:162:20
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn copy_assets(ms: &MediaSet, path: &Path, mode: AssetCopyMode) -> io::Result<()> {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:151:20
[INFO] [stderr]     |
[INFO] [stderr] 151 | fn write_index(ms: &MediaSet, path: &Path) -> io::Result<()> {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:162:20
[INFO] [stderr]     |
[INFO] [stderr] 162 | fn copy_assets(ms: &MediaSet, path: &Path, mode: AssetCopyMode) -> io::Result<()> {
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:314:45
[INFO] [stderr]     |
[INFO] [stderr] 314 |     let out_path = args.value_of_os("out").map(|s| PathBuf::from(s));
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:314:45
[INFO] [stderr]     |
[INFO] [stderr] 314 |     let out_path = args.value_of_os("out").map(|s| PathBuf::from(s));
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.58s
[INFO] running `"docker" "inspect" "a16c0802acd97ca2f5001c64af2944a18a184bda4878223e38db5abf8dd6807b"`
[INFO] running `"docker" "rm" "-f" "a16c0802acd97ca2f5001c64af2944a18a184bda4878223e38db5abf8dd6807b"`
[INFO] [stdout] a16c0802acd97ca2f5001c64af2944a18a184bda4878223e38db5abf8dd6807b