[INFO] updating cached repository Sgeo/therock_decoder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sgeo/therock_decoder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/therock_decoder" "work/ex/clippy-test-run/sources/stable/gh/Sgeo/therock_decoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sgeo/therock_decoder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/therock_decoder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/therock_decoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/therock_decoder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9dc2cadcc06c77ae58d8c3f3e1e764c1c3f28f16 [INFO] sha for GitHub repo Sgeo/therock_decoder: 9dc2cadcc06c77ae58d8c3f3e1e764c1c3f28f16 [INFO] validating manifest of Sgeo/therock_decoder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sgeo/therock_decoder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sgeo/therock_decoder [INFO] finished frobbing Sgeo/therock_decoder [INFO] frobbed toml for Sgeo/therock_decoder written to work/ex/clippy-test-run/sources/stable/gh/Sgeo/therock_decoder/Cargo.toml [INFO] started frobbing Sgeo/therock_decoder [INFO] finished frobbing Sgeo/therock_decoder [INFO] frobbed toml for Sgeo/therock_decoder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/therock_decoder/Cargo.toml [INFO] crate Sgeo/therock_decoder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sgeo/therock_decoder against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/therock_decoder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdb7a20c97128a8d8011711d2987c904ef60e8d432f43a0edddbf55da6e6649f [INFO] running `"docker" "start" "-a" "fdb7a20c97128a8d8011711d2987c904ef60e8d432f43a0edddbf55da6e6649f"` [INFO] [stderr] Checking therock_decoder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const START: u64 = 0x08EDB7; // First moov, based on manual inspection. [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0008_EDB7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const START: u64 = 0x08EDB7; // First moov, based on manual inspection. [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0008_EDB7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `WriteBytesExt` [INFO] [stderr] --> src/main.rs:8:53 [INFO] [stderr] | [INFO] [stderr] 8 | use byteorder::{ByteOrder, BigEndian, ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `WriteBytesExt` [INFO] [stderr] --> src/main.rs:8:53 [INFO] [stderr] | [INFO] [stderr] 8 | use byteorder::{ByteOrder, BigEndian, ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `SCIGUY` should have a snake case name such as `sciguy` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let mut SCIGUY = fs::OpenOptions::new().read(true).write(true).open("SCIGUY.MOV").expect("Unable to open SCIGUY.MOV!"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | current += atom_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(atom_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `SCIGUY` should have a snake case name such as `sciguy` [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let mut SCIGUY = fs::OpenOptions::new().read(true).write(true).open("SCIGUY.MOV").expect("Unable to open SCIGUY.MOV!"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | current += atom_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(atom_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `SCIGUY` should have a snake case name such as `sciguy` [INFO] [stderr] --> src/main.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | fn convert(SCIGUY: &mut File, offset: u64) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `SCIGUY` should have a snake case name such as `sciguy` [INFO] [stderr] --> src/main.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | fn convert(SCIGUY: &mut File, offset: u64) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "fdb7a20c97128a8d8011711d2987c904ef60e8d432f43a0edddbf55da6e6649f"` [INFO] running `"docker" "rm" "-f" "fdb7a20c97128a8d8011711d2987c904ef60e8d432f43a0edddbf55da6e6649f"` [INFO] [stdout] fdb7a20c97128a8d8011711d2987c904ef60e8d432f43a0edddbf55da6e6649f