[INFO] updating cached repository SamSmith7/aoc2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SamSmith7/aoc2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SamSmith7/aoc2017" "work/ex/clippy-test-run/sources/stable/gh/SamSmith7/aoc2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SamSmith7/aoc2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SamSmith7/aoc2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamSmith7/aoc2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamSmith7/aoc2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2a21e83acdaa95ab82899ae2ff431fb5e6712fb3 [INFO] sha for GitHub repo SamSmith7/aoc2017: 2a21e83acdaa95ab82899ae2ff431fb5e6712fb3 [INFO] validating manifest of SamSmith7/aoc2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SamSmith7/aoc2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SamSmith7/aoc2017 [INFO] finished frobbing SamSmith7/aoc2017 [INFO] frobbed toml for SamSmith7/aoc2017 written to work/ex/clippy-test-run/sources/stable/gh/SamSmith7/aoc2017/Cargo.toml [INFO] started frobbing SamSmith7/aoc2017 [INFO] finished frobbing SamSmith7/aoc2017 [INFO] frobbed toml for SamSmith7/aoc2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamSmith7/aoc2017/Cargo.toml [INFO] crate SamSmith7/aoc2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SamSmith7/aoc2017 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamSmith7/aoc2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 001f27c4f7b4e66447c84d8a3fcbfd9e75d0e8491ea69a875e8a8798607c42ff [INFO] running `"docker" "start" "-a" "001f27c4f7b4e66447c84d8a3fcbfd9e75d0e8491ea69a875e8a8798607c42ff"` [INFO] [stderr] Checking aoc_2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day1/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / let compare_idx: usize; [INFO] [stderr] 42 | | [INFO] [stderr] 43 | | if next >= length { [INFO] [stderr] 44 | | compare_idx = next % length; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | compare_idx = next; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let compare_idx = if next >= length { next % length } else { next };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | fn min(vec: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | fn max(vec: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | line.split("\t") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/mod.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | .filter(|x| x.to_string().is_empty() == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!x.to_string().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | fn find_divisor(line: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2/mod.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 72 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let result = input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2/mod.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 85 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let result2 = input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day3/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let result: u32; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if rem > i { [INFO] [stderr] 31 | | result = rem - 1; [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | result = (2 * i) - rem - 1; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if rem > i { rem - 1 } else { (2 * i) - rem - 1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | n = n + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day1/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / let compare_idx: usize; [INFO] [stderr] 42 | | [INFO] [stderr] 43 | | if next >= length { [INFO] [stderr] 44 | | compare_idx = next % length; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | compare_idx = next; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let compare_idx = if next >= length { next % length } else { next };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | fn min(vec: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | fn max(vec: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | line.split("\t") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/mod.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | .filter(|x| x.to_string().is_empty() == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!x.to_string().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/mod.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | fn find_divisor(line: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2/mod.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 72 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | let result = input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day2/mod.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 85 | | .fold(0, |acc, x| acc + x); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day2/mod.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let result2 = input.split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day3/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let result: u32; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if rem > i { [INFO] [stderr] 31 | | result = rem - 1; [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | result = (2 * i) - rem - 1; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if rem > i { rem - 1 } else { (2 * i) - rem - 1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day3/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | n = n + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `"docker" "inspect" "001f27c4f7b4e66447c84d8a3fcbfd9e75d0e8491ea69a875e8a8798607c42ff"` [INFO] running `"docker" "rm" "-f" "001f27c4f7b4e66447c84d8a3fcbfd9e75d0e8491ea69a875e8a8798607c42ff"` [INFO] [stdout] 001f27c4f7b4e66447c84d8a3fcbfd9e75d0e8491ea69a875e8a8798607c42ff