[INFO] updating cached repository Safort/dupchecker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Safort/dupchecker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Safort/dupchecker" "work/ex/clippy-test-run/sources/stable/gh/Safort/dupchecker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Safort/dupchecker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Safort/dupchecker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Safort/dupchecker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Safort/dupchecker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4b44b6b5082f68896a89cf8abe1993e2609b6b02 [INFO] sha for GitHub repo Safort/dupchecker: 4b44b6b5082f68896a89cf8abe1993e2609b6b02 [INFO] validating manifest of Safort/dupchecker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Safort/dupchecker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Safort/dupchecker [INFO] finished frobbing Safort/dupchecker [INFO] frobbed toml for Safort/dupchecker written to work/ex/clippy-test-run/sources/stable/gh/Safort/dupchecker/Cargo.toml [INFO] started frobbing Safort/dupchecker [INFO] finished frobbing Safort/dupchecker [INFO] frobbed toml for Safort/dupchecker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Safort/dupchecker/Cargo.toml [INFO] crate Safort/dupchecker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Safort/dupchecker against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Safort/dupchecker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 917ffaa5b31c5a22abc8464597dac83b5c5a97b9e115b416cd7abfc193b18df4 [INFO] running `"docker" "start" "-a" "917ffaa5b31c5a22abc8464597dac83b5c5a97b9e115b416cd7abfc193b18df4"` [INFO] [stderr] Checking dupchecker v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if *&dir.is_file() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `dir.is_file()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | } else if *&dir.is_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `dir.is_dir()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/lib.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | if duplicates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `duplicates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if !store.contains_key(&hash) { [INFO] [stderr] 67 | | store.insert(hash, file_path); [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | duplicates.push(file_path.to_string()); [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `store.entry(hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if *&dir.is_file() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `dir.is_file()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | } else if *&dir.is_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `dir.is_dir()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/lib.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:123:26 [INFO] [stderr] | [INFO] [stderr] 123 | assert_eq!(hash, 6797947405645866459); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_797_947_405_645_866_459` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | if duplicates.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `duplicates.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if !store.contains_key(&hash) { [INFO] [stderr] 67 | | store.insert(hash, file_path); [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | duplicates.push(file_path.to_string()); [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `store.entry(hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "917ffaa5b31c5a22abc8464597dac83b5c5a97b9e115b416cd7abfc193b18df4"` [INFO] running `"docker" "rm" "-f" "917ffaa5b31c5a22abc8464597dac83b5c5a97b9e115b416cd7abfc193b18df4"` [INFO] [stdout] 917ffaa5b31c5a22abc8464597dac83b5c5a97b9e115b416cd7abfc193b18df4