[INFO] updating cached repository SLMT/rust-ptt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SLMT/rust-ptt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/rust-ptt" "work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ptt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ptt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/rust-ptt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ptt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ptt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] df0e1171a2d42a7d02b12d9b085d601561c0a7c3 [INFO] sha for GitHub repo SLMT/rust-ptt: df0e1171a2d42a7d02b12d9b085d601561c0a7c3 [INFO] validating manifest of SLMT/rust-ptt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SLMT/rust-ptt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SLMT/rust-ptt [INFO] finished frobbing SLMT/rust-ptt [INFO] frobbed toml for SLMT/rust-ptt written to work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ptt/Cargo.toml [INFO] started frobbing SLMT/rust-ptt [INFO] finished frobbing SLMT/rust-ptt [INFO] frobbed toml for SLMT/rust-ptt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ptt/Cargo.toml [INFO] crate SLMT/rust-ptt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SLMT/rust-ptt against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ptt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2dc42c4bd5761f6feaab845bf747fe6f08e82536927f317e9f2a884b05b9654b [INFO] running `"docker" "start" "-a" "2dc42c4bd5761f6feaab845bf747fe6f08e82536927f317e9f2a884b05b9654b"` [INFO] [stderr] Checking rust-ptt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telnet.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | cb_resize_term: cb_resize_term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cb_resize_term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/telnet.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | cb_resize_term: cb_resize_term, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cb_resize_term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/telnet.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | stream.write(init_msg).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telnet.rs:107:35 [INFO] [stderr] | [INFO] [stderr] 107 | ProcessState::None => match byte { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 108 | | IAC => { [INFO] [stderr] 109 | | // Change to "wait for command" state when receiving IAC [INFO] [stderr] 110 | | self.process_state = ProcessState::WaitForCommand; [INFO] [stderr] 111 | | }, [INFO] [stderr] 112 | | _ => {} // TODO: Default action [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | ProcessState::None => if let IAC = byte { [INFO] [stderr] 108 | // Change to "wait for command" state when receiving IAC [INFO] [stderr] 109 | self.process_state = ProcessState::WaitForCommand; [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | let width = ((buf[1] as u32) << 8) + (buf[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | let width = ((buf[1] as u32) << 8) + (buf[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | let height = ((buf[3] as u32) << 8) + (buf[4] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | let height = ((buf[3] as u32) << 8) + (buf[4] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telnet.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / match self.cb_resize_term { [INFO] [stderr] 131 | | Some(cb) => cb(width, height), [INFO] [stderr] 132 | | None => {} // Do Nothing [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(cb) = self.cb_resize_term { cb(width, height) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-ptt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/telnet.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | stream.write(init_msg).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telnet.rs:107:35 [INFO] [stderr] | [INFO] [stderr] 107 | ProcessState::None => match byte { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 108 | | IAC => { [INFO] [stderr] 109 | | // Change to "wait for command" state when receiving IAC [INFO] [stderr] 110 | | self.process_state = ProcessState::WaitForCommand; [INFO] [stderr] 111 | | }, [INFO] [stderr] 112 | | _ => {} // TODO: Default action [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 107 | ProcessState::None => if let IAC = byte { [INFO] [stderr] 108 | // Change to "wait for command" state when receiving IAC [INFO] [stderr] 109 | self.process_state = ProcessState::WaitForCommand; [INFO] [stderr] 110 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | let width = ((buf[1] as u32) << 8) + (buf[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | let width = ((buf[1] as u32) << 8) + (buf[2] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | let height = ((buf[3] as u32) << 8) + (buf[4] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/telnet.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | let height = ((buf[3] as u32) << 8) + (buf[4] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/telnet.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | / match self.cb_resize_term { [INFO] [stderr] 131 | | Some(cb) => cb(width, height), [INFO] [stderr] 132 | | None => {} // Do Nothing [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(cb) = self.cb_resize_term { cb(width, height) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-ptt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2dc42c4bd5761f6feaab845bf747fe6f08e82536927f317e9f2a884b05b9654b"` [INFO] running `"docker" "rm" "-f" "2dc42c4bd5761f6feaab845bf747fe6f08e82536927f317e9f2a884b05b9654b"` [INFO] [stdout] 2dc42c4bd5761f6feaab845bf747fe6f08e82536927f317e9f2a884b05b9654b