[INFO] updating cached repository Ryan1729/split_suit_tgf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ryan1729/split_suit_tgf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/split_suit_tgf" "work/ex/clippy-test-run/sources/stable/gh/Ryan1729/split_suit_tgf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ryan1729/split_suit_tgf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/split_suit_tgf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/split_suit_tgf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/split_suit_tgf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebc85c7d5c80813a45b6de7ef6c396e7423a812d [INFO] sha for GitHub repo Ryan1729/split_suit_tgf: ebc85c7d5c80813a45b6de7ef6c396e7423a812d [INFO] validating manifest of Ryan1729/split_suit_tgf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ryan1729/split_suit_tgf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ryan1729/split_suit_tgf [INFO] finished frobbing Ryan1729/split_suit_tgf [INFO] frobbed toml for Ryan1729/split_suit_tgf written to work/ex/clippy-test-run/sources/stable/gh/Ryan1729/split_suit_tgf/Cargo.toml [INFO] started frobbing Ryan1729/split_suit_tgf [INFO] finished frobbing Ryan1729/split_suit_tgf [INFO] frobbed toml for Ryan1729/split_suit_tgf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/split_suit_tgf/Cargo.toml [INFO] crate Ryan1729/split_suit_tgf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ryan1729/split_suit_tgf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/split_suit_tgf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 948f53cd078bfafd12132f9ba672ae4d0809656967cb8106eae84c983bc5e10a [INFO] running `"docker" "start" "-a" "948f53cd078bfafd12132f9ba672ae4d0809656967cb8106eae84c983bc5e10a"` [INFO] [stderr] Checking split_suit_tgf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / if index1 != index2 { [INFO] [stderr] 45 | | if t1.1 == t2.1 || t1.2 == t2.2 { [INFO] [stderr] 46 | | result.push_str(&format!("{} {}\n", index1, index2)); [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if index1 != index2 && (t1.1 == t2.1 || t1.2 == t2.2) { [INFO] [stderr] 45 | result.push_str(&format!("{} {}\n", index1, index2)); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / if index1 != index2 { [INFO] [stderr] 45 | | if t1.1 == t2.1 || t1.2 == t2.2 { [INFO] [stderr] 46 | | result.push_str(&format!("{} {}\n", index1, index2)); [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if index1 != index2 && (t1.1 == t2.1 || t1.2 == t2.2) { [INFO] [stderr] 45 | result.push_str(&format!("{} {}\n", index1, index2)); [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | let mut chunks = line.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | let mut chunks = line.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "948f53cd078bfafd12132f9ba672ae4d0809656967cb8106eae84c983bc5e10a"` [INFO] running `"docker" "rm" "-f" "948f53cd078bfafd12132f9ba672ae4d0809656967cb8106eae84c983bc5e10a"` [INFO] [stdout] 948f53cd078bfafd12132f9ba672ae4d0809656967cb8106eae84c983bc5e10a