[INFO] updating cached repository Ryan1729/markov_jukebox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ryan1729/markov_jukebox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/markov_jukebox" "work/ex/clippy-test-run/sources/stable/gh/Ryan1729/markov_jukebox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ryan1729/markov_jukebox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/markov_jukebox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/markov_jukebox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/markov_jukebox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c6c631a33a41ab937f9c0d9150775280a273a6a [INFO] sha for GitHub repo Ryan1729/markov_jukebox: 9c6c631a33a41ab937f9c0d9150775280a273a6a [INFO] validating manifest of Ryan1729/markov_jukebox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ryan1729/markov_jukebox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ryan1729/markov_jukebox [INFO] finished frobbing Ryan1729/markov_jukebox [INFO] frobbed toml for Ryan1729/markov_jukebox written to work/ex/clippy-test-run/sources/stable/gh/Ryan1729/markov_jukebox/Cargo.toml [INFO] started frobbing Ryan1729/markov_jukebox [INFO] finished frobbing Ryan1729/markov_jukebox [INFO] frobbed toml for Ryan1729/markov_jukebox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/markov_jukebox/Cargo.toml [INFO] crate Ryan1729/markov_jukebox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ryan1729/markov_jukebox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/markov_jukebox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b27095d469d8364ce82836721c41a6c038129cf2cb3b40a77ab18e9992517f13 [INFO] running `"docker" "start" "-a" "b27095d469d8364ce82836721c41a6c038129cf2cb3b40a77ab18e9992517f13"` [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Checking sample v0.6.2 [INFO] [stderr] Checking hound v2.0.0 [INFO] [stderr] Checking markov_jukebox v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if cfg!(debug_assertions) { [INFO] [stderr] 56 | | vec![42] [INFO] [stderr] 57 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if cfg!(debug_assertions) { [INFO] [stderr] 55 | vec![42] [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | let timestamp = std::time::SystemTime::now() [INFO] [stderr] 58 | .duration_since(std::time::UNIX_EPOCH) [INFO] [stderr] 59 | .map(|dur| dur.as_secs()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | let new_duration = (duration as f64 * (SAMPLE_RATE as f64 / spec.sample_rate as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(duration)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | let new_duration = (duration as f64 * (SAMPLE_RATE as f64 / spec.sample_rate as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | .from_hz_to_hz(spec.sample_rate as f64, SAMPLE_RATE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:145:33 [INFO] [stderr] | [INFO] [stderr] 145 | fn blend_frames(frames: &Vec, rng: &mut R, remove: bool) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `frames`. [INFO] [stderr] --> src/main.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 163 | for in frames.iter().take(2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | let mut keys: Vec<(Frame, Frame)> = next_frames.keys().map(|&k| k).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `next_frames.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | .and_then(|c| if c.len() > 0 { Some(c) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:34 [INFO] [stderr] | [INFO] [stderr] 195 | .and_then(|c| if c.len() > 0 { Some(c) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:28 [INFO] [stderr] | [INFO] [stderr] 231 | fn get_next_frames(frames: &Vec) -> NextFrames { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | fn is_audible(frame: &Frame) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | fn magnitude(frame: &Frame) -> i16 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:257:25 [INFO] [stderr] | [INFO] [stderr] 257 | fn write_frames(frames: &Vec, optional_name: Option<&str>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | fn write_frames_with_name(frames: &Vec, name: &str) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `channel` is only used to index `frame`. [INFO] [stderr] --> src/main.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | for channel in 0..NUM_CHANNELS { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 289 | for in frame.iter().take(NUM_CHANNELS) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 55 | | if cfg!(debug_assertions) { [INFO] [stderr] 56 | | vec![42] [INFO] [stderr] 57 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if cfg!(debug_assertions) { [INFO] [stderr] 55 | vec![42] [INFO] [stderr] 56 | } else { [INFO] [stderr] 57 | let timestamp = std::time::SystemTime::now() [INFO] [stderr] 58 | .duration_since(std::time::UNIX_EPOCH) [INFO] [stderr] 59 | .map(|dur| dur.as_secs()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | let new_duration = (duration as f64 * (SAMPLE_RATE as f64 / spec.sample_rate as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(duration)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | let new_duration = (duration as f64 * (SAMPLE_RATE as f64 / spec.sample_rate as f64)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | .from_hz_to_hz(spec.sample_rate as f64, SAMPLE_RATE as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(spec.sample_rate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:145:33 [INFO] [stderr] | [INFO] [stderr] 145 | fn blend_frames(frames: &Vec, rng: &mut R, remove: bool) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `frames`. [INFO] [stderr] --> src/main.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 163 | for in frames.iter().take(2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | let mut keys: Vec<(Frame, Frame)> = next_frames.keys().map(|&k| k).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `next_frames.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | .and_then(|c| if c.len() > 0 { Some(c) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:34 [INFO] [stderr] | [INFO] [stderr] 195 | .and_then(|c| if c.len() > 0 { Some(c) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:28 [INFO] [stderr] | [INFO] [stderr] 231 | fn get_next_frames(frames: &Vec) -> NextFrames { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | fn is_audible(frame: &Frame) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Frame` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | fn magnitude(frame: &Frame) -> i16 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:257:25 [INFO] [stderr] | [INFO] [stderr] 257 | fn write_frames(frames: &Vec, optional_name: Option<&str>) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | fn write_frames_with_name(frames: &Vec, name: &str) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Frame]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `channel` is only used to index `frame`. [INFO] [stderr] --> src/main.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | for channel in 0..NUM_CHANNELS { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 289 | for in frame.iter().take(NUM_CHANNELS) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.93s [INFO] running `"docker" "inspect" "b27095d469d8364ce82836721c41a6c038129cf2cb3b40a77ab18e9992517f13"` [INFO] running `"docker" "rm" "-f" "b27095d469d8364ce82836721c41a6c038129cf2cb3b40a77ab18e9992517f13"` [INFO] [stdout] b27095d469d8364ce82836721c41a6c038129cf2cb3b40a77ab18e9992517f13