[INFO] updating cached repository Ryan1729/lua_call_tgf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ryan1729/lua_call_tgf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/lua_call_tgf" "work/ex/clippy-test-run/sources/stable/gh/Ryan1729/lua_call_tgf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ryan1729/lua_call_tgf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ryan1729/lua_call_tgf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/lua_call_tgf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/lua_call_tgf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32a5f2480d79f3a717fd8fabc8236c84258f6246 [INFO] sha for GitHub repo Ryan1729/lua_call_tgf: 32a5f2480d79f3a717fd8fabc8236c84258f6246 [INFO] validating manifest of Ryan1729/lua_call_tgf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ryan1729/lua_call_tgf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ryan1729/lua_call_tgf [INFO] finished frobbing Ryan1729/lua_call_tgf [INFO] frobbed toml for Ryan1729/lua_call_tgf written to work/ex/clippy-test-run/sources/stable/gh/Ryan1729/lua_call_tgf/Cargo.toml [INFO] started frobbing Ryan1729/lua_call_tgf [INFO] finished frobbing Ryan1729/lua_call_tgf [INFO] frobbed toml for Ryan1729/lua_call_tgf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/lua_call_tgf/Cargo.toml [INFO] crate Ryan1729/lua_call_tgf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ryan1729/lua_call_tgf against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ryan1729/lua_call_tgf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abe283ca33ec33ea1de607ce39abcb8dfd3e3db94fad2dfe1838f3fc0b2d99aa [INFO] running `"docker" "start" "-a" "abe283ca33ec33ea1de607ce39abcb8dfd3e3db94fad2dfe1838f3fc0b2d99aa"` [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking lua_call_tgf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `print_more` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let print_more = matches.is_present("verbose"); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_print_more` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | File::open(filename).expect(&format!("Cannot open {}", filename)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: for loop over `function_call.captures(&line)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | for captures in function_call.captures(&line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for captures in function_call.captures(&line)` with `if let Some(captures) = function_call.captures(&line)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | fn get_tgf>(edges: &Vec<(T, T)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[(T, T)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lua_call_tgf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `print_more` [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let print_more = matches.is_present("verbose"); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_print_more` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | File::open(filename).expect(&format!("Cannot open {}", filename)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: for loop over `function_call.captures(&line)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | for captures in function_call.captures(&line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for captures in function_call.captures(&line)` with `if let Some(captures) = function_call.captures(&line)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | fn get_tgf>(edges: &Vec<(T, T)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[(T, T)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lua_call_tgf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "abe283ca33ec33ea1de607ce39abcb8dfd3e3db94fad2dfe1838f3fc0b2d99aa"` [INFO] running `"docker" "rm" "-f" "abe283ca33ec33ea1de607ce39abcb8dfd3e3db94fad2dfe1838f3fc0b2d99aa"` [INFO] [stdout] abe283ca33ec33ea1de607ce39abcb8dfd3e3db94fad2dfe1838f3fc0b2d99aa