[INFO] updating cached repository RustUser/Rust-Switch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RustUser/Rust-Switch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RustUser/Rust-Switch" "work/ex/clippy-test-run/sources/stable/gh/RustUser/Rust-Switch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RustUser/Rust-Switch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RustUser/Rust-Switch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustUser/Rust-Switch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustUser/Rust-Switch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b80ffff8aec28f3c582431833132ff6f1c34d5d3 [INFO] sha for GitHub repo RustUser/Rust-Switch: b80ffff8aec28f3c582431833132ff6f1c34d5d3 [INFO] validating manifest of RustUser/Rust-Switch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RustUser/Rust-Switch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RustUser/Rust-Switch [INFO] finished frobbing RustUser/Rust-Switch [INFO] frobbed toml for RustUser/Rust-Switch written to work/ex/clippy-test-run/sources/stable/gh/RustUser/Rust-Switch/Cargo.toml [INFO] started frobbing RustUser/Rust-Switch [INFO] finished frobbing RustUser/Rust-Switch [INFO] frobbed toml for RustUser/Rust-Switch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustUser/Rust-Switch/Cargo.toml [INFO] crate RustUser/Rust-Switch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RustUser/Rust-Switch against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustUser/Rust-Switch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f54cc68bbbebf5cb94e268e50a70338c72e0f9dec0be788f2cbf837c06fb0d5 [INFO] running `"docker" "start" "-a" "3f54cc68bbbebf5cb94e268e50a70338c72e0f9dec0be788f2cbf837c06fb0d5"` [INFO] [stderr] Checking RustSwitch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / return Switch { [INFO] [stderr] 10 | | value: Switch::default_value() [INFO] [stderr] 11 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | Switch { [INFO] [stderr] 10 | value: Switch::default_value() [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Switch { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Switch { [INFO] [stderr] 22 | value [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return !self.invert(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.invert()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `switch::*` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use switch::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point { [INFO] [stderr] 14 | | x, [INFO] [stderr] 15 | | y, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point { [INFO] [stderr] 14 | x, [INFO] [stderr] 15 | y, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / return Switch { [INFO] [stderr] 10 | | value: Switch::default_value() [INFO] [stderr] 11 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | Switch { [INFO] [stderr] 10 | value: Switch::default_value() [INFO] [stderr] 11 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Switch { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Switch { [INFO] [stderr] 22 | value [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return !self.invert(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.invert()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/switch.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return self.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `switch::*` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use switch::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point { [INFO] [stderr] 14 | | x, [INFO] [stderr] 15 | | y, [INFO] [stderr] 16 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point { [INFO] [stderr] 14 | x, [INFO] [stderr] 15 | y, [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `init` [INFO] [stderr] --> src/switch.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn init(value: bool) -> Switch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view` [INFO] [stderr] --> src/switch.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn view(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `RustSwitch` should have a snake case name such as `rust_switch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `init` [INFO] [stderr] --> src/switch.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn init(value: bool) -> Switch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view` [INFO] [stderr] --> src/switch.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn view(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `RustSwitch` should have a snake case name such as `rust_switch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `"docker" "inspect" "3f54cc68bbbebf5cb94e268e50a70338c72e0f9dec0be788f2cbf837c06fb0d5"` [INFO] running `"docker" "rm" "-f" "3f54cc68bbbebf5cb94e268e50a70338c72e0f9dec0be788f2cbf837c06fb0d5"` [INFO] [stdout] 3f54cc68bbbebf5cb94e268e50a70338c72e0f9dec0be788f2cbf837c06fb0d5